Skip to content
  • Richard Mansfield's avatar
    Fix method names in auth plugin and instance configuration (bug #933937) · 11bcc0d0
    Richard Mansfield authored
    
    
    The validation/submission methods called during auth *plugin*
    configuration and auth *instance* configuration have the same names,
    but in each of these cases, the methods deal with completely different
    data, and are passed arguments in a different order.
    
    This is a problem for the saml plugin, which needs to detect where
    it's being called from, and reverse the order of the arguments if
    necessary.
    
    To fix this, the new methods validate_instance_config_options and
    save_instance_config_options are called during instance configuration,
    and the names 'validate_config_options' and 'save_config_options' are
    left for global plugin configuration, as these are the names used for
    all other plugin types.
    
    The old names are still usable in case any third party auth plugins
    are relying on them, but they'll produce a warning when called during
    instance configuration.
    
    Change-Id: I996ed7a2cdbe0e50dcb0c88560d10a2044b4e21c
    Signed-off-by: default avatarRichard Mansfield <richard.mansfield@catalyst.net.nz>
    11bcc0d0