Skip to content
  • Richard Mansfield's avatar
    Use correct id in labels in pieform 'oneline' forms (bug #771154) · a1049a62
    Richard Mansfield authored
    
    
    In forms using the 'oneline' renderer, label elements were being
    generated with a 'for' attribute that didn't contain the correct
    element id of the corresponding input element, so the field could
    not be selected by clicking on the label.
    
    It appears that at some point in the past, the label generation was
    moved out of the renderers and into a function in core pieforms,
    but I believe the oneline renderer was overlooked at this time, as
    it is not using this generated label.
    
    This patch removes the label html generation from the oneline
    renderer, and replaces it with the label html generated by core
    pieform.php.
    
    Change-Id: Ic607a7e169ffd8e874479c3683695ef86b06e7f0
    Signed-off-by: default avatarRichard Mansfield <richard.mansfield@catalyst.net.nz>
    a1049a62