Skip to content
  • Richard Mansfield's avatar
    Fix remote avatars broken by 'profileiconbyid' commit (bug #924777) · ab3b5a19
    Richard Mansfield authored
    Commit 011c5039 changed lot of thumb.php urls to use the
    type=profileiconbyid parameter (which takes an artefact id) rather
    than type=profileicon (which takes a user id, and which cannot be
    cached).
    
    Unfortunately, when a user has no locally stored profile icon, use of
    type=profileiconbyid stops their remote gravatar image from being
    displayed.
    
    This commit updates the thumb.php urls that were changed in commit
    011c5039 to use the profile_icon_url() function, which respects
    remote avatars when no local profileicon is available.
    
    In some cases this requires a new size of the no_userphoto.png image,
    so three new sizes are added in the raw theme.  The four no_userphoto
    images in the custom theme were duplicates of those in raw, and are
    removed.
    
    Finally, the type=profileiconbyid change from commit 011c5039
    
     in the
    viewacl.tpl template has been reverted back to type=profileicon.
    Because this url is constructed in javascript, it is not worth the
    trouble to use a profile_icon_url call here until the number of
    requests to thumb.php really becomes a problem.
    
    Change-Id: I7dce7090842999fe090dc2d8c481cb4aca7720d5
    Signed-off-by: default avatarRichard Mansfield <richard.mansfield@catalyst.net.nz>
    ab3b5a19