• Nigel Cunningham's avatar
    (Bug785472) Remove unneeded raise_memory_limit calls · 039564a5
    Nigel Cunningham authored
    On the basis of my profiling and testing over the last week,
    all of the scripts affected by this patch don't need their
    raise_memory_limit calls. Ensure_sanity currently sets the
    memory limit to 128MB, which has been seen to be more than
    sufficient for each of these use cases.
    
    Tests have involved at least 1000 records being imported in
    each case, and sometimes as many as 20,000. I would have
    liked to have tested with some really full profiles (eg
    lots of pictures and content), but am satisfied that there's
    enough margin to cover those cases. In any case, such files
    are often handled using external apps and therefore won't
    be counted toward PHP's memory use anyway. Finally, the
    limit can easily be increased by the user if necessary for
    a particular case.
    
    Change-Id: Ifecc83fd47da51268bae6cbd6960735eb91f9403
    Signed-off-by: default avatarNigel Cunningham <nigelc@catalyst-au.net>
    039564a5
csvfile.php 6.33 KB