Skip to content
  • Hugh Davenport's avatar
    Fix behaviour on submitting multiple pages to Moodle · fd9f1f82
    Hugh Davenport authored and Aaron Wells's avatar Aaron Wells committed
    Bug 1516823
    
    The moodle plugin for mahara assignment submissions [1] had an issue [2]
    where is the plugin was configured in non locking mode, multiple
    submissions of the same view would result in only the latest submitted
    link working.
    
    This was due to the page getting locked then released, which resulted in
    a new mt token, which made all the old ones not work. This patch changes
    that by accepting a new parameter which checks whether you are locking
    and if not, then don't generate and send a token back.
    
    When viewing a view, check for the new parameter mnetviewid or mnetcollid
    along with the parameter assignment. If these are present, then Mahara
    sends an MNet request back to Moodle which tells Mahara whether the user
    has the permission to view the page.
    
    This requires an update to the Moodle plugin, which is sent for review
    currently [3]. Mahara detects whether this plugin is upgraded and
    publishing the new MNet function. If it isn't, it falls back to original
    behaviour gracefully. This is done by attempting to send a MNet request.
    
    [1] https://github.com/MaharaProject/moodle-assignsubmission_mahara
    [2] https://github.com/MaharaProject/moodle-assignsubmission_mahara/issues/2
    [3] https://github.com/MaharaProject/moodle-assignsubmission_mahara/pull/19
    
    behatnotneeded: Can't yet test MNet issues in Behat
    
    Change-Id: I80739181b58bf7cf9c326e7b0a588b6239f864f1
    fd9f1f82