I18n-ise the 'submit view for assessment' form. Added a note about how suckily...

I18n-ise the 'submit view for assessment' form. Added a note about how suckily it's generated. Fixes #1940.

htdocs/lang/en.utf8/view.php

@@ -52,7 +52,8 @@ $string['viewsubmitted'] = 'View submitted';
 $string['editviewnameanddescription'] = 'Edit view details';
 $string['editviewaccess'] = 'Edit view access';
 $string['deletethisview'] = 'Delete this view';
-$string['submitviewforassessment'] = 'Submit view for assessment';
+$string['submitthisviewto'] = 'Submit this view to';
+$string['forassessment'] = 'for assessment';
 $string['accessfromdate'] = 'Nobody can see this view before %s';
 $string['accessuntildate'] = 'Nobody can see this view after %s';
 $string['accessbetweendates'] = 'Nobody can see this view before %s or after %s';

htdocs/view/index.php

@@ -163,6 +163,8 @@ else {
     $i = 0;
     foreach ($data as &$view) {
         if (empty($view['submittedto'])) {
+            // This form sucks from a language string point of view. It should 
+            // use pieforms' form template feature
             $view['submitto'] = pieform(array(
                 'name' => 'submitto' . $i++,
                 'method' => 'post',
@@ -172,7 +174,7 @@ else {
                 'elements' => array(
                     'text1' => array(
                         'type' => 'html',
-                        'value' => 'Submit this view to '
+                        'value' => get_string('submitthisviewto', 'view') . ' ',
                     ),
                     'options' => array(
                         'type' => 'select',
@@ -181,11 +183,11 @@ else {
                     ),
                     'text2' => array(
                         'type' => 'html',
-                        'value' => ' for assessment',
+                        'value' => get_string('forassessment', 'view'),
                     ),
                     'submit' => array(
                         'type' => 'submit',
-                        'value' => get_string('go')
+                        'value' => get_string('submit')
                     ),
                     'view' => array(
                         'type' => 'hidden',