Enable username search in new installs & move site option to user settings

Signed-off-by: Richard Mansfield <richardm@catalyst.net.nz>

htdocs/admin/site/options.php

@@ -145,6 +145,13 @@ $siteoptionform = array(
                     'defaultvalue' => get_config('userscanhiderealnames'),
                     'disabled'     => in_array('userscanhiderealnames', $OVERRIDDEN),
                 ),
+                'searchusernames' => array(
+                    'type'         => 'checkbox',
+                    'title'        => get_string('searchusernames', 'admin'),
+                    'description'  => get_string('searchusernamesdescription', 'admin'),
+                    'defaultvalue' => get_config('searchusernames'),
+                    'disabled'     => in_array('searchusernames', $OVERRIDDEN),
+                ),
                 'anonymouscomments' => array(
                     'type'         => 'checkbox',
                     'title'        => get_string('anonymouscomments', 'admin'),
@@ -206,13 +213,6 @@ $siteoptionform = array(
                     'description'  => get_string('allowgroupcategoriesdescription', 'admin'),
                     'defaultvalue' => get_config('allowgroupcategories'),
                 ),
-                'searchusernames' => array(
-                    'type'         => 'checkbox',
-                    'title'        => get_string('searchusernames', 'admin'),
-                    'description'  => get_string('searchusernamesdescription', 'admin'),
-                    'defaultvalue' => get_config('searchusernames'),
-                    'disabled'     => in_array('searchusernames', $OVERRIDDEN),
-                ),
             ),
         ),
         'institutionsettings' => array(

htdocs/lib/upgrade.php

@@ -702,6 +702,7 @@ function core_install_firstcoredata_defaults() {
     set_config('homepageinfo', 1);
     set_config('showonlineuserssideblock', 1);
     set_config('footerlinks', serialize(array('privacystatement', 'about', 'contactus')));
+    set_config('searchusernames', 1);
 
     // install the applications
     $app = new StdClass;