Change order of edit page navigation bar

Order is now
- Edit Title and Description
- Edit Layout
- Edit Content
- Display
- Share

The title and description page is opened by default
for all new and existing pages when edit is selected

Bug #761834

Change-Id: I0986f2953de81e75c042c67b4c09c069cb373ec4
Signed-off-by: Hugh Davenport <hugh@catalyst.net.nz>

htdocs/lib/view.php

@@ -3800,7 +3800,7 @@ function createview_submit(Pieform $form, $values) {
         $view = View::create($values);
     }
 
-    redirect(get_config('wwwroot') . 'view/blocks.php?new=1&id=' . $view->get('id'));
+    redirect(get_config('wwwroot') . 'view/edit.php?new=1&id=' . $view->get('id'));
 }
 
 function createview_cancel_submit(Pieform $form, $values) {

htdocs/theme/raw/templates/view/editviewtabs.tpl

 
 <ul class="in-page-tabs edit-view-tabs">
-  <li><a{if $selected == 'content'} class="current-tab"{/if} href="{$WWWROOT}view/blocks.php?id={$viewid}{if $new}&new=1{/if}">{str tag=editcontent section=view}</a></li>
   {if $edittitle}<li><a{if $selected == 'title'} class="current-tab"{/if} href="{$WWWROOT}view/edit.php?id={$viewid}{if $new}&new=1{/if}">{str tag=edittitleanddescription section=view}</a></li>{/if}
   <li><a{if $selected == 'layout'} class="current-tab"{/if} href="{$WWWROOT}view/layout.php?id={$viewid}{if $new}&new=1{/if}">{str tag=editlayout section=view}</a></li>
+  <li><a{if $selected == 'content'} class="current-tab"{/if} href="{$WWWROOT}view/blocks.php?id={$viewid}{if $new}&new=1{/if}">{str tag=editcontent section=view}</a></li>
   <li class="displaypage"><a href="{$displaylink}{if $new}&new=1{/if}">{str tag=displayview section=view} &raquo;</a></li>
   {if $edittitle}<li class="sharepage"><a href="{$WWWROOT}view/access.php?id={$viewid}{if $new}&new=1{/if}">{str tag=shareview section=view} &raquo;</a></li>{/if}
 </ul>

htdocs/theme/raw/templates/view/index.tpl

@@ -47,7 +47,7 @@
                         </td>
                         <td class="right buttonscell btns2">
 {if !$view.submittedto}
-                                <a href="{$WWWROOT}view/blocks.php?id={$view.id}" title="{str tag ="editcontentandlayout" section="view"}"><img src="{theme_url filename='images/edit.gif'}" alt="{str tag=edit}"></a>
+                                <a href="{$WWWROOT}view/edit.php?id={$view.id}" title="{str tag ="editcontentandlayout" section="view"}"><img src="{theme_url filename='images/edit.gif'}" alt="{str tag=edit}"></a>
 {/if}
 {if !$view.submittedto && $view.removable}
                                 <a href="{$WWWROOT}view/delete.php?id={$view.id}" title="{str tag=deletethisview section=view}"><img src="{theme_url filename='images/icon_close.gif'}" alt="{str tag=delete}"></a>