Commit 2710fdb0 authored by Robert Lyon's avatar Robert Lyon
Browse files

Bugs 1620175, 1620176: Only variables should be assigned by reference



Another PHP7 issue to fix up - we don't need to reference smarty() as
the bit needing to be referenced the 'new Dwoo_Mahara()' is done
automatically as the 'new' operator returns a reference automatically.

behatnotneeded

Change-Id: Ie0982365cf45d893363f52fcde6043f02869d988
Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
parent 363a224c
...@@ -106,7 +106,7 @@ $form['elements']['group'] = array('type' => 'hidden', 'value' => ($groupid) ? $ ...@@ -106,7 +106,7 @@ $form['elements']['group'] = array('type' => 'hidden', 'value' => ($groupid) ? $
$form = pieform($form); $form = pieform($form);
$smarty =& smarty(); $smarty = smarty();
$smarty->assign_by_ref('form', $form); $smarty->assign_by_ref('form', $form);
$smarty->display('form.tpl'); $smarty->display('form.tpl');
exit; exit;
......
...@@ -34,7 +34,7 @@ else { ...@@ -34,7 +34,7 @@ else {
$form = ArtefactTypePlan::get_form(); $form = ArtefactTypePlan::get_form();
} }
$smarty =& smarty(); $smarty = smarty();
$smarty->assign_by_ref('form', $form); $smarty->assign_by_ref('form', $form);
$smarty->assign_by_ref('PAGEHEADING', hsc(TITLE)); $smarty->assign_by_ref('PAGEHEADING', hsc(TITLE));
$smarty->display('artefact:plans:new.tpl'); $smarty->display('artefact:plans:new.tpl');
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment