(#3098) Speculative fix - allow user ID 0 to be retrieved by

User->find_by_id.

htdocs/auth/user.php

@@ -117,7 +117,7 @@ class User {
                 WHERE
                     id = ?';
 
-        $user = get_record_sql($sql, $id);
+        $user = get_record_sql($sql, array($id));
 
         if (false == $user) {
             throw new AuthUnknownUserException("User with id \"$id\" is not known");

htdocs/lib/user.php

@@ -917,7 +917,7 @@ function can_send_message($from, $to) {
 }
 
 function load_user_institutions($userid) {
-    if (empty($userid)) {
+    if (!is_numeric($userid) || $userid < 0) {
         throw new InvalidArgumentException("couldn't load institutions, no user id specified");
     }
     if ($institutions = get_records_sql_assoc('