Don't use call time passing by reference for a solr method. Fixes #2099.

Also, put a line in the .htaccess file to turn allow_call_time_pass_reference off. This way we'll never be caught by this issue again, not because php will not warn about it, but because developers will see these types of problems and fix them.

htdocs/.htaccess

@@ -3,6 +3,7 @@ php_flag magic_quotes_runtime off
 php_flag magic_quotes_sybase off
 php_flag magic_quotes_gpc off
 php_flag log_errors on
+php_flag allow_call_time_pass_reference off
 <Files config.php>
     Order deny,allow
     deny from all

htdocs/search/solr/lib.php

@@ -289,7 +289,7 @@ END;
         $q = join(' AND ', array_merge($q, $neg));
 
         $results = self::send_query($q, $limit, 0, array('type' => 'user'), $fields);
-        self::remove_key_prefix(&$results);
+        self::remove_key_prefix($results);
         return $results;
         
     }