Commit 3325ffb0 authored by Nigel McNie's avatar Nigel McNie
Browse files

Don't use call time passing by reference for a solr method. Fixes #2099.

Also, put a line in the .htaccess file to turn allow_call_time_pass_reference off. This way we'll never be caught by this issue again, not because php will not warn about it, but because developers will see these types of problems and fix them.
parent 564fa161
...@@ -3,6 +3,7 @@ php_flag magic_quotes_runtime off ...@@ -3,6 +3,7 @@ php_flag magic_quotes_runtime off
php_flag magic_quotes_sybase off php_flag magic_quotes_sybase off
php_flag magic_quotes_gpc off php_flag magic_quotes_gpc off
php_flag log_errors on php_flag log_errors on
php_flag allow_call_time_pass_reference off
<Files config.php> <Files config.php>
Order deny,allow Order deny,allow
deny from all deny from all
...@@ -289,7 +289,7 @@ END; ...@@ -289,7 +289,7 @@ END;
$q = join(' AND ', array_merge($q, $neg)); $q = join(' AND ', array_merge($q, $neg));
$results = self::send_query($q, $limit, 0, array('type' => 'user'), $fields); $results = self::send_query($q, $limit, 0, array('type' => 'user'), $fields);
self::remove_key_prefix(&$results); self::remove_key_prefix($results);
return $results; return $results;
} }
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment