Bug 1728815: Not include the logoxs column in sql query until it exists

As it causes problems on upgrade

behatnotneeded

Change-Id: Id330f8c31c763dffce6f559557c9c78ac27ac58f
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

htdocs/lib/user.php

@@ -1787,8 +1787,16 @@ function load_user_institutions($userid) {
         throw new InvalidArgumentException("couldn't load institutions, no user id specified");
     }
     $userid = (int) $userid;
+
+    require_once('ddl.php');
+    $table = new XMLDBTable('institution');
+    $field = new XMLDBField('logoxs');
+    $logoxs = field_exists($table, $field) ? ',i.logoxs' : '';
     if ($userid !== 0 && $institutions = get_records_sql_assoc('
-        SELECT u.institution,'.db_format_tsfield('ctime').','.db_format_tsfield('u.expiry', 'membership_expiry').',u.studentid,u.staff,u.admin,i.displayname,i.theme,i.registerallowed, i.showonlineusers,i.allowinstitutionpublicviews, i.logo, i.logoxs, i.style, i.licensemandatory, i.licensedefault, i.dropdownmenu, i.skins, i.suspended
+        SELECT u.institution, ' . db_format_tsfield('ctime') . ',' . db_format_tsfield('u.expiry', 'membership_expiry') . ',
+               u.studentid, u.staff, u.admin, i.displayname, i.theme, i.registerallowed, i.showonlineusers,
+               i.allowinstitutionpublicviews, i.logo' . $logoxs . ', i.style, i.licensemandatory, i.licensedefault,
+               i.dropdownmenu, i.skins, i.suspended
         FROM {usr_institution} u INNER JOIN {institution} i ON u.institution = i.name
         WHERE u.usr = ? ORDER BY i.priority DESC', array($userid))) {
         return $institutions;