Skip to content
GitLab
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
mahara
mahara
Commits
375e174c
Commit
375e174c
authored
Jul 03, 2008
by
Richard Mansfield
Browse files
Fix bug when editing non-group views
parent
cede5624
Changes
1
Hide whitespace changes
Inline
Side-by-side
htdocs/view/edit.php
View file @
375e174c
...
...
@@ -40,7 +40,7 @@ $new = param_boolean('new');
if
(
empty
(
$id
))
{
$new
=
true
;
$group
=
param_integer
(
'group'
,
0
);
$group
=
param_integer
(
'group'
,
null
);
}
else
{
$view
=
new
View
(
$id
);
...
...
@@ -55,9 +55,6 @@ else {
}
$group
=
$view
->
get
(
'group'
);
if
(
empty
(
$group
))
{
$group
=
0
;
}
}
if
(
$group
&&
!
group_user_access
(
$group
))
{
...
...
@@ -92,7 +89,7 @@ if ($studentid !== '') {
}
$ownerformatoptions
[
FORMAT_NAME_DISPLAYNAME
]
=
sprintf
(
$formatstring
,
get_string
(
'displayname'
),
display_name
(
$USER
));
$editview
=
pieform
(
array
(
$editview
=
array
(
'name'
=>
'editview'
,
'method'
=>
'post'
,
'autofocus'
=>
'title'
,
...
...
@@ -107,10 +104,6 @@ $editview = pieform(array(
'type'
=>
'hidden'
,
'value'
=>
$new
,
),
'group'
=>
array
(
'type'
=>
'hidden'
,
'value'
=>
$group
,
),
'title'
=>
array
(
'type'
=>
'text'
,
'title'
=>
get_string
(
'title'
,
'view'
),
...
...
@@ -145,7 +138,16 @@ $editview = pieform(array(
'confirm'
=>
$new
&&
isset
(
$view
)
?
array
(
null
,
get_string
(
'confirmcancelcreatingview'
,
'view'
))
:
null
,
)
),
));
);
if
(
$group
)
{
$editview
[
'elements'
][
'group'
]
=
array
(
'type'
=>
'hidden'
,
'value'
=>
$group
);
}
$editview
=
pieform
(
$editview
);
function
editview_cancel_submit
()
{
global
$view
,
$new
,
$group
;
...
...
@@ -164,7 +166,7 @@ function editview_submit(Pieform $form, $values) {
$editing
=
!
empty
(
$values
[
'id'
]);
$view
=
new
View
(
$values
[
'id'
],
$values
);
$group
=
(
int
)
$values
[
'group'
];
$group
=
isset
(
$values
[
'group'
])
?
(
int
)
$values
[
'group'
]
:
null
;
if
(
$group
&&
!
group_user_access
(
$group
))
{
$SESSION
->
add_error_msg
(
get_string
(
'notamember'
,
'group'
));
redirect
(
'/view/groupviews.php?group='
.
$group
);
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment