Skip to content
GitLab
Menu
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
mahara
mahara
Commits
3e806118
Commit
3e806118
authored
Jul 15, 2015
by
Robert Lyon
Committed by
Gerrit Code Review
Jul 15, 2015
Browse files
Merge "Adjusting the minaccept for deleted version file"
parents
c1731283
8156cb44
Changes
1
Show whitespace changes
Inline
Side-by-side
test/versioncheck.php
View file @
3e806118
...
...
@@ -169,13 +169,17 @@ function validate_version($versionfile, $upgradefile) {
}
echo
"New version:
{
$newconfig
->
version
}
\n
"
;
}
if
(
$newconfig
->
version
<
$oldconfig
->
version
)
{
# Check if version file has been deleted
$isdeleted
=
`git diff HEAD~1 -- {$versionfile} | grep 'deleted file mode'`
;
if
(
$isdeleted
)
{
echo
"WARNING:
{
$versionfile
}
is deleted - this may be due to it being renamed
\n
"
;
}
if
(
$newconfig
->
version
<
$oldconfig
->
version
&&
!
$isdeleted
)
{
echo
"ERROR: Version number in
{
$versionfile
}
has decreased!
\n
"
;
$ERROR
=
true
;
}
if
(
strlen
(
$newconfig
->
version
)
!=
10
)
{
if
(
strlen
(
$newconfig
->
version
)
!=
10
&&
!
$isdeleted
)
{
echo
"ERROR: Version number in
{
$versionfile
}
should be exactly 10 digits.
\n
"
;
$ERROR
=
true
;
}
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment