Bug 1729423: publish correct private comment in the list

similar to bug 1486763

behatnotneeded

Change-Id: Iaa6e337434996303208a0445099825797e65ae3e
(cherry picked from commit 9f98b2d7)

htdocs/artefact/artefact.php

@@ -83,7 +83,7 @@ else {
 }
 
 // Create the "make comment private form" now if it's been submitted
-if (param_variable('make_public_submit', null)) {
+if (param_exists('make_public_submit')) {
     pieform(ArtefactTypeComment::make_public_form(param_integer('comment')));
 }
 else if (param_exists('delete_comment_submit')) {

htdocs/artefact/comment/blocktype/comment/lib.php

@@ -53,7 +53,7 @@ class PluginBlocktypeComment extends MaharaCoreBlocktype {
         $offset      = param_integer('offset', 0);
         $showcomment = param_integer('showcomment', null);
         // Create the "make comment private form" now if it's been submitted
-        if (param_variable('make_public_submit', null)) {
+        if (param_exists('make_public_submit')) {
             pieform(ArtefactTypeComment::make_public_form(param_integer('comment')));
         }
         else if (param_exists('delete_comment_submit')) {

htdocs/view/view.php

@@ -107,7 +107,7 @@ $offset      = param_integer('offset', 0);
 $showcomment = param_integer('showcomment', null);
 
 // Create the "make comment private form" now if it's been submitted
-if (param_variable('make_public_submit', null)) {
+if (param_exists('make_public_submit')) {
     pieform(ArtefactTypeComment::make_public_form(param_integer('comment')));
 }
 else if (param_exists('delete_comment_submit')) {