Bug 1537912: Allow the 'login' link to show when sidebars exist

There was a setting to stop the login link (top right) from showing if
there were sidebars on logged out homepage. This became a problem if
the login box was turned off (not counted as a sidebar block for some
reason) via $cfg->showloginsideblock = false;

But the top right login link should always show when logged out
whether a sidebar is in play or not.

behatnotneeded

Change-Id: I8d6c1916f165285afb1f0210a0ae9b364f3a7a4f
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

htdocs/lib/web.php

@@ -780,6 +780,7 @@ EOF;
                 ),
             );
         }
+        $smarty->assign('SHOWLOGINBLOCK', $isloginblockvisible);
 
         if (get_config('enablenetworking')) {
             require_once(get_config('docroot') .'api/xmlrpc/lib.php');

htdocs/theme/raw/templates/header/topright.tpl

@@ -43,7 +43,7 @@
             </li>
         {/if}
     {/strip}
-    {if !$LOGGEDIN && !$SIDEBARS && !$LOGINPAGE}
+    {if !$LOGGEDIN && !$SHOWLOGINBLOCK && !$LOGINPAGE}
         <li id="loginlink" class="has-icon login-link">
             <a href="{$WWWROOT}?login" accesskey="l">
                 <span class="icon icon-sign-in" role="presentation" aria-hidden="true"></span>