Bug #1796525: Portfolio access report should indicate portfolios that are under review

behatnotneeded

Change-Id: Ic438d8cd00047e708f3846921cfeb2e644703392

htdocs/lib/bootstrap/assets/stylesheets/bootstrap/_tables.scss

@@ -111,7 +111,7 @@ th {
 // Default zebra-stripe styles (alternating gray and transparent backgrounds)
 
 .table-striped {
-  > tbody > tr:nth-child(odd) {
+  > tbody > tr:nth-child(odd):not(.bg-danger) {
     background-color: $table-bg-accent;
   }
 }

htdocs/lib/pieforms/pieform.php

@@ -1534,7 +1534,7 @@ EOF;
                 $labelclass = '';
             }
             $nolabeltypes = array('radio', 'emaillist', 'date', 'files', 'checkboxes', 'bytes');
-            if ($element['type'] == 'select' && !empty($element['collapseifoneoption']) && count($element['options']) < 2) {
+            if ($element['type'] == 'select' && !empty($element['collapseifoneoption']) && !empty($element['options']) && count($element['options']) < 2) {
                 // we are using a select field as a hidden field
                 $element['nolabel'] = true;
             }

htdocs/lib/statistics.php

@@ -3734,6 +3734,7 @@ function accesslist_stats_table($limit, $offset, $extra, $institution, $urllink)
             FROM {view_access} va WHERE va.view = ? AND va.token IS NOT NULL LIMIT 1)",
             array($item->viewid, $item->viewid));
         $item->hasaccessrules = !empty($item->access);
+        $item->pending = is_view_suspended($item->viewid);
     }
 
     if (!empty($extra['csvdownload'])) {

htdocs/theme/raw/templates/admin/users/accesslists.tpl

 {foreach from=$data item=item}
-  <tr class="{cycle values='r0,r1'}">
+  <tr class="{cycle values='r0,r1'} {if $item->pending}bg-danger{/if}">
     {if $columns.rownum}<td>{$offset + $dwoo.foreach.default.iteration}</td>{/if}
     {if $columns.owner}<td><a href="{$item->userurl}">{$item->displayname}</a></td>{/if}
     {if $columns.views}<td>
-        {if $item->views > 0}<a href="{$WWWROOT}view/view.php?id={$item->viewid}">{/if}
+        {if $item->views > 0}{if $item->pending}<div class="detail text-danger"><strong>{str tag="pending" section="view"}</strong></div>{/if}<a href="{$WWWROOT}view/view.php?id={$item->viewid}">{/if}
         {$item->title}
         {if $item->views > 0}</a>{/if}
         </td>{/if}