Bug 1908837: Setting $releaseuser correctly

When archiving a collection

Change-Id: I4c978de93e04dcdedc328f5d31f8dc13d9208159
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 214c899a)

htdocs/lib/collection.php

@@ -1433,6 +1433,7 @@ class Collection {
         View::_db_release($viewids, $this->owner, $this->submittedgroup);
         db_commit();
 
+        $releaseuser = optional_userobj($releaseuser);
         handle_event('releasesubmission', array('releaseuser' => $releaseuser,
                                                 'id' => $this->get('id'),
                                                 'hostname' => $this->submittedhost,
@@ -1443,7 +1444,6 @@ class Collection {
         // (though I'm not sure why)
         // if the method is called in an upgrade and we dont have a release user
         if (!defined('INSTALLER') && $this->submittedgroup) {
-            $releaseuser = optional_userobj($releaseuser);
             $releaseuserdisplay = display_name($releaseuser, $this->owner);
             $releaseuserid = ($releaseuser instanceof User) ? $releaseuser->get('id') : $releaseuser->id;
             $submitinfo = $this->submitted_to();