Commit 60c7eca5 authored by Pat Kira's avatar Pat Kira Committed by Robert Lyon
Browse files

Bug 1606735 - Changed heading markup where possible for accessibility

This patch excludes:
- Admin section
- H4 in the pieform since it was added to improve accessibility
- User generated page/content

Note: There are still number of pages with heading being skipped heading
especially H2. Most of the pages have H1 and H3, H1 for page heading and
h3 for sidebar panel heading. We can look into marking up sideber panels
as sections with header etc.

behatnotneeded: markup and styles changes only

Change-Id: Ic592f5be63aa2e7fbd7e31928db7c230e425f104
parent 8c982568
......@@ -5,9 +5,9 @@
<div id="blogpost-{$postid}" class="panel-body flush">
{if $artefacttitle && $simpledisplay}
<h3 class="title">
<h2 class="title">
{$artefacttitle|safe}
</h3>
</h2>
{/if}
<div class="postdetails metadata">
......@@ -40,7 +40,7 @@
{if isset($attachments)}
<div class="has-attachment panel panel-default collapsible">
<h5 class="panel-heading">
<h3 class="panel-heading">
<a class="text-left collapsed" aria-expanded="false" href="#blog-attach-{$postid}" data-toggle="collapse">
<span class="icon left icon-paperclip" role="presentation" aria-hidden="true"></span>
......@@ -48,7 +48,7 @@
<span class="metadata">({$attachments|count})</span>
<span class="icon icon-chevron-down pull-right collapse-indicator" role="presentation" aria-hidden="true"></span>
</a>
</h5>
</h3>
<!-- Attachment list with view and download link -->
<div id="blog-attach-{$postid}" class="collapse">
<ul class="list-unstyled list-group">
......
{if $artefacttype == 'image' || $artefacttype == 'profileicon'}
<h3 class="title">
<h2 class="title">
{str tag=Preview section=artefact.file}
</h3>
</h2>
<div class="filedata-icon">
<a href="{$downloadpath}">
<img src="{$downloadpath}&maxwidth=400&maxheight=180" alt="">
......
......@@ -64,7 +64,7 @@
<input type="hidden" name="{$prefix}_uploadnumber" id="{$prefix}_uploadnumber" value="1"/>
<input type="hidden" name="MAX_FILE_SIZE" value="{$phpmaxfilesize}" />
<div id="{$prefix}_upload_messages"></div>
<h3 class="title">{str tag='uploadfile' section='artefact.file'}</h3>
<h2 class="title">{str tag='uploadfile' section='artefact.file'}</h2>
<div class="row">
{if $config.uploadagreement || $licenseform}
......
......@@ -32,7 +32,7 @@
<input type="hidden" name="sesskey" value="{$USER->get('sesskey')}">
</form>
<h3>{str tag="uploadprofileicon" section="artefact.file"}</h3>
<h2>{str tag="uploadprofileicon" section="artefact.file"}</h2>
<p class="lead">
{str tag="profileiconsiconsizenotice" section="artefact.file" args=$imagemaxdimensions}
</p>
......
......@@ -75,6 +75,10 @@
display: block;
}
}
.collection-item & {
font-size: $font-size-h3;
}
}
h4.list-group-item-heading {
......
{foreach from=$collections item=collection}
<div class="list-group-item {cycle values='r0,r1'} {if $collection->submitinfo}list-group-item-warning{/if}">
<div class="list-group-item collection-item {if $collection->submitinfo}list-group-item-warning{/if}">
{if $collection->views[0]->view}
<a href="{if $collection->frameworkname}{$collection->fullurl}{else}{$collection->views[0]->fullurl}{/if}" class="outer-link"><span class="sr-only">{$collection->name}</span></a>
{/if}
<div class="row">
<div class="col-md-9">
<h3 class="title list-group-item-heading" title="{str tag=emptycollection section=collection}">
<h2 class="title list-group-item-heading" title="{str tag=emptycollection section=collection}">
{$collection->name}
</h3>
</h2>
<div class="detail">{$collection->description}</div>
<div class="detail">
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment