Fix empty folder display for folder renderfull and listchildren

htdocs/artefact/file/lib.php

@@ -514,22 +514,23 @@ class ArtefactTypeFolder extends ArtefactTypeFileBase {
     }
 
     public function folder_contents() {
-        if ($children = get_records_array('artefact', 'parent', $this->get('id'))) {
-            return $children;
-        }
-        return array();
+        return get_records_array('artefact', 'parent', $this->get('id'));
     }
 
     public function render_full($options) {
         $smarty = smarty();
         $smarty->assign('artefact', $this);
-        $smarty->assign('children', $this->folder_contents());
+        if ($children = $this->folder_contents()) {
+            $smarty->assign('children', $children);
+        }
         return $smarty->fetch('artefact:file:folder_renderfull.tpl');
     }
 
     public function listchildren($options) {
         $smarty = smarty();
-        $smarty->assign('children', $this->folder_contents());
+        if ($children = $this->folder_contents()) {
+            $smarty->assign('children', $children);
+        }
         return $smarty->fetch('artefact:file:folder_listchildren.tpl');
     }
 

htdocs/artefact/file/theme/default/folder_listchildren.tpl

 <div>
-  {if empty($children)}
-    {str tag=emptyfolder section=artefact.file}
-  {else}
+  {if isset($children)}
     <table>
     <tbody>
     {foreach from=$children item=child}
       <tr class="{cycle values=r1,r0}"><td>{$child->title}</td><td>{$child->description}</td></tr>
     {/foreach}
     </tbody></table>
+  {else}
+    {str tag=emptyfolder section=artefact.file}
   {/if}
 </div>

htdocs/artefact/file/theme/default/folder_renderfull.tpl

@@ -10,6 +10,8 @@
       <tr class="{cycle values=r1,r0}"><td>{$child->title}</td><td>{$child->description}</td></tr>
     {/foreach}
     </tbody></table>
+  {else}
+    {str tag=emptyfolder section=artefact.file}
   {/if}
   </div>
 </div>