Commit 9623f879 authored by Robert Lyon's avatar Robert Lyon
Browse files

Checking the remoteusername for parent auth better (Bug #1364170)



Currently it checks lowercase username against the same username

But we need to compare apples wuith apples so the subquery also needs
to return lowercase username.

Change-Id: Icbe65e12d415be6f943399185c828166ed8a98d4
Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
parent c91bac68
...@@ -186,7 +186,7 @@ class User { ...@@ -186,7 +186,7 @@ class User {
( (
LOWER(username) = ( LOWER(username) = (
SELECT SELECT
username LOWER(username)
FROM FROM
{usr} us {usr} us
JOIN JOIN
...@@ -195,8 +195,7 @@ class User { ...@@ -195,8 +195,7 @@ class User {
LOWER(aru.remoteusername) = ' . db_quote($username) . ' LOWER(aru.remoteusername) = ' . db_quote($username) . '
AND us.authinstance = ' . db_quote($parentid) . ' AND us.authinstance = ' . db_quote($parentid) . '
) )
AND AND u.authinstance = ' . db_quote($parentid) . '
u.authinstance = ' . db_quote($parentid) . '
) )
'; ';
} }
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment