Merge "Added alt text to profile pictures so that username links are read (Bug #1259746)"

htdocs/blocktype/recentforumposts/theme/raw/latestforumposts.tpl

@@ -4,7 +4,7 @@
             <tr class="{cycle values='r0,r1'}">
                 <td><h3 class="title"><a href="{$WWWROOT}interaction/forum/topic.php?id={$postinfo->topic|escape}&post={$postinfo->id}">{$postinfo->topicname}</a></h3>
                 <div class="detail">{$postinfo->body|str_shorten_html:100:true|safe}</div></td>
-                <td class="valign right s"><a href="{profile_url($postinfo->author)}"><img src="{profile_icon_url user=$postinfo->author maxheight=20 maxwidth=20}" alt=""> {$postinfo->author|display_name}</a>
+                <td class="valign right s"><a href="{profile_url($postinfo->author)}"><img src="{profile_icon_url user=$postinfo->author maxheight=20 maxwidth=20}" alt="{str tag=profileimagetext arg1=$postinfo->author|display_default_name}"> {$postinfo->author|display_name}</a>
                 </td>
             </tr>
         {/foreach}

htdocs/lang/en.utf8/mahara.php

@@ -642,7 +642,7 @@ $string['more...'] = 'More...';
 $string['nohelpfound'] = 'There was no help found for this item.';
 $string['nohelpfoundpage'] = 'There was no help found for this page.';
 $string['couldnotgethelp'] = 'An error occurred trying to retrieve the help page.';
-$string['profileimage'] = 'Profile picture';
+$string['profileimagetext'] = "%s's profile picture";
 $string['primaryemailinvalid'] = 'Your primary email address is invalid.';
 $string['addemail'] = 'Add email address';
 

htdocs/theme/raw/templates/admin/users/searchiconcolumn.tpl

-<a href="{$WWWROOT}user/view.php?id={$r.id}"><img src="{profile_icon_url user=$r maxwidth=40 maxheight=40}" alt="{str tag=profileimage}" /></a>
+<a href="{$WWWROOT}user/view.php?id={$r.id}"><img src="{profile_icon_url user=$r maxwidth=40 maxheight=40}" alt="{str tag=profileimagetext arg1=$r|display_default_name}" /></a>

htdocs/theme/raw/templates/sideblocks/onlineusers.tpl

@@ -3,9 +3,8 @@
     <div class="sidebar-content">
         <ul class="cr">
 {foreach from=$sbdata.users item=user}
-            <li><a href="{profile_url($user)}"><img src="{$user->profileiconurl}" alt="" class="profile-icon-container"> {$user|display_name}</a>{if $user->loggedinfrom} ({$user->loggedinfrom}){/if}</li>
+            <li><a href="{profile_url($user)}"><img src="{$user->profileiconurl}" alt="{str tag=profileimagetext arg1=$user|display_default_name}" class="profile-icon-container"> {$user|display_name}</a>{if $user->loggedinfrom} ({$user->loggedinfrom}){/if}</li>
 {/foreach}
         </ul>
     <p id="allonline"><a href="{$WWWROOT}user/online.php">{str tag="allonline"}</a></p>
     </div>
-