Fixed an old bug where going back to step three then forward to step for when...

Fixed an old bug where going back to step three then forward to step for when creating a view would cause a bogus ACL entry to appear.

htdocs/lib/form/elements/viewacl.php

@@ -32,7 +32,6 @@
  * @return string           The HTML for the element
  */
 function pieform_element_viewacl(Pieform $form, $element) {
-    // @todo addressbook stuff...
     $smarty = smarty();
     $smarty->left_delimiter  = '{{';
     $smarty->right_delimiter = '}}';
@@ -42,7 +41,8 @@ function pieform_element_viewacl(Pieform $form, $element) {
     // Look for the presets and split them into two groups
     $presets = array('public', 'loggedin', 'friends');
     if ($value) {
-        foreach ($value as &$item) {
+        foreach ($value as $key => &$item) {
+            if (is_array($item)) {
                 if (in_array($item['type'], $presets)) {
                     $item['name'] = get_string($item['type']);
                     $item['preset'] = true;
@@ -51,6 +51,10 @@ function pieform_element_viewacl(Pieform $form, $element) {
                     $item['name'] = pieform_render_viewacl_getvaluebytype($item['type'], $item['id']);
                 }
             }
+            else {
+                unset($value[$key]);
+            }
+        }
     }
     
     $potentialpresets = $presets;