Commit 9af077db authored by Cecilia Vela Gurovic's avatar Cecilia Vela Gurovic
Browse files

Bug 1707076: escape skin titles to display

behatnotneeded

Change-Id: I469f8136e287bb86eb17a32dbed48dec05b87969
parent 05abaad2
......@@ -387,7 +387,6 @@ class Skin {
);
}
/**
* Gets all site skins
* @return array
......
......@@ -24,7 +24,7 @@
<ul class="metadata unstyled">
{if $currentskin}
<li class="title">
<span class="h4 text-midtone">{$currenttitle|safe}</span>
<span class="h4 text-midtone">{$currenttitle}</span>
</li>
{/if}
{if $currentmetadata}
......@@ -85,7 +85,7 @@
<a onClick = "change_skin({$viewid}, {$skin->id})">
<img src="{$WWWROOT}skin/thumb.php?id={$skin->id}" class="thumbnail" width="180" alt="{$skin->title}"/>
<div class="lead text-center text-small">
{$skin->title|safe}
{$skin->title}
</div>
</a>
</div>
......@@ -106,7 +106,7 @@
<a onClick = "change_skin({$viewid}, {$skin->id})">
<img src="{$WWWROOT}skin/thumb.php?id={$skin->id}" class="thumbnail" width="180" alt="{$skin->title}"/>
<div class="lead text-center text-small">
{$skin->title|safe}
{$skin->title}
</div>
</a>
</div>
......@@ -127,7 +127,7 @@
<a onClick="change_skin({$viewid}, {$skin->id})">
<img src="{$WWWROOT}skin/thumb.php?id={$skin->id}" class="thumbnail" width="180" alt="{$skin->title}"/>
<div class="lead text-center text-small">
{$skin->title|safe}
{$skin->title}
</div>
</a>
</div>
......
......@@ -496,7 +496,7 @@ function get_skin_elements() {
$snippet->assign('currenttitle', $currentskin->title);
$snippet->assign('currentmetadata', (!empty($currentskin->metadata)) ? $currentskin->metadata : null);
$snippet->assign('userskins', $userskins);
$snippet->assign('favorskins', $favorskins);
$snippet->assign('favorskins',$favorskins);
$snippet->assign('siteskins', $siteskins);
$snippet->assign('defaultskin', $defaultskin);
$snippet->assign('viewid', $view->get('id'));
......
......@@ -69,7 +69,6 @@ $favorskins = Skin::get_favorite_skins();
$siteskins = Skin::get_site_skins();
$defaultskin = Skin::get_default_skin();
$smarty = smarty_core();
$smarty->assign('saved', $saved);
$smarty->assign('incompatible', $incompatible);
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment