From 9f98b2d7542be8714ba60aa2f1e0e6c4402ff821 Mon Sep 17 00:00:00 2001 From: Cecilia Vela Gurovic Date: Mon, 6 Nov 2017 16:04:47 +1300 Subject: [PATCH] Bug 1729423: publish correct private comment in the list similar to bug 1486763 behatnotneeded Change-Id: Iaa6e337434996303208a0445099825797e65ae3e --- htdocs/artefact/artefact.php | 2 +- htdocs/artefact/comment/blocktype/comment/lib.php | 2 +- htdocs/view/view.php | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/htdocs/artefact/artefact.php b/htdocs/artefact/artefact.php index 2a01aa1a98..f96e0d8c8e 100644 --- a/htdocs/artefact/artefact.php +++ b/htdocs/artefact/artefact.php @@ -83,7 +83,7 @@ else { } // Create the "make comment private form" now if it's been submitted -if (param_variable('make_public_submit', null)) { +if (param_exists('make_public_submit')) { pieform(ArtefactTypeComment::make_public_form(param_integer('comment'))); } else if (param_exists('delete_comment_submit')) { diff --git a/htdocs/artefact/comment/blocktype/comment/lib.php b/htdocs/artefact/comment/blocktype/comment/lib.php index 16c234af53..922aca195e 100644 --- a/htdocs/artefact/comment/blocktype/comment/lib.php +++ b/htdocs/artefact/comment/blocktype/comment/lib.php @@ -53,7 +53,7 @@ class PluginBlocktypeComment extends MaharaCoreBlocktype { $offset = param_integer('offset', 0); $showcomment = param_integer('showcomment', null); // Create the "make comment private form" now if it's been submitted - if (param_variable('make_public_submit', null)) { + if (param_exists('make_public_submit')) { pieform(ArtefactTypeComment::make_public_form(param_integer('comment'))); } else if (param_exists('delete_comment_submit')) { diff --git a/htdocs/view/view.php b/htdocs/view/view.php index 74fc7f764f..d310bd6d2e 100644 --- a/htdocs/view/view.php +++ b/htdocs/view/view.php @@ -107,7 +107,7 @@ $offset = param_integer('offset', 0); $showcomment = param_integer('showcomment', null); // Create the "make comment private form" now if it's been submitted -if (param_variable('make_public_submit', null)) { +if (param_exists('make_public_submit')) { pieform(ArtefactTypeComment::make_public_form(param_integer('comment'))); } else if (param_exists('delete_comment_submit')) { -- GitLab