usability: add pieforms support for fieldset help, and use it for resume fields

Signed-off-by: Evan Goldenberg <evang@catalyst.net.nz>
Signed-off-by: Francois Marier <francois@catalyst.net.nz>

htdocs/artefact/resume/index.php

@@ -80,13 +80,13 @@ $coverletterform = pieform(array(
                     'cols'  => 70,
                     'rows'  => 10,
                     'defaultvalue' => ((!empty($coverletter)) ? $coverletter->get('description') : null),
-                    'help' => true,
                 ),
                 'save' => array(
                     'type' => 'submit',
                     'value' => get_string('save'),
                 ),
-            )
+            ),
+            'help' => true,
         )
     )
 ));
@@ -108,13 +108,13 @@ $interestsform = pieform(array(
                     'defaultvalue' => ((!empty($interest)) ? $interest->get('description') : null),
                     'cols'  => 70,
                     'rows'  => 10,
-                    'help'  => true,
                 ),
                 'save' => array(
                     'type' => 'submit',
                     'value' => get_string('save'),
                 ),
-            )
+            ),
+            'help' => true,
         )
     )
 ));
@@ -134,9 +134,9 @@ $contactinformationform = pieform(array(
                 'contactinformation' => array(
                     'type'  => 'html',
                     'value' => $contactinformation_value,
-                    'help'  => true,
                 ),
-            )
+            ),
+            'help' => true,
         )
     )
 ));

htdocs/lib/pieforms/pieform/elements/fieldset.php

@@ -69,6 +69,16 @@ function pieform_element_fieldset(Pieform $form, $element) {/*{{{*/
         else {
             $result .= '>' . Pieform::hsc($element['legend']);
         }
+        // Help icon
+        if (!empty($element['help'])) {
+            $function = $form->get_property('helpcallback');
+            if (function_exists($function)) {
+                $result .= $function($form, $element);
+            }
+            else {
+                $result .= '<span class="help"><a href="" title="' . Pieform::hsc($element['help']) . '" onclick="return false;">?</a></span>';
+            }
+        }
         $result .= "</legend>\n";
     }
 

htdocs/theme/raw/static/style/style.css

@@ -332,7 +332,7 @@ fieldset.collapsed table {
 	border: 0;
 	margin: 0;
 }
-fieldset legend a {
+fieldset.collapsible legend a {
     padding-left: 15px;
     background: url(../images/icon_fieldset_down.gif) 2px center no-repeat;
 }