Bug 1630764: fixing for update user via webservices

The fields that exists in usr table that also need updating in
artefact table for artefacttype, eg studentid

behatnotneeded

Change-Id: Id9ad96fd651423b1a8078ddc8cf7de87a857bf39
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

htdocs/webservice/functions/mahara_user_external.php

@@ -561,6 +561,13 @@ class mahara_user_external extends external_api {
                     $profilefields->{$field} = $user[$field];
                 }
             }
+            // We need to update the following fields for both the usr and artefact tables
+            foreach (array('firstname', 'lastname', 'email', 'studentid', 'preferredname') as $field) {
+                if (isset($user[$field])) {
+                    $profilefields->{$field} = $user[$field];
+                }
+            }
+
             update_user($updated_user, $profilefields, $remoteuser);
         }
         db_commit();