Set group view access on creation of group views

htdocs/view/edit.php

@@ -186,6 +186,17 @@ function editview_submit(Pieform $form, $values) {
     }
 
     $view->commit();
+    if (empty($editing) && $group) {
+        // By default, group views should be visible to the group
+        $view->set_access(array(array(
+            'type' => 'group',
+            'id' => $group,
+            'startdate' => null,
+            'stopdate' => null,
+            'role' => null
+        )));
+        $view->commit();
+    }
 
     if ($values['new']) {
         $redirecturl = '/view/blocks.php?id=' . $view->get('id') . '&new=1';

htdocs/view/groupviews.php

@@ -59,7 +59,7 @@ $pagination = build_pagination(array(
 $smarty = smarty();
 $smarty->assign('groupid', $group);
 $smarty->assign('views', $data->data);
-$smarty->assign('caneditgroupviews', group_user_can_edit_views($group));
+$smarty->assign('caneditgroupview', group_user_can_edit_views($group));
 $smarty->assign('pagination', $pagination['html']);
 $smarty->assign('heading', get_string('groupviewsfor', 'view', get_field('group', 'name', 'id', $group)));
 $smarty->display('view/index.tpl');