[#2991] Delete auth_remote_user records when deleting user accounts. Don't...

[#2991] Delete auth_remote_user records when deleting user accounts. Don't check for deletion when landing from SSO.

htdocs/auth/xmlrpc/lib.php

@@ -166,10 +166,6 @@ class AuthXmlrpc extends Auth {
                 $user->find_by_instanceid_username($this->instanceid, $remoteuser->username, true);
             }
 
-            if ($user->get('deleted')) {
-                die_info(get_string('accountdeleted', 'mahara'));
-            }
-
             if ($user->get('suspendedcusr')) {
                 die_info(get_string('accountsuspended', 'mahara', strftime(get_string('strftimedaydate'), $user->get('suspendedctime')), $user->get('suspendedreason')));
             }

htdocs/lib/user.php

@@ -689,6 +689,9 @@ function delete_user($userid) {
         WHERE owner = ?
         OR requester = ?', array($userid, $userid));
 
+    // Remove remote user records
+    delete_records('auth_remote_user', 'localusr', $userid);
+
     db_commit();
 
     handle_event('deleteuser', $userid);