Fix for group view access in IE (bugs 3249, 3253)

htdocs/lib/db/upgrade.php

@@ -943,6 +943,11 @@ function xmldb_core_upgrade($oldversion=0) {
         drop_table($table);
     }
 
+    if ($oldversion < 2009040900) {
+        // The view access page has been putting the string 'null' in as a group role in IE.
+        set_field('view_access_group', 'role', null, 'role', 'null');
+    }
+
     return $status;
 }
 

htdocs/lib/version.php

@@ -27,7 +27,7 @@
 defined('INTERNAL') || die();
 
 $config = new StdClass;
-$config->version = 2009031800;
+$config->version = 2009040900;
 $config->release = '1.2.0dev';
 $config->minupgradefrom = 2008040200;
 $config->minupgraderelease = '1.0.0 (release tag 1.0.0_RELEASE)';

htdocs/theme/default/templates/form/viewacl.tpl

@@ -85,7 +85,7 @@ function renderAccessListItem(item) {
     var row = TABLE({'class': cssClass},
         TBODY(null, 
             TR(null,
-                TH(null, name,  (item.role ? ' - ' + item.roledisplay : '')),
+                TH(null, name,  (item.role != null ? ' - ' + item.roledisplay : '')),
                 TD({'class': 'right removebutton'}, removeButton)
             ),
             TR(null,
@@ -105,7 +105,7 @@ function renderAccessListItem(item) {
                     :
                     null
                     ),
-                    (typeof(item.role) != 'undefined' ?
+                    (item.role != null ?
                     INPUT({
                         'type': 'hidden',
                         'name': 'accesslist[' + count + '][role]',