GitLab

Evonne Cheung authored Jul 10, 2013 and Robert Lyon committed Jul 19, 2013

Here are all the UI changes that were made by Evonne

Change-Id: I08d98d759a701deaf0a332af9e9392b7270704a5
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Change-Id: I33ce7dc6e6c14917c9632afc672c0faf5718647b

Add a new function Artefact::artefact_get_tags($artefactid)
to return a list of sorted tags associated to an artefact

Display tags of plans

Change-Id: I3720b4954be2e928539e75362dab8059fbe35169

Change the help text handling so that when a help text is not found for a
specific form/element combination, it also looks for a wildcard ANY/element
help text.

This is used by the license metadata feature to provide uniform help text for
the license fields on all forms where they appear.

Change-Id: I4c3f1a38d81ae54081e555b2296d28955329cf77
Signed-off-by: Jiri Baum <jiri@catalyst-au.net>

Log events, including both user IDs when masquerading is in progress. The log
can be configured to log all events or only those while masquerading is in
progress or none. The log is expired after a configurable delay.

Note that this logs all events (or all masquerading events) even though this
feature only includes one report of one type of event.

Change-Id: I7a59d98b84b0527a55363b4d01448b9b1809aa9e
Signed-off-by: Jiri Baum <jiri@catalyst-au.net>

Was broken by commit 544c62b7 for
(Bug #941551)

Change-Id: I5ef546564677927e96541791ca3bbee1869e544b

split() will be replaced by explode() if using a string as a delimiter
and by preg_split() if using regular expression

Change-Id: I93a84150197fb290f89a04f10d5f0fd1e380f0da
Signed-off-by: Son Nguyen <son.nguyen@catalyst.net.nz>

Also add a few theme changes that allow some more
features on small devices.
- Printing links
- Settings link in top right corner
- Create/copy page/collection link
- Edit/delete buttons
- Remove group members button
- Help icons
- Administration link

Also made the admin link show in full

The items that are disabled when device detection is on
and user is on a mobile device are:
- TinyMCE editor
- Adding new blocks to pages, this is now a non-js version
- Dropdown menu's
- Export functionality

Bug #1052060

Change-Id: I5a8fe3cf136bb0c3e76e50a2b3bc48179c675b6a
Signed-off-by: Hugh Davenport <hugh@catalyst.net.nz>

as it doesn't work for some devices

Change-Id: I34a72348b7d9c23a5840754a41022e806349c543
Signed-off-by: Liuba Kazakov <liuba@catalyst-au.net>

Change-Id: I10ac8fc0c53a66eabb2a7f558f4111f3a2d5e61a
Signed-off-by: Christopher Tombleson <christopher@catalyst.net.nz>

Replace institution name with institution display name.

Change-Id: Id1c358802b22665b300601062056c72f39a71723
Signed-off-by: Christopher Tombleson <christopher@catalyst.net.nz>

Change-Id: Ibf300f85cbcea12f6ac6ddb89a1eb5f6ea47216b
Signed-off-by: Hugh Davenport <hugh@catalyst.net.nz>

Change-Id: Ifdc7dbaf2ec7c3ebaa40cb557e0a093423c5c71d
Signed-off-by: Hugh Davenport <hugh@catalyst.net.nz>

Change-Id: Ie0d96d6caa5b6aff66bdb49e14940ab349046147
Signed-off-by: Hugh Davenport <hugh@catalyst.net.nz>

Copied from the mahara.org registration table. It stores each registration field
in a local database with a timestamp of when the data was obtained.

This storage is done whether or not the data is actually sent to mahara.org.

Change-Id: Ib8478b0caa97c5cc5f04a7d5b44f2a9ac11f9ce8
Signed-off-by: Hugh Davenport <hugh@catalyst.net.nz>

This patch removes some inapproprate uses of the |= and &= operators
on boolean values.  On view/edit.php, &= was also used on the integer
return value from strlen as if it were a boolean, resulting in the
clean url field being uneditable in some instances where it should
have been editable (see bug #1006634).

Change-Id: I96a72c407309ed82a45d3130cffa06418be05fe7
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

Bug #1006634, part 3

This is more efficient on many pages, because the user object has
already been fetched, or is about to be fetched, to run display_name
or profile_icon_url.

However, user object returned by get_user_for_display won't allow
can_view_view to tell whether a user is suspended or not, so
suspendedctime is added to this object (it's less identifying than
suspendedcusr).

Change-Id: Ic9d1e5d437aedbc45f6328a05997812dcf45c8d6
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

Bug #1006634, part 3

In order to get the url information for the list of views returned by
get_views(), that function is modified to gather the views in a single
flat list rather than in a structure indexed by user id.  Just before
the view list is returned, the url information is fetched and the user
array is built.

Change-Id: I12dad07c90f8c51614e72c7402c63dc38fccceeb
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

Bug #1006634, part 3

Only affects views that the owner has tagged 'profile'.

Change-Id: Id4a6b641ab46e6cf105d9dbf295fb16f8d343987
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

Avoids double queries on view/view.php and view/artefact.php, where a
View object is constructed from an id inside can_view_view, and again
on the page.

Change-Id: I0f034f04765f73d64758b6ff7ec11c5cbdcdb6f7
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

Bug #1006634, part 3

Views and artefacts are pulled from the db together in a UNION query.
We can't simply pass the whole list of records through to a View
method - it's easier to generate the urls one by one in
build_portfolio_search_html.

Change-Id: I59b1ab91e141611d4a41e60b28a0bfdf13167749
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

Bug #1006634, part 3

In many places user urlids are not currently available when the
profile url is generated, but it is trivial to get it, and then change
the user/view.php url to a profile_url call:

- Admin page access report
- Profile links in feedback lists
- My friends block
- Wall posts
- Group members block
- Group members tab
- Recent forum posts block
- Group admin lists on forums page
- Group admin lists on my groups, find groups
- Group admin lists in group info block
- Profile sideblock
- My friends & find friends pages
- Institution landing page
- Online users page

Change-Id: I33e122896982037a887aad8e3362db450e123e3f
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

When generating new clean urls, transliteration of utf8 characters
works better when the locale is set appropriately, so it will be
useful to be able to change locales without having to change the
current language.

Change-Id: Ife9e65661dc582cb830a20c73cecd6942d28d62c
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

If the MySQL user doesn't have trigger permission, an SQLException was
thrown along with an unhelpful generic error message.  This privilege
is now checked before beginning the install/upgrade, and the message
is now informative.

Change-Id: If35750610cdc84e97bf8f2974d496dea43b8b991
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

PHP 5.4 doesnt like creating objects on the fly.

Change-Id: Ia2ba74bcf454d58e7b526fa0c1aff64f2ad71f59
Signed-off-by: Christopher Tombleson <christopher@catalyst.net.nz>

This comes from:

  http://nz.php.net/manual/en/function.strftime.php#example-665



Bug #795494

Change-Id: Ie958f1ac6cfcb89dfa34f552c7eeec16be4578d7
Signed-off-by: Francois Marier <francois@catalyst.net.nz>

Change-Id: Ib9a72a9e36bb24da5907720242b23e991bb7bf9a
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

When sitemap generation is disabled, we don't need to include all the
relevant libraries and log the message about disabled sitemap
generation.

Change-Id: I1f7e92f58dcb455bbfaab7745ce28e496ee7276b
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

Commit 011c5039 changed lot of thumb.php urls to use the
type=profileiconbyid parameter (which takes an artefact id) rather
than type=profileicon (which takes a user id, and which cannot be
cached).

Unfortunately, when a user has no locally stored profile icon, use of
type=profileiconbyid stops their remote gravatar image from being
displayed.

This commit updates the thumb.php urls that were changed in commit
011c5039 to use the profile_icon_url() function, which respects
remote avatars when no local profileicon is available.

In some cases this requires a new size of the no_userphoto.png image,
so three new sizes are added in the raw theme.  The four no_userphoto
images in the custom theme were duplicates of those in raw, and are
removed.

Finally, the type=profileiconbyid change from commit 011c5039

 in the
viewacl.tpl template has been reverted back to type=profileicon.
Because this url is constructed in javascript, it is not worth the
trouble to use a profile_icon_url call here until the number of
requests to thumb.php really becomes a problem.

Change-Id: I7dce7090842999fe090dc2d8c481cb4aca7720d5
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

This can help to reduce the overall number of requests for thumb.php
because the 'profileiconbyid' urls are cached for longer by the
browser.

(Where the profile_icon_url function can be used, we also avoid the
need to generate additional requests for users without profileicons,
when remote avatars are disabled.  But because profile_icon_url relies
on the nouserphoto icon being available in the requested size, we
can't use it everywhere until we either generate the nouserphoto icon
in more sizes, or change all those pages to use standard sizes.)

Change-Id: I81c5c5f4b7f9136bf9b6a6f711e55a4bceb6fa14
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

This commit changes a couple of places where it's possible to check
for installed plugins using plugins_installed() instead of a new db
query.

Change-Id: I3e769a0858d8db776bf7d8e14102c49b5b9f7b07
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

Trying to set this option fails when an open_basedir restriction is in
effect.  This patch also checks open_basedir and adds a warning to the
admin area, and in the sanity check for an unwritable dataroot, the
open_basedir directories are listed on the screen as a hint for
installation.

Change-Id: Ic394517f436955b038f321b06011b818d4967026
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

Change-Id: I2924716222817fc60e2358354866c591900fd03d
Signed-off-by: Iñaki Arenaza <iarenaza@mondragon.edu>

Allows language packs to specify an array of strings (one for each
plural form in the language) instead of a single string.

The first of the variable (sprintf) arguments is assumed to be the
number we need to check to choose a plural form.  This argument is
passed into a language-specific function defined in langconfig.php,
which returns the appropriate plural form based on a formula.

A similar scheme is used for strings formatted by the javascript
get_string function in mahara.js.

See http://www.gnu.org/s/hello/manual/gettext/Plural-forms.html



Change-Id: Ifb58ac4f1e13a54edbc57e5c0a9faaf8454e53a4
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

Change-Id: Ia16d7f3e59409838685d5ebee813f83e1f62468f
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

There are several places in the code where we make directories
for stuff, both in the filesystem and in the artefacts table.
If they have trailing spaces, then this can mess up users html
exports etc. This patch should make exports safe for existing
folders with whitespace at the end, and prevent new folders from
from being made with the problem.

Change-Id: Ia593f7f773e5ffe91ce74e8a736074b1fe1026b2
Signed-off-by: Melissa Draper <melissa@catalyst.net.nz>

This has been unnecessary for some time now, because the same count
appears next to the envelope in the top right of the header.

Change-Id: I14581f8edff19ee5111eba4ff4ec8f564ad2443a
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

Change-Id: I35d399d828d99dc3159928d7f19ba15b4a702916
Signed-off-by: Hugh Davenport <hugh@catalyst.net.nz>

This will standardize the way that Mahara sanitizes these personal
details.

PHPMailer is no longer necessary since in PHP 5.2, it's just a
call to filter_var().

Change-Id: I151fe4f91c9731cfa24b5a6e9d0cebeabfcd1a77
Signed-off-by: Francois Marier <francois@catalyst.net.nz>

When a plugin config value has not been set, multiple calls to
get_config_plugin always trigger a db query.  But if it's already
queried once and found a null result, it should remember that for
next time.

Change-Id: Id955e0953131b83eba4e36face26bfb4ef828d26
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>