- 01 Aug, 2012 1 commit
-
-
Hugh Davenport authored
Site staff can always view, institution staff can view if staffstats config option is set Change-Id: Ia7dcd8623ef6d6eaba77a3370a1d9fb637163c29 Signed-off-by:
Hugh Davenport <hugh@catalyst.net.nz>
-
- 04 Jul, 2012 1 commit
-
-
Son Nguyen authored
(Bug #886080) Copying a site or institution collection which has several pages to new user's porfolio or to new group's portfolio Change-Id: I635224386b5a5c5230617e0d09fe0f1da45d6b2b Signed-off-by:
Son Nguyen <son.nguyen@catalyst.net.nz>
-
- 03 Jul, 2012 3 commits
-
-
Son Nguyen authored
Change-Id: Icc209c647602375a83804bae0538a5297b5caed7 Signed-off-by:
Son Nguyen <son.nguyen@catalyst.net.nz>
-
Son Nguyen authored
- Add function copy_site_views_collections_to_new_user() to copy site views and collections to the new user Change-Id: If893af92cc86b7f3225e84558f8a71048ec129f0 Signed-off-by:
Son Nguyen <son.nguyen@catalyst.net.nz>
-
Son Nguyen authored
1. For group collections Only roles that can edit group pages can do these: - Listing group collections - Creating a new group collection - Deleting and editing an selected group collection. - Copying a collection 2. For institution collections Only institution admins can: - Listing insitution collections - Creating a new institution collection - Deleting and editing an selected institution collection. - Copying a collection Change-Id: I799bcfaf0f751d1a8c1fa9b5e5df4832832d8ea1 Signed-off-by:
Son Nguyen <son.nguyen@catalyst.net.nz>
-
- 01 Jun, 2012 1 commit
-
-
Richard Mansfield authored
Bug #1006634, part 1 Whenever a new user, group, or portfolio page is created and clean urls are enabled, ensure the urlid field is set to something vaguely sensible. Ensure new user and group urlids are unique, and ensure new view urlids are unique for the owner. Change-Id: I2033f5aa1f32650b4fc72666c54c371d05df133c Signed-off-by:
Richard Mansfield <richard.mansfield@catalyst.net.nz>
-
- 31 May, 2012 2 commits
-
-
Richard Mansfield authored
Part of bug #793308 If a user has the 'theme' property set in their account preferences, this is used instead of the site or institution's theme. The LiveUser::reset_institutions() function, which recalculates the institution theme, is now called in place of LiveUser::update_theme() whenever a user's institutions have changed. reset_institutions() now calls update_theme() if the user is a LiveUser. Change-Id: I75b36da85a5aa249c3098078b8588b8a20ac9b48 Signed-off-by:
Richard Mansfield <richard.mansfield@catalyst.net.nz>
-
Richard Mansfield authored
The Theme constructor expects a triple (basename, logo, stylesheet), which is passed by the User::get_themedata function. But the three properties are stored separately in the User object. If they are grouped together, then it will be easier to switch themes in and out at a later date. The three properties are combined under the 'institutiontheme' name, to make it clear that they are defined by the user's institutions, and to distinguish them from the user's own theme preference. This requires a slight change to code for setting a view theme on view creation, where only the basename property is allowed, because custom themes with logos & stylesheets are not yet available as view themes. Change-Id: Ie400a0f1c4a2172382dfaba14139f1b0b27f2120 Signed-off-by:
Richard Mansfield <richard.mansfield@catalyst.net.nz>
-
- 18 May, 2012 1 commit
-
-
Richard Mansfield authored
$USER->set_account_preferences() always saves preferences to the usr_account_preference table as well as to $USER. Adding a test for the user's id means that this function can be safely called on a logged-out user. Change-Id: Ieab78c5fbf30647dbb5dce10e960afb260c8dd1f Signed-off-by:
Richard Mansfield <richard.mansfield@catalyst.net.nz>
-
- 13 Feb, 2012 1 commit
-
-
Richard Mansfield authored
Also keeps the count in the $USER object up to date whenever the user deletes or reads a notification. When new notifications are generated for a live user by another user, or on cron, the logged-in user's unread count is reloaded from the database into the session either on hitting the inbox, or whenever $USER is committed for some other reason. The code to reload the background fields on commit of the LiveUser object has been changed to ensure that it still works at upgrade time, where the 'reload' column doesn't exist in the user table yet, but *does* exist in the User object. Change-Id: I9c9a81bf77d0927352902dee0d989d6122757b47 Signed-off-by:
Richard Mansfield <richard.mansfield@catalyst.net.nz>
-
- 06 Feb, 2012 1 commit
-
-
Richard Mansfield authored
Commit 725ba929 tries to reload certain admin-settable fields from the database into a LiveUser when committing, but fails to convert the suspended date to a timestamp when doing so. This causes the date to be displayed incorrectly to suspended users when they log in. The same problem was fixed for expiry dates in commit f7dcdf81 , bug Change-Id: I3ce83f53183cbd9003226466149f54e878749d1e Signed-off-by:
Richard Mansfield <richard.mansfield@catalyst.net.nz>
-
- 10 Jan, 2012 2 commits
-
-
Richard Mansfield authored
Users who are about to expire due to inactivity can reactivate themselves by logging in and thereby updating the lastlogin time. However, the inactivemailsent flag is never reset, so users who reactivate themselves in this way could never receive another inactivity warning email in future. Change-Id: Iffffd008dc10a6c62987dd38d2e7f18344c8b597 Signed-off-by:
Richard Mansfield <richard.mansfield@catalyst.net.nz>
-
Richard Mansfield authored
Commit 725ba929 tries to reload certain admin-settable fields from the database into a LiveUser when committing, but fails to convert the expiry date to a timestamp when doing so. This causes logins to fail for users who have an expiry date set in the future. Change-Id: I53e962a0f5bab56ab130e1945b251f70447e9411 Signed-off-by:
Richard Mansfield <richard.mansfield@catalyst.net.nz>
-
- 16 Dec, 2011 1 commit
-
-
Francois Marier authored
This allows third-party authentication plugins to use the same code when performing this check. Change-Id: I3b7d5f6a7cd4064617baa5e9b4563563d16e161b Signed-off-by:
Francois Marier <francois@catalyst.net.nz>
-
- 31 Oct, 2011 1 commit
-
-
Andrew Robert Nicols authored
Change-Id: I49e29567840682838a2b759c806023106dcdc9ce Signed-off-by:
Andrew Robert Nicols <andrew.nicols@luns.net.uk>
-
- 27 Oct, 2011 1 commit
-
-
Melissa Draper authored
To deter brute-forcing of passwords (and prevent ensuing DoS attacks), this patch temporarily lock accounts after 5 tries, and every 5 minutes counts above 0 get reset. Change-Id: Iee9739a69b95b906b6f485f7d90041b50968dcc6 Signed-off-by:
Melissa Draper <melissa@catalyst.net.nz>
-
- 06 Oct, 2011 1 commit
-
-
Richard Mansfield authored
When deciding who can moderate comments on a group view, the 'moderating' roles are stored in the view object, but they don't need to be, because they only depend on the group settings. So we can remove moderating roles from the View object, and get them directly using the group id when required. Change-Id: I69f5cd467e474a1fd9c0c589322c6a3935aa3482 Signed-off-by:
Richard Mansfield <richard.mansfield@catalyst.net.nz>
-
- 04 Oct, 2011 2 commits
-
-
Richard Mansfield authored
The can_publish_artefact method on the User class, introduced in commit aba54873 (see bug #655631) is out of line with other permissions on the site when it comes to institution artefacts. Any institution member can include institution files on one of their own pages, but this method (currently used when putting images into forum posts) only allows publishing by institutional admins. This change adds publishing permission on institution artefacts for all institution members. Change-Id: I3f8a15de573de6f58497ae45839647b462fa5e89 Signed-off-by:
Richard Mansfield <richard.mansfield@catalyst.net.nz>
-
Richard Mansfield authored
The role permissions on group artefacts are stored in the artefact object, so we might as well make use of that in the can_edit_artefact and can_publish_artefact methods of the User class instead of forcing a new query. Change-Id: I7e5e5ff8e14fc55638a613a9253eb0c35fd60867 Signed-off-by:
Richard Mansfield <richard.mansfield@catalyst.net.nz>
-
- 28 Sep, 2011 1 commit
-
-
Richard Mansfield authored
There is currently only a site-wide setting for logged-in profile view access. This means that when two institutions share a site, and one wants open profiles and another only wants institution-visible profiles, new users in the open-profile institution must be asked to manually add logged-in access on their profile. Because we expect many more open-profile institutions than closed-profile institutions on a site, it makes more sense to put the onus on the closed-profile institutions to ensure their members remove logged-in access manually. This change ensures logged-in access is added to all new profiles, but only locks that access when the loggedinprofileviewaccess setting is on. Change-Id: I3375d7b2f8eb635a11879bf7758267f48f74c508 Signed-off-by:
Richard Mansfield <richard.mansfield@catalyst.net.nz>
-
- 12 Sep, 2011 1 commit
-
-
Richard Mansfield authored
Admins can set the 'locked' property on a group view, and this will stop non-admin members from editing the view, regardless of the view editing permissions given to roles within the group. Change-Id: I56c113a9d4e8fcab5463fa1c54bf456f7fc2364b Signed-off-by:
Richard Mansfield <richard.mansfield@catalyst.net.nz>
-
- 07 Sep, 2011 1 commit
-
-
Eugene Venter authored
Bug #826453 Change-Id: I1e6c102b67ad0342a1d91494e84f74617722db93 Signed-off-by:
Eugene Venter <eugene@catalyst.net.nz>
-
- 02 Sep, 2011 1 commit
-
-
Richard Mansfield authored
Change-Id: I5716ab99dc58b6d0c319d51eed9ee6796b68aa67 Signed-off-by:
Richard Mansfield <richard.mansfield@catalyst.net.nz>
-
- 01 Sep, 2011 1 commit
-
-
Richard Mansfield authored
The roles which have edit permissions on group views is set for each grouptype. This changes the setting to be per-group. Partially addresses bug #547362, bug #631189 Change-Id: I3f51f0ed44b7f479a094a2c5b2e2ee4807722e34 Signed-off-by:
Richard Mansfield <richard.mansfield@catalyst.net.nz>
-
- 25 Aug, 2011 1 commit
-
-
Francois Marier authored
This array structure was too deep and caused invalid records to get added to the DB on MySQL (since it doesn't have CHECK constraints) and errors on Postgres. Bug introduced in e283a68a while implementing the features described in bug #807278. Change-Id: I65aa9b6de736294320e6d2bce2ea549a67ba2577 Signed-off-by:
Francois Marier <francois@catalyst.net.nz>
-
- 24 Aug, 2011 2 commits
-
-
Francois Marier authored
Part of bug #807278 Add new site setting to force logged-in access to profile pages Change-Id: I7e1634cba16759923e3aa4c64d129d1f5280665f Signed-off-by:
Eugene Venter <eugene@catalyst.net.nz>
-
Francois Marier authored
Part of bug #807278 Change-Id: I3c01e88577262dd610f5df74f79f5150e3978dd9 Signed-off-by:
Eugene Venter <eugene@catalyst.net.nz>
-
- 19 Aug, 2011 1 commit
-
-
Hugh Davenport authored
If a file is in the groups area that doesn't have member access then the group member that initially uploaded it can't view it This patch allows the author (uploader) of a file to still have access no matter what the access is set to for the group role they belong to Bug #812673 Change-Id: I1d5bbccb41d34af15617ac5abc673b1265ac9f3e Signed-off-by:
Hugh Davenport <hugh@catalyst.net.nz>
-
- 16 Aug, 2011 1 commit
-
-
Richard Mansfield authored
The $USER object is saved to the usr table in the db whenever it changes, and also periodically when the lastaccess property is updated. However, for some fields, it's not appropriate to overwrite the db value with the $USER property, because these fields are generally only modifiable by an admin (e.g. quota, suspended) or the system (e.g. active). Previously we have tried to deal with this by removing the sessions of users whose properties are modified by an admin. This is okay when suspending or deleting a user, because the user should be forced to log out anyway. But for other properties like the user file quota, it shouldn't be necessary to force the user to log out because the value was modified by an admin. It makes more sense to specify a list of fields (including quota) that should be reloaded into $USER on every commit. Change-Id: Id0268a29be976a506b09d81aeb6a5b80a26e72fa Signed-off-by:
Richard Mansfield <richard.mansfield@catalyst.net.nz>
-
- 03 Aug, 2011 1 commit
-
-
Richard Mansfield authored
An institutional admin modifying configurable theme colours doesn't immediately see the new colours unless they are also changing the theme dropdown. This change ensures the user's theme is reset whenever the institution settings form is submitted with a custom theme. Change-Id: I3e39cf2de182fc6fa1cba10f4063412025f363ef Signed-off-by:
Richard Mansfield <richard.mansfield@catalyst.net.nz>
-
- 27 Jul, 2011 1 commit
-
-
Richard Mansfield authored
Change-Id: I44fed8135d7f3148920ac608cb9986afa5681a4c Signed-off-by:
Richard Mansfield <richard.mansfield@catalyst.net.nz>
-
- 12 Jul, 2011 2 commits
-
-
Edward Murrell authored
This change was added to limit deleting of comments in standard groups views to admins only, and admins and tutors in course groups. This commit adds the functions User::can_moderate_view() and GroupType::get_view_moderating_roles() to implement this functionality. Change-Id: Ifb8f4fc55d31fd7c5928c73c3d81710934bfdad8 Signed-off-by:
Edward Murrell <edwardm@catalyst.net.nz>
-
Eugene Venter authored
Bug #809105 Change-Id: If2a2826f1386253fb9e88a6d76fb3616f8a1a21f Signed-off-by:
Eugene Venter <eugene@catalyst.net.nz>
-
- 05 Jul, 2011 1 commit
-
-
Richard Mansfield authored
Bug #805780 When a user's institutions are loaded, fetch the institution logos. When choosing which of the user's institutions determines their theme, ensure the same institution determines the replacement logo. Finally, if the page theme to be displayed is determined by the user, use the user's header logo in the header template. Change-Id: I710d6ff727d90276fc5008b179c60700f4499ccc Signed-off-by:
Richard Mansfield <richard.mansfield@catalyst.net.nz>
-
- 28 Jun, 2011 1 commit
-
-
Richard Mansfield authored
This page takes a list of user ids, filters it using the admin's institutions (if institutional admin), and displays the list. The admin can then either download the list as a CSV file, or suspend, delete or change the auth instance of all the users in the list at once. Change-Id: I792fa29403a0b5f818dceff1d9aab9e9cbd42661 Signed-off-by:
Richard Mansfield <richard.mansfield@catalyst.net.nz>
-
- 23 Jun, 2011 1 commit
-
-
Richard Mansfield authored
Create new functions to add members, invite members, and decline membership requests for an institution. These functions check appropriate institutional admin permissions and are callable by the webservice api. Also modifies the existing bulk insitution membership page to make use of the new functions. Change-Id: I52aced5bf398835c8590bb2bab8a7028335af01b Signed-off-by:
Richard Mansfield <richard.mansfield@catalyst.net.nz>
-
- 22 Jun, 2011 1 commit
-
-
Richard Mansfield authored
Logged-in user language preferences were broken in commit 9ca6bb55 . This change removes caching on the session and config languages, which are quick to retrieve anyway, but leaves it in place for the user language preference and locale setting. Change-Id: Ib601f2227409bbbc63d269fe079915cc0e902fc2 Signed-off-by:
Richard Mansfield <richard.mansfield@catalyst.net.nz>
-
- 16 Jun, 2011 1 commit
-
-
Darryl Hamilton authored
Bug #794385 - Implemented as a checkbox on the institution details page. This checkbox is disabled if the site wide setting is not set. Additional method on the User class that returns true if any of the institutions that the user belongs to allows public views. Change-Id: I0d58d1056efb0d84eb5ee092c4ee2db978853ce6 Signed-off-by:
Darryl Hamilton <darrylh@catalyst.net.nz>
-
- 13 May, 2011 1 commit
-
-
Francois Marier authored
These closing tags are unnecessary and against our coding guidelines. Let's get rid of them all in one go. Change-Id: Ia94f103e525185597ee3780a3839d7577cdd0c29 Signed-off-by:
Francois Marier <francois@catalyst.net.nz>
-
- 06 May, 2011 1 commit
-
-
Hugh Davenport authored
This happens on public site pages because the view owner is 0 by default, and the LiveUser object has id 0. Bug #778240 Change-Id: Idec3fe8f4a9a877eaf02bfb304f1809f6b556ab0 Signed-off-by:
Hugh Davenport <hugh@catalyst.net.nz>
-