1. 01 Oct, 2019 8 commits
  2. 30 Sep, 2019 1 commit
  3. 29 Sep, 2019 3 commits
  4. 26 Sep, 2019 3 commits
    • Evonne's avatar
      Bug 1843823: Plans block running into next plan when more than one · bf4e742f
      Evonne authored
      Inside a plan block when there are more than two plans, the second
      plan's heading overlaps the first plan. Fix puts in a clear both
      in the div.
      
      behatnotneeded
      
      Change-Id: Ic7bbda42df5d2f5edb4f6aec3ea764b884fc8e37
      bf4e742f
    • Evonne's avatar
      Bug 1843822: Default theme retractable block heading missing green border · a2e58383
      Evonne authored
      Removed gray border override for retractable blocks so theme's
      border colour can show instead.
      
      behatnotneeded
      
      Change-Id: Idee562cb6fc248d963801b2dd615f2e3827a630f
      a2e58383
    • Evonne's avatar
      Bug 1827811: Journal and resume details buttons overlap · f5ca6b3a
      Evonne authored
      Fixes for journal titles and resume attachments for employment
      overlapped by details button.
      
      behatnotneeded
      
      - clean up unneccessary include in export/html/lib.php
      - fix html export for the creation of nested folder modals
       make sure the nested folders and find all nested modals
      - fix elseif typo in block-comments-details-header.tpl
      - add details bar to image gallery when displayed from folders
      - fix notes block empty modal issue due to .tpl typo
      - fix image gallery slideshow error where second gallery block
      always targets the first
      - keep the active block headers showing after pagination update
      
      Change-Id: Icf8d59ad558d74883e3ee2070f55768697af4254
      f5ca6b3a
  5. 25 Sep, 2019 13 commits
    • Robert Lyon's avatar
    • Lisa Seeto's avatar
      Bug 1827811: Resume Icons · 953a5eab
      Lisa Seeto authored
      - get attachment comment counts for bh icons
      - display plain text for titles in editing mode
      - change the way the commentlink is targetted via js
      - add blockid's to resume attachments
      - for folder block: add comment count, change titles from
      	links to plain text when editing
      - change notes attachment file titles from links to plain
      	text when editing
      - get rid of the single artefact block title links for html exports
      ---------------------------------------------------------
      Add fixes:
      - blocks that have set types but no artefacts attached don't have modal links
      - pdf block is now using block header and comment count is loaded
      - block headers are above titles
      - tagged journals have icons when in full and matches recent posts styling
      - deleting all comments produces correct icon on block header
      - html exports should not hang on opening modal
      - get rid of warning error re: dock.show() when redirecting from &modal=1 style url
      - code review fixes for all previous patches + fix issue with folders block
      - added in viewdetailsfilter.json.php file to save details mode to user account prefs table
      - make the details btn mode "sticky" so it stays the save value over multiple pages etc...
      - Image Gallery blocks: if displaying a folder of images will get the bar block header and
      will have a the fancy box image preview displaying on image click
      
      Change-Id: I425cc5a634e176d580aacdb60a20f869f7cb7496
      Signed-off-by: default avatarLisa Seeto <lisaseeto@catalyst.net.nz>
      953a5eab
    • Evonne's avatar
      Bug 1827811: UI Task theming · f8d9ec0a
      Evonne authored
      Fixing alignments and hover/active states for assessment buttons.
      
      behatnotneeded
      
      Change-Id: I8774ecc53d5d3744f1e4e0b6debf2e6476e71ce8
      f8d9ec0a
    • Lisa Seeto's avatar
      Bug 1827811: UI Task · fb47b831
      Lisa Seeto authored
      The change is for making sure the styling is working for the blocks.
      
      * make file(s) to download use bh icons, metadata on new line
      * resume attachments to use icons (buggy but apparently necessary)
      * show file(s) to download titles on hover over link
      * get rid of '-' for file metadata for size etc...
      * fix the editing/display descrepancy of tagged/recent posts titles
      
      Change-Id: Iad7bb30944f5924b43eca96993e3334120076c05
      Signed-off-by: default avatarLisa Seeto <lisaseeto@catalyst.net.nz>
      fb47b831
    • Lisa Seeto's avatar
      Bug 1827811: Embedded Media Task · b82df03d
      Lisa Seeto authored
      add the block-header to the block.
      remove the download link from page as it now shows in the modal.
      add artefactid and blockid to image.tpl
      fix issue with data-toggle collapse targeting syntax error.
      update  active block functionality for block headers
      update block-comments-details-header.tpl for icon headers
      fix Journals, and tagged entries and recent posts to use icons for block header.
      change pdf block to use block header icons
      clean up .comments-details class that is no longer needed.
      add modal functionality for image gallery blocks for thumbnails and thumbnails square presentation.
      add modal functionality for some html block, clear up js for icons that is no longer needed.
      add title text to icons and block-header
      create activateModalLinks() func to tidy up js modal click events in view/view.php
      
      Change-Id: Ib5967d44288557ef4d380eb99241e8442da90f29
      Signed-off-by: default avatarLisa Seeto <lisaseeto@catalyst.net.nz>
      b82df03d
    • Lisa Seeto's avatar
      Bug 1827811: Folder Task · 44fcc9c9
      Lisa Seeto authored
      This change adds modal functionality for folders and nested folders
      add javascript to the folder_render_self template.
      add new class to make space between icon and title/ metadata in modals
      fix blockid warning message error
      added folder_render_in_modal.tpl to fix duplicate js script issues interferring with js events
      creaeted toggleDetailsBtn() to handle js issues
      get rid of old style comments link from showing up.
      turn off click functions so json sendrequest doesn't call a billion times.
      explicitly call dock.show() in the open_modal func.
      
      Change-Id: I938f98c33479a80afc8f940038ed81a3c84ce4ff
      Signed-off-by: default avatarLisa Seeto <lisaseeto@catalyst.net.nz>
      44fcc9c9
    • Lisa Seeto's avatar
      Bug 1827811: Redirects · 79201b7d
      Lisa Seeto authored
      This change cleans up the last of the redirects to artefact/artefact.php
      Update the links for the journal and journal entries for elasticsearch to go to blog
      Update the links for the journal and journal entries in consideration of new reqs
      Update artefact/artefact with session msg + access denied error
      
      Change-Id: Ied34542632bd4e49a353ec17937d685614117643
      Signed-off-by: default avatarLisa Seeto <lisaseeto@catalyst.net.nz>
      79201b7d
    • Lisa Seeto's avatar
      Bug 1827811: Exports task · e6b6ecf9
      Lisa Seeto authored
      This change creates the modals for exported html pages.
      Modals are hard-coded onto page with id's of modal_[artefactid]
      Bootstrap and jquery files are copied into export js folder.
      Profile page is also exported with any modal content.
      Add tagged posts modals
      get rid of export warning when no $commentcount set in viewposts.tpl
      Add recent posts modals so that first journal post was also a modal
      Set Parent journal link text to plain text for exports
      Add entire resume modals and one resume field modals
      Add File(s) to download modals
      refactor export_artefact_metadata_modals
      add metadata but not comments to resume page
      add metata (license info) but not comments to journal pages
      add comment count default to 0 in .tpl's if comment count not present (during export)
      remove updating comments modals for profile page as this is no longer needed.
      
      Change-Id: Iff50138285951a4f9a1573423f4f74feba97886f
      Signed-off-by: default avatarLisa Seeto <lisaseeto@catalyst.net.nz>
      e6b6ecf9
    • Lisa Seeto's avatar
      Bug 1827811: Notes block · 1885a18d
      Lisa Seeto authored
      do not show note contents when displayed in a modal.
      if comments not allowed but license metadata is on, display details link and open model with license data.
      make small change to setting of licensemetadata smarty variable
      get rid of comments/details links and use the new block header instead.
      
      Change-Id: I9183292278d06a3766ae08b0376237fda8d7206c
      Signed-off-by: default avatarLisa Seeto <lisaseeto@catalyst.net.nz>
      1885a18d
    • Lisa Seeto's avatar
      Bug 1827811: Resume changes · 8df0061e
      Lisa Seeto authored
      added the modal_link for resume field attachments
      fixed the modal)link typo in employmenthistory template
      update commentlink to modal_link for goals and skills template
      
      Change-Id: I8b203628dc47d7019ee75165cb11bc392ddefa03
      Signed-off-by: default avatarLisa Seeto <lisaseeto@catalyst.net.nz>
      8df0061e
    • Lisa Seeto's avatar
      Bug 1827811: Plans block · ece65af4
      Lisa Seeto authored
      behatnotneeded
      
      The plan block's 'details' link will only display if license metadata is available.
      The link will open the modal with licensing information.
      Update how the licensemetadata is set in smarty variable.
      remove old details link and use new block header instead.
      remove the use of modal functionality, block headers & smarty vars
      
      Change-Id: I5f06d9ba84ff018a50ba774763be3fcede9b2576
      Signed-off-by: default avatarLisa Seeto <lisaseeto@catalyst.net.nz>
      ece65af4
    • Lisa Seeto's avatar
      Bug 1827811: Journal changes · f7431a3a
      Lisa Seeto authored
      Journal changes:
      Change the modal contents to not show post contents or attached files.
      Recent posts and Tagged posts (if not in full display) now expandable with post contents and comment links.
      Attached files on page block now links only to download and not to display further metadata.
      Cleaned up artefact.php links.
      remove metada that will show on entry on page from also showing in modal
      stop background page scrolling when the modal is opened and "Advanced licensing" is selected.
      add the blogpost_render_in_modal.tpl file
      get rid of scrolling for data-toggle collapse
      add block-header to journal, journal entry
      add titles as modal links for recent posts and tagged journal entries
      add comments and details icons for recent posts and tagged journal entries
      fix things from code review
      
      behatnotneeded
      
      Change-Id: Ic63ebf9fe42e7848559b5e009584fdff0a40770f
      Signed-off-by: default avatarLisa Seeto <lisaseeto@catalyst.net.nz>
      f7431a3a
    • Lisa Seeto's avatar
      Bug 1827811: Move "Add comment" and "Details" into modal with "Comments" · be7af61f
      Lisa Seeto authored
      create modal using configureblock id, update various templates to use the modal for blocks:
      Image
      Note
      File(s) to download
      Journal/blogs
      add JS to open/close modal, add comments, delete comments, reply to comments, paginate comments.
      add JS to handle url that redirects to view/view.php with modal open and populated.
      Further changes to each block will be completed in child patches.
      Add segment headings to the modal. Fix display of comments to cover width of modal.
      Show comment removed msg in modal/page appropriately.
      Fix behat test to close modal before continuing.
      do not show existing comments if comments not allowed on artefact.
      add validation to modal for comments/attachments
      disable image as link when editing for image block
      trigger focus on modal for accessibility
      close modal on escape keydown event
      fix merge conflict in view/view.php
      fix merge conflict with master
      make configureblock modal play nicely when comment block is on the page
      update display of error messages to always show at top of modal so user doesn't have to scroll
      add accesibility to close modal on escape key down
      handle dock show/hide events for paginated pages in modal during validation
      create block-comments-details-header template file
      create details button and custom scss file with js to show and hide header
      update comment links to save add comment and details when commentcount == 0
      add active-block class to colour the block-header when active
      toggle the details-btn active css
      add _block-comments-details-header.scss to patch
      change class invisble to class d-none
      add block-comments-details-header.tpl to blocktypecontainerviewing.tpl
      code review changes
      add .no-modal class to links on group home page, dashboard and profile page.
      add block header to appear above the title
      change assessbtn from anchor tag to button to prevent scrolling.
      make all clickable links clickable on page load (ignore assess mode)
      fix js issues surrounding assessbtn move and show/hide blocks
      change cursor on dashboard, my profile page, group homepage to default when over disabled modal links
      update assessbtn to details btn
      create tooltip for hover over file download block titles
      fix containerElm console log error by not reattaching tinymce unneccessarily.
      fix null named attributes issues on e.target when span (icons) instead of anchor is clicked.
      
      Change-Id: I2e5218c040f8a9e252f785165ce9c566ecc2f56e
      Signed-off-by: default avatarLisa Seeto <lisaseeto@catalyst.net.nz>
      be7af61f
  6. 23 Sep, 2019 2 commits
  7. 20 Sep, 2019 6 commits
  8. 19 Sep, 2019 4 commits