GitLab

Should be $this rather than $view as we are within a view object

Change-Id: I3132d6d380a82c3cd4cbc6fc35a4ab5fb19af673
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded

Change-Id: I447f295f1542779c5ced916961b3e607827b7635

Bug 1580499. Updating comments feature to adapt to the new
behavior, and removing redundant "feedback_configuration" feature
file.

Change-Id: Ib48cbb19f6ab9cc4937f31cef504724569680e1f

Also needed the js-masonry to be re-done on json results

behatnotneeded

Change-Id: I3f101d2a141227f74320cf66a2e03123cac5c254
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded: Tested will be added in another patch.

Change-Id: Ibb68614d6704df0e13d4a8e0c9e321e7afc39689

Liam Sharpe authored Jun 03, 2016 and Robert Lyon committed Jun 09, 2016

When a wrong password was entered on the login scrren, the password label
could not be read because it was white on white in the "Modern" theme.

Is a generic issue with Modern theme forms

behatnotneeded

Change-Id: I37c29633b247b60c08760f7c90dc8937f629dd81

Whether they are a group / institution blog or not

bahatnotneeded

Change-Id: I34b73e57db58108ef149019a5419c9ee5ca69e9f
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Regression from Bug 1397110

Change-Id: I6f98131dd61e06d0bc9d268bbe3eee1c4d4fbcb0
behatnotneeded: covered by existing tests

1. Add some documentation to session.php explaining what
the session.gc_maxlifetime ini setting does.

2. If we can't access $CFG->session_timeout, use a timeout of
an hour instead of the PHP default of 24 minutes.

3. Limit $CFG->session_timeout to 30 days, because we're already
enforcing that limit in session.php

4. Add "usr_session.mtime" column so that we can delete old sessions
based on inactivity instead of creation date.

5. Make the cron delete old session files as soon as they've expired,
rather than padding that an additional two days.

Change-Id: I9da2b26217774566b1131e997724359715edb2fe
behatnotneeded: Covered by existing tests

The session init code relies on $CFG->session_timeout, which is
normally defined in the config table. So, we need to start the
session after opening the database connection.

(In the event that there's an earlier session start, for instance
due to an error message, this will cause the session for that
page load to disregard any database config values. But that's not
a show-stopper, and there's no easy way to fix it.)

Change-Id: Iffbeebc8e92929970a558ff0fbc726719bb92741
behatnotneeded: Covered by existing tests

Dmitrii Metelkin authored Jun 03, 2016 and Robert Lyon committed Jun 08, 2016

Added a behat test - Robert

Change-Id: I67dd8f5e144d2bfbee2f71c5c3d7c9ac640fa206

Piers Harding authored Mar 18, 2016 and Robert Lyon committed Jun 08, 2016

behatnotneeded

Change-Id: I4fa9481ae0de06ef0255b6d523474fbd17c643b3

behatnotneeded

Change-Id: I52cdd0199a30b0eaa6c067f079bb043ff92ce885

Pat Kira authored May 20, 2016 and Kristina Hoeppner committed Jun 07, 2016

Fixed header overlapping navigation on ipad (portrait mode)

behatnotneeded

Change-Id: I90c80fe00193d45274ee11bba4cb6bdab7307c79

H Klocker authored Jun 03, 2016 and Robert Lyon committed Jun 03, 2016

Changing deprecated join() and ereg() eregi() functions to their more
robust equivalents

behatnotneeded

Change-Id: I76e928a945a0f4b0a2b7b2a3096200c2f8df9db9
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

An oversite when Bug 1397110 was tested

behatnotneeded

Change-Id: I1772d27bb1ec099a26149551f82cf6ea365bb780
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Kristina Hoeppner authored May 21, 2016 and Robert Lyon committed Jun 03, 2016

Make the two sentences easier to read without the
parentheses.

behatnotneeded

Change-Id: Iec2b270c824f63467fbd1e5aec7d58f8639c411e

Evan Giles authored Jun 01, 2016 and Robert Lyon committed Jun 02, 2016

When a user chooses the 'name_display_format' of studentid
- we get an error.

This change just populates the studentid field of the user

behatnotneeded

Change-Id: I1e6a84723863e49dd94b83cb115f26262e6d9750

behatnotneeded - style change

Change-Id: I2df8e2af06c7cae1ba23f7839660aefcaa762e39
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Pat Kira authored May 27, 2016 and Robert Lyon committed May 27, 2016

behatnotneeded

Change-Id: I2f5e00d3486211c4ab79a52c7cd2a639cc8431eb

behatnotneeded

Change-Id: Ib88fe6be5140e2237b4fe14935317125e5d705e6

Kristina Hoeppner authored May 21, 2016 and Robert Lyon committed May 26, 2016

in various places around Mahara to be more consistent
with what people see on the interface.

Change-Id: I83e088d39964ecd1d72945973fd0b4995b82da65