Robert Lyon authored Sep 26, 2018 and Cecilia Vela Gurovic committed Sep 28, 2018

When sending watchlist notification for block changes in a view

behatnotneeded

Change-Id: Ieeb89c6662acabd8438486702e10433ea6feab70
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 0866ac93)
(cherry picked from commit d67773e5)

And also with calling $USER->logout();

And also with showing missing ldap server info for a user

behatnotneeded

Change-Id: I03656d286bbf2e56416151a52b2051235f9364df
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 254103d6)
(cherry picked from commit f2da0c00)

Robert Lyon authored Jun 01, 2018 and Cecilia Vela Gurovic committed Aug 30, 2018

Instead of the MaharaException when doing user delete via webservices

behatnotneeded

Change-Id: I71db2ab3a3552918992a66310cdc3244f8d7c3a1
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 7c8f5f5b)

To allow for using newer PHPUnit version that uses Namespaced clases

behatnotneeded

Change-Id: I9e33c2542dda76691b32df78335ce511b06174c7
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded

Change-Id: I1f54b6d7649c1ff60661ba65cf0e1ac0d7c26af3
(cherry picked from commit a4c63b44)
(cherry picked from commit 79e3d736)

Signed-off-by: Cecilia Vela Gurovic <ceciliavg@catalyst.net.nz>

Signed-off-by: Cecilia Vela Gurovic <ceciliavg@catalyst.net.nz>

The fix in Bug 1774309 fails to work correctly when the site
is in a subdirectory of the apache root.

To test:
1) Adjust your site's apache file and set the DocumentRoot to be
parent of htdocs
2) Change the 'wwwroot' db value for site to include the 'htdocs/' bit
3) Restart the apache server
4) Go to site, adding 'htdocs/' to url
5) Try logging in

before patch: end up not found page with url containing two 'htdocs/'

after patch: end up at correct place

behatnotneeded

Change-Id: Ic5e1de2c5edaf96bbdd9b2403f0f65e45a4b80c0
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit d9ce7d92)

Robert Lyon authored Apr 27, 2018 and Cecilia Vela Gurovic committed Jun 05, 2018

behatnotneeded

Change-Id: I0eef9a361cda68ca6274d64308354dc239cc46bc
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit c185b03d)
(cherry picked from commit 7d37d9b2)
(cherry picked from commit 0f7d3e3a)

Ghada El-Zoghbi authored May 29, 2018 and Robert Lyon committed Jun 01, 2018

Pass error number and message correctly to the
MaharaException call when coming back from the
externalfeed curl call.

Sponsored by Central Queensland University

behatnotneeded

Change-Id: I03a2b666bde3905d2466ffbe35f1b35ca8a088bf
(cherry picked from commit 23287554)

If trying to access a page requiring login the system remembers the
path (QUERY_STRING) you were trying to access when login is successful

But if you login from the homepage there can be no QUERY_STRING set

Noticed when doing behat tests

behatnotneeded

Change-Id: I38cf1f6df7432d70ced5fe5df84bd56b47f1f163
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 1c3d039b)

Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Change-Id: Ieb4ebab6ac57ff0ef4f4f89b409884e9d6bc3db7
(cherry picked from commit d5b47224)
(cherry picked from commit da19b403)

Robert Lyon authored May 13, 2018 and Cecilia Vela Gurovic committed May 30, 2018

If zipped up Leap2A files are uploaded containing files with viruses we need to
check them before finishing the importation.

Also we should check existing zipped files for viruses as well, eg:

1) Upload a zip file with virus
2) Turn on clamav
3) Try extracting the zip file

behatnotneeded

Change-Id: I7635deb5f69e6fdb60e89d11ddf9362bb7928994
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 814cbaea)
(cherry picked from commit af8f5000)
(cherry picked from commit 5c378d47)

Robert Lyon authored May 21, 2018 and Cecilia Vela Gurovic committed May 30, 2018

By using redirect to avoid exposing sensitive data after login /
password reset

behatnotneeded

Change-Id: I4d64c7c51bb1af81dac594de0563be243a990ed6
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 520d915d)

a few changes copied from patch https://reviews.mahara.org/#/c/8607 
(whishlist for 18.10)

to fix 18.04

behatnotneeded

Change-Id: I8a6d64601005c708c11e719f94254c43e8fb2833
(cherry picked from commit e0093956)

makes it possible to select date sorting
for each artefact type

behatnotneeded

Change-Id: I7e74bdfbbe8b4df35028e1890833298e73516a45
(cherry picked from commit c51162a0)

Robert Lyon authored May 25, 2018 and Cecilia Vela Gurovic committed May 29, 2018

The baseurl for the pagination was not getting set correctly if 'all'
tags was joined with a special sort/filter.

behatnotneeded

Change-Id: Ic5ebcd4388b7808062a91ea463031e4c5ffa2083
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 9818f19c)
(cherry picked from commit e250e696)

Cecilia Vela Gurovic authored May 23, 2018 and Robert Lyon committed May 24, 2018

behatnotneeded

Change-Id: Idcd2689e6c196a6604e5f4706fb9019c4f0e3c88
(cherry picked from commit 00ed9a98)

Robert Lyon authored Apr 17, 2018 and Cecilia Vela Gurovic committed May 21, 2018

In Mahara we compare supplied usernames in lower case to what exists
in the database. This avoids problems of 'test01' vs 'Test01'.

The LTI plugin needs to also adhere to this convention

behatnotneeded

Change-Id: I822ccf9e3e3c3b43533c503f1600ef3c3af8008e
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 80c5e70a)

Kristina Hoeppner authored May 07, 2018 and Cecilia Vela Gurovic committed May 14, 2018

Mention that the subscribe / unsubscribe options are
only available when not subscribed to the forum.

behatnotneeded

Change-Id: I5c34aed233a75a9e26346df69a52137518e44218
(cherry picked from commit a6636e56)

When site public pages are turned off.

If the user is a member of a group that has 'public' access and the
site 'Allow public pages' are turned off, the user should be able to
view the group's home page - therefore allowing them to paginate
through the "Group portfolios" block in the group home page.

behatnotneeded

Change-Id: I1ea49927532f967c8a676b8a1590d1db3787cfc2
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 7d9d1b29)

Cecilia Vela Gurovic authored Apr 30, 2018 and Robert Lyon committed May 11, 2018

was making tablerenderer call updatecallback(
error

But the element that was updating was removed in 2009
 commit 2319c045

behatnotneeded

Change-Id: Icbc4718e01b9348f4e244e8d83620d527b9fbff2
(cherry picked from commit 790e51d1)

Rebecca Blundell authored May 07, 2018 and Robert Lyon committed May 10, 2018

I updated these to the latest, also changed the composer.json to >= on
the dependencies so it could update behat

Changed the mahara_behat.sh script to the other way of closing selenium
server from https://reviews.mahara.org/#/c/8006/1

behatnotneeded

Change-Id: I37cf7c13635970e37ce1e628ffeae96c5fe3f206

If the patches have template changes in them.

Commits for 17.04 missing raw_old changes
8e6c286b
ff109c21



behatnotneeded

Change-Id: Ie444da9d81b2ed80873c5addb47dd19cba4ccd9e
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Rebecca Blundell authored May 31, 2017 and Robert Lyon committed May 04, 2018

Added step to make the test pause until you press enter
in the console.

Also added a step to print a debug line to the console

behatnotneeded

Change-Id: I0066c0203d34f4fd021d8ac24105cf5e55a2cc07

Cecilia Vela Gurovic authored Apr 27, 2018 and Robert Lyon committed May 04, 2018

When changing the code to create a anonymous function
the parameter for the can_delete_wallpost function
was wrongly left as the name of a variable inside a string
instead of the actual variable

behatnotneeded

Change-Id: I53d6f2154cce910efa655d8d244b3c56d9f9b990
(cherry picked from commit 7f45661d)

Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

We currently escape post content before submission
But we also need to do cleaning on php side incase hacker posts directly

Also needing to clean up annotations with bad html in their
descriptions and resume composite fields with bad html in their
descriptions

behatnotneeded

Change-Id: I8c7def1acad7b6692a96b2ba065c23abcd69cfb5
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit cff11225)
(cherry picked from commit 8a8b21e4)

When there are no blogposts made

behatnotneeded

Change-Id: I7a3b2bed818c66fd4edef188ed7ba475e54c3a4c
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 087cb93d)

Rather than update db directly - we need to update the USER object

behatnotneeded

Change-Id: I31f8c6759dd621439c90ddc0f0dc8a344359d5d9
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 4adf4a01)
(cherry picked from commit 6905c539)

Cecilia Vela Gurovic authored Mar 26, 2018 and Robert Lyon committed Mar 28, 2018

when using pagination
behatnotneeded

Change-Id: Ia1c55442a66ff4581543db42615dcd5a3ee411bb
(cherry picked from commit 5ccfbdd3)
(cherry picked from commit c1b343d4)

Robert Lyon authored Mar 08, 2018 and Cecilia Vela Gurovic committed Mar 22, 2018

Get these deprecated warnings:
Non-static method PluginModuleFramework::add_matrix_to_db() should not be called
statically in htdocs/module/framework/lib.php on line 56
Non-static method PluginModuleFramework::matrix_is_valid_json() should not be called
statically in htdocs/module/framework/lib.php on line 107

behatnotneeded

Change-Id: I959b1364926a32b88fe9aaea147b5d38de6884b0
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 53914399)

Alexander Del Ponte authored Mar 19, 2018 and Robert Lyon committed Mar 21, 2018

behatnotneeded

Change-Id: I1eacae46787c2353f27664ed2788a9ac8fe97ddc