Robert Lyon authored Mar 20, 2019 and Cecilia Vela Gurovic committed Mar 28, 2019

There are two $string['portfolio'] strings one needs to be uppercase

behatnotneeded

Change-Id: Ia5e0390e719099408105c34810dae2fed35ad9b5
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

updated form name to be newblock, modified js funcs to use new id

behatnotneeded

Change-Id: I1e898f6e4942442f0e3fbd6aa91d07e3dc238e04
Signed-off-by: Lisa Seeto <lisaseeto@catalyst.net.nz>

-Changing .hidden to d-none
-Changing button styles
-Fixing dashboard styles
-Misc

behatnotneeded

Change-Id: I320882f682ef4b33ff7a9836f4eb4438f4a93b93

1) Add an 'instructions' field to view table via install / update.

2) Add 'Instructions' textarea / wysiwyg field to view settings page and
have it save to the database

3) Move generic "This area shows a preview of what your page looks like.
Changes are saved automatically. Drag blocks onto the page to add them.
You can then also drag them around the page to change their position."
text in edit page to the help icon and in it's place have an expandable
area to display the saved 'instructions' message.

4) On view display page have an expandable area to display the saved
'instructions' message

5) in view edit mode, collapsing/uncollapsing the Instruction section
is remebered automatically for next time the view is edited

behatnotneeded

Change-Id: Ia56323b9b734b8ebe9498c54dce5a3b934d1fd29

Gregor Anzelj authored Jan 17, 2018 and Robert Lyon committed Aug 09, 2018

Allow institution admins and site admins to immediately remove all
sharing options from a page (or collection if the page is within
a collection) that is deemed objectionable.

behatnotneeded

Change-Id: I23de7ed5c4678afe8a65e51b2aec06126948c637

behatnotneeded

Change-Id: I1f54b6d7649c1ff60661ba65cf0e1ac0d7c26af3

fixed for Dashboard page to show the skin

behatnotneeded

Change-Id: I8720025e854d60c03980f5857786ce8171fe7db1

I've removed some more things that don't seem to be needed.

behatnotneeded

Change-Id: I811aff5ac64e0d4178f61d39e19541f7b5e45cea

Jaque authored Feb 21, 2018 and Kristina Hoeppner committed Feb 25, 2018

Add fieldset and legend to blocks

behatnotneeded

Change-Id: Iae4266b5261dbaef05586aca30c494580c1b991c

creating a new page.

It is mostly so we can show 'No title' for page name and to have a
'back' button instead of 'edit page' when viewing ones own page.

But we don't need it as a page has a title when we click 'add page' as
we make the new view entry in database straight away and the title
will be something like 'Untitled v.2'.

And if we change the title on page settings form then block edit screen
will now show new correct title instead of 'No title'

behatnotneeded

Change-Id: I4630d53fbee734f1f4e903c05aa92b8348f3f41f
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Samantha Jayasinghe authored Oct 11, 2017 and Robert Lyon committed Nov 20, 2017

And avoid direct $_GET and $_POST usage where possible and instead use
param_exists() and the correct param_*() function to fetch the
expected value

behatnotneeded

Change-Id: If2a917360ebf1d198a494907517eb06bb823743c

Bring title, layout and skins into the same
"Settings" screen and display them in panels.

Still to do:
- Fix existing Behat tests where needed
- Remove code that is not needed anymore

behatnotneeded

Change-Id: I0da607187f1e2b7b03fc1ebbbbe205ca1d3e87c2

When going to another page of pagination it rewires up the modal connections
Works on page view and page edit screens

behatnotneeded

Change-Id: Ic38cf3e03272849c3a278ed40360c634e1472ae9
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Replaced most calls to DB to request group
basic information, for get_group_by_id() method
in group library

behatnotneeded

Change-Id: Ie03520a6c7a364ead63ccedaff07118a5928348e

alexeyomelchenko authored Jan 19, 2017 and Robert Lyon committed Feb 10, 2017

* remove mochikit libraries
* remove refs to these libraries
* fix code where still referencing to mochikit

Change-Id: I7bc78e4dade362035c3a7fe482ff66b30200f003
behatnotneeded: same functionality
Signed-off-by: alexeyomelchenko <alexeyomelchenko@catalyst.net.nz>

Gilles-Philippe Leblanc authored Dec 09, 2016 and Robert Lyon committed Jan 31, 2017

behatnotneeded: style change only
Change-Id: I5d81b31a41f655acd3f29ea98169eeea52108f0a

And the needing of switchbox.js to exist for the page

We will incude it as part of the smarty setup

behatnotneeded

Change-Id: Ie38f3d5fd89ae779566626be0f69db2ada65f074
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Aaron Wells authored Mar 22, 2016 and Robert Lyon committed Oct 04, 2016

Bug 1560329: We were neglecting to rewire the "cancel/remove"
button on a block config after a Pieforms validation failure.
A pieforms validation failure (when you're using Pieforms'
jsforms feature) actually replaces the current form with a
new one, rather than just inserting error messages into the
existing form.

Change-Id: Ie3fa440595b08cc5a49cb89cb7ca95bcfa02c2db
behatnotneeded: Not easy to test with Behat

So that we can differentiate between plugin types that have the same
plugin name, eg comment artefact vs comment blocktype

behatnotneeded

Change-Id: I0f7ffe6da3f7a4ff88cf625a1010c6d2012932d0
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

To be more inline with bootstrap stylings

Also passing in $view object so we can find the user's default theme
if the view's one doesn't exist rather than defaulting to 'default'

behatnotneeded

Change-Id: Ia4cc0552604698a1fd1aa2f6de666e82b6b86564
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Aaron Wells authored Jul 06, 2016 and Robert Lyon committed Jul 07, 2016

Since we now have multiple places that check whether the view is a site template
page, I've consolidated the logic for it into View::is_site_template()

Change-Id: Ibf23fe14d7f5bba8e1dc5a1281a2534d32b9887a
behatnotneeded: Test to be provided later

Regression from Bug 1397110

Change-Id: I6f98131dd61e06d0bc9d268bbe3eee1c4d4fbcb0
behatnotneeded: covered by existing tests

An oversite when Bug 1397110 was tested

behatnotneeded

Change-Id: I1772d27bb1ec099a26149551f82cf6ea365bb780
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Son Nguyen authored Dec 08, 2014 and Robert Lyon committed Apr 27, 2016

- Change ownership of default system templates
 from user 0 to institution 'mahara'
 and set template to 2
- Enable to add site files into site templates

behatnotneeded - existing tests for system templates are ok

Change-Id: Idfd5fca423e6f6a5f66d6cf944f7c5f88112584c
Signed-off-by: Son Nguyen <son.nguyen@catalyst.net.nz>

To make this similar to PAGEHEADING / TITLE for consistency

This allows the for it to display when an AccessDeniedException is
thrown.

Also fixing up where the PAGEHEADING / SUBSECTIONHEADING were set in
the wrong order.

behatnotneeded - existing tests should be fine

Change-Id: Ife016639aa8f444e6d3f3183e3753cd9f8e9aae4
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Gregor Anzelj authored Dec 12, 2015 and Robert Lyon committed Feb 24, 2016

behatnotneeded
Change-Id: Ie966c72484c06ac33ce7cf93c7b76d453443aad5
Signed-off-by: Gregor Anzelj <gregor.anzelj@gmail.com>

Sarah Cotton authored Nov 13, 2015 and Robert Lyon committed Nov 15, 2015

behatnotneeded

Change-Id: Iffe40a00d119efca936a40500b762a625e5f348a

So it can be passed to 'edit access' page from the 'edit page' page
on the 'Share page' link

Change-Id: I1968d205b12840cd3dcfbd80a6ffdd26a498361d
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Pat Kira authored Oct 08, 2015 and Robert Lyon committed Oct 19, 2015

behatnotneeded: styling only

Change-Id: Ie47b903e93816c7bac53437bdbb3842020a0effe

This fixes a bug with long page names in the collection management
screen and tidies up some other drag and drop weirdness.

behatnotneeded: exisiting test coverage should cover this

Change-Id: I44ee2f91b4e6ff3c612584d10abe79fc18693752
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Change-Id: Ie1b2e8fb8a72a339f3decd127eeb320191d11842

Naomi Guyer authored Jul 20, 2015 and Robert Lyon committed Jul 31, 2015

Change-Id: I6bbd0edde9b09c7a01cc0e36fa5bfe55972a14e8

Change-Id: Ia5275e7b5761b0c8e155c0c55ede490be73c773b
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Naomi Guyer authored Jun 14, 2015 and Aaron Wells committed Jun 15, 2015

Bug 1465107: Use Bootstrap CSS Framework

Change-Id: I83a5945d5cfd051eefc0752d910253d193e14042

Naomi Guyer authored Jun 10, 2015 and Aaron Wells committed Jun 15, 2015

Bug 1465107: Use Bootstrap CSS Framework

Change-Id: I991b636473d7a4f2d3f0d091331c849e413b925e

Naomi Guyer authored May 26, 2015 and Aaron Wells committed Jun 15, 2015

Bug 1465107: Use Bootstrap CSS Framework

Change-Id: I332f8f2ea0c317b5171fe9163912c760f6bc2c77

Naomi Guyer authored Apr 08, 2015 and Aaron Wells committed Jun 15, 2015

Bug 1465107: Use Bootstrap CSS Framework

Change-Id: Iaac575babb46a09eb246ac76b9a406124c800ab8

Bug 1407854

Change-Id: I659f2daf5032dbdea495596690162b52795044a9
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

This is because the selenium gets confused by having two 'save'
buttons on the page, as the 'addblock' one gets hidden but still exists

Change-Id: Ieef1c583fa0f4ea5381ba931ab12f116556740cf
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Change-Id: I60c9b6b5547dc3d460044fff45192f15e176d50f