GitLab

changing search_user_my searching of preferred name vs first/last name to bring in line with search_user_pg

The name is largely irrelevant as it's only the creator of the file.

so user/find.php doesn't include the searcher in the results

modified search_group to order the groups (by group name) and allow to filter search to groups the user isn't in

Make admin users/staff users scripts show all users rather than just users that would be returned by standard search. Fxies #1756.

This is actually quite a large patch, which does the following:

 * adds a db_ilike() method, which returns the correct keyword (LIKE or ILIKE) to do case insensitive searching.
 * Switches the templates used for the admin user search for strings, rather than using files. This prevents problems when the theme is not the default and the templates are not there.
 * Implements admin_search_user in the internal search plugin for MySQL as well as postgres, without needing two separate methods since the query works on both.
 * Make the userlist element use the new json/adminusersearch.php script, which performs an admin user search.

One happy upside is that the admin user search screen now works in MySQL.

Signed-off-by: Andrew McMillan

Other search files changed to support this

Also put in a check for no results being returned.

level

Improvement on searching algorithm - search on preferredname if available regardless of public setting

Now, table names (and other identifiers that could be confused with SQL kewords), should be put into SQL like this:

SELECT * FROM {artefact}

The braces are matched and expanded by DML now to include the prefix and be properly quoted, which means that tables like 'view' and 'group' don't need renaming (and nor should they, there's little reason why we should rename tables to get around such constraints).

This has removed a whole bunch of $prefix = ... and get_config('dbprefix') stuff, which makes things a little simpler yet again.

Renaming communities to groups step 1: everywhere in the code. Filenames and database changes to come.

Wrong branch...

This reverts commit 21fedcd0.