GitLab

So we can change it quicker

Also fixing up how the view does it now that I understand how it's
suppose to be done

Change-Id: I38b2ebf2fe2cb7060833eb7c771eb82380e5a23a
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Evonne authored Dec 16, 2020 and Kristina Hoeppner committed Dec 23, 2020

1. Profile picture in sidebar is now always within the background colour
   even when there is a short name.
2. 'Tags' is not displayed in bold any more so as not to draw too much
   attention to it.
3. Removed all pull-right and pull-left classes and put in float-right
   or float-left instead (bootstrap legacy).
4. Fixed field outline colour in the configurable theme so that the same
   colour is now used everywhere.
5. Reviewed the use of outer-link and inner-link as they were not
   accessible. Rule: If it is a single link it can an outer-link so that
   the entire item is outlined on click (nicer visually), but if the item
   has other links within it then outer-link should not be used.
6. Removed outer-link hover background as some list items had it and
   some didn't. Rule: No hover background colour for items.

behatnotneeded

Change-Id: I737841f9bfe825c0a004951bb4b7c7c589ab019d

Rebecca Blundell authored Oct 22, 2020 and Robert Lyon committed Dec 22, 2020

rewrite properties file and functions to make structure
easier to manage:
- add multiple arrays to split up properties by category
- modernise PHP syntax to use array constants
- fix location option to work properly
- remove need for xpath/css to be specified in arrays,
by adding set_selector_type()
- remove unused function and add others as required
- update tests to call properties, not css/xpath
- add check for null return from  get_property() and
throw ExpectationException for property if null

Change-Id: If64a5a1ed1a572b8eadcf91dd9f7a87bcf621d7c

When the admin is within an institution.
The institution name is being displayed as 'Shared with'

This is due to an error in the fix for Bug 1501133

Also an issue with stop/start dates - removing obsolete check

Change-Id: Iddf10abfe9b731d5571745811cbd7c3f792f687b
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

 - set the user->authinstance in removeMember()

Change-Id: I34afd54149936b02b61d65cc036c0a2d4450f576
Signed-off-by: Lisa Seeto <lisaseeto@catalyst.net.nz>

When archiving a collection

Change-Id: I4c978de93e04dcdedc328f5d31f8dc13d9208159
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Kevin Dibble authored Mar 22, 2019 and Robert Lyon committed Dec 19, 2020

Need to define owner and block when creating a
peer assessment artefact while importing

Create a temp block to assign on artefact creation
that later needs to be replaced by the actual block
when it's available

Draft assessments should not be exported or imported.
For exported portfolios created on older version of
Mahara, there is no way of knowing if they are drafts
at the moment of importing because this information
was not included in the leap2A export xml file.
Not importing draft peer assessments should work
from this patch.

It also adds a fix to support
Postgres and MySQL when a table
column name is a reserved word.

Removing not null restriction for "usr" field in "artefact_peer_assessment"
table:
- The author in peer assessment table should be working as comments table.
- For each comment, there is an entry in 'artefact' table that contains
author and authorname, and another entry in 'artefact_comment_comment'
that doesn't have an author field
because we already have one in 'artefact' table.
- We should have something similar on 'artefact_peer_assessment'.
There is already an author field in 'artefact' table,
then the 'usr' field in 'artefact_peer_assessment' should not to have a
'not null' restriction. If the peer assessment artefact has been imported
and the author is not present in this site, then the 'usr'
should be allowed to be null.

behatnotneeded

Change-Id: I182520159d1fcbc072081c2d976cdc68cde5e19d

Format display name options are not used in the basic elements
of the config but in the advanced elements.

Change-Id: I6f4c8dd2a374e767b3b08f697159f69e019f3871

Doris Tam authored Dec 02, 2020 and Robert Lyon committed Dec 17, 2020

Moving the watchlist delay notification setting from site options from admin settings
to plugin administration under blocktype.

- Moved strings to the blocktype.watchlist lang strings area.
- Removed a set_config call in upgrade.php and added a post_inst method
following other blocktype plugin  post install calls instead.

- Upgrade step to transfer over old site setting 'watchnotification_delay'
to plugin admin, updating the version number too
Change-Id: If388ddd083ceb8f46026fdc138f27ca8c8da5b04

Links are now dependent on Mahara version on SmartEvidence upload page.

Change-Id: I61d20ef2da6d45f28bb16deb0c2d6cf41ef4f143

Merge "Bug 1831415: Add condition in the query for role of people who have not submitted pages in group"

Change-Id: I7fc854ef3faf8829505832599eb2731c76f5e1e5
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
(cherry picked from commit 0c1eb4b6)

Added another query parameter in the url 'shortcutnewentryviewid' to know which view
the request for new entry came from and  to know where to return to once new entry is made.

Change-Id: I5c6a7e2fd214f6fb8dc61acead56f746992976eb

Added a condition for the role to be 'member' so that admins and tutors do not show up
in the 'members without a submission to the group' list.

Modified method documentation comments to match.

Change-Id: Ie63483d36e26766800ecc65b3802d8e9c712c37b

 - change the way that the js script for slideshow is called
   eliminating the need for bootstrap to be included a second time
   (error was because bootstrap was included without popper.js first,
    but it turns out bootstrap didn't have to be included at all)

Change-Id: I3cb530d892105027c9ace08dded0a3717a571834
Signed-off-by: Lisa Seeto <lisaseeto@catalyst.net.nz>

As the normal one relates to form fields and that is not always correct

Change-Id: Id4f061a082366deaf3aa5caafd0058b622af25e4
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

This is so we are still able to expand the last submenu without it collapsing
by clicking on the arrow (last menu item) rather than collapsing the menu
when removing focus from it (what was the last menu item before expanding it).

Change-Id: Ie8920b1731b41e3db5f943d50f43642608885dc2

* changes:
  Bug 1904949: removing old duplicate lang pairs.
  Bug 1899855: Created lang strings for hardcoded string literals in webservices/functions

Doris Tam authored Nov 20, 2020 and Robert Lyon committed Nov 27, 2020

There is one edited lang string key which I am not sure where it belongs to.
When it was created 8 years ago, there was a typo on the key. Probs a
copy paste error.

Change-Id: Ib98a90e40be1fc1c40f379246d18b8f2ad576c67