Pramith Dayananda authored Jun 29, 2017 and Robert Lyon committed Jul 10, 2017

Changes applied to display_icon
New lang string added
behatnotneeded

Change-Id: Iad33ebc98c9402d9b38ad1fa4fabb3a11268d0ad

When we add an app configuration via
Administration -> Webservices -> External apps

We can check and make sure the 'webservice' auth instance exists for
the institution we choose.

behatnotneeded

Change-Id: I5012346c290ad94990cd48dcc1e5dc5b9ee694d9
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

There was a nested <form> within a <form>

Adjusted so the form only renders with one <form> tag

behatnotneeded

Change-Id: Ib3497ba41a49ccae12da4794cdfca98b94d2eafc
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

- Tidy up multicolumntable render tags, all the tags are closing
  properly
- Change register servers table renderer from fieldset to container
- Added title element to pieform container renderer, container.php
- Removed duplicateed class attribute in display_icon

behatnotneeded

Change-Id: I003f5152fd6a291c95156527ff12057256090228

Kristina Hoeppner authored Mar 29, 2017 and Robert Lyon committed Mar 30, 2017

Some string IDs changed so that they are
picked up by the translators while others
aren't changed when they are just changes
for English.

behatnotneeded

Change-Id: I9afb8980492937f361e6e35361245c689b5a4413

Kristina Hoeppner authored Mar 28, 2017 and Robert Lyon committed Mar 29, 2017

in "Web services" to make it easier to see that
external applications are being added.

Change-Id: If92c1d99a893cfc3d64759599570af0f97cc38e0

Before checking that it is in database and is unique

behatnotneeded

Change-Id: I3c51b228361ad10c567f6af04148246a95fed096
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

So we can disable the uri field in oauth edit form for LTI

behatnotneeded

Change-Id: Iad145ff2a723fdd0138506fdf073c4074999b787
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

* Extends the existing webservice auth to support SSO via LTI
* Adds an LTI module to support SSO and future LTI features
* Adds per-oauth token config to enable/disable on-the-fly user creation

behatnotneeded

Change-Id: Id6488930f37bdfd8200b4e9261f5292f2b72fbc7

Only changed the version number.
The upgrade modified a part of Zend framework we dont use.

Change-Id: Ifaa190e0d75823c50966c3c9c8f6d2b8b792d568
behatnotneeded: no change in functionality

Replaced most calls to DB to request group
basic information, for get_group_by_id() method
in group library

behatnotneeded

Change-Id: Ie03520a6c7a364ead63ccedaff07118a5928348e

To allow us to easily turn of a 'bad' auth when it is trying to
connect to a third party server but that server is not reachable.

Currently it makes logging in slow as it needs to timeout on that auth
instance before trying the next one.

behatnotneeded

Change-Id: Ieeaeeaeb1bc0aa61ed3faad8f3bf751edd9c1023
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Was not quite working before.

Things also fixed (or partially fixed)
1) The webservice logs page searching for function name to filter by
- before the ajax was wanting to paginate by 5 and select2 expected 10
results so the more search results was not working

2) The error returned on the testclient page when there was an error
with a field didn't display which field it was.

3) Display on testclient page a file upload filed if type is PARAM_FILE
- The actual testing of file upload is not working yet but it wasn't
working before either but this is a step in the right direction

4) The wsdocs page was displaying 'REQUIRED' for the VALUE_DEFAULT
fields rather than the VALUE_REQUIRED fields.

behatnotneeded

Change-Id: Ia00beeb6d48fa3019984f2e0f7605fbb097edffd
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

File contains class Zend_Log_Writer_Mail
that is not use in Mahara.

behatnotneeded

Change-Id: I53bb9a8e5ab1212a3bb1cf7016d0d3d64b3c4a07

Fixed lines of code that threw the error
"Only variables should be passed by reference"
and other errors found.

behatnotneeded

Change-Id: I23e6a3c1b2ef97bf2cae29c15814fcdb79d5676f

behatnotneeded

Change-Id: Ife98c308a37f3d131ea7aae776a5917fe0b6e53a

Fixed error when

accessing page webservice/testclient.php
that showed a debug message "Only variables should
be passed by reference".

importing Leap2A file that showed same message.

behatnotneeded

Change-Id: I44d1bbb4303fcf50d633e62ff2e316cf28fa3c47

Piers Harding authored Oct 07, 2016 and Robert Lyon committed Nov 01, 2016

Bug 1631810: Web services fixes

* fix json_decode() invalid param warnings
* dont pass functionaname if it's empty

behatnotneeded

Change-Id: I83acba2795fa901613b985a5b82586281b1e5f3c

In rest/locallib.php and lib/mahara.php

behatnotneeded

Change-Id: I5120656913d39b69d2f8c9492b485a12e7c58f90
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

plus fix for non custom service groups edit button to have right side
border

behatnotneeded

Change-Id: Ib760673905f022823038a1240c87dc12f8714444

The fields that exists in usr table that also need updating in
artefact table for artefacttype, eg studentid

behatnotneeded

Change-Id: Id9ad96fd651423b1a8078ddc8cf7de87a857bf39
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded: Covered by existing tests

Change-Id: Iec9939b02b7b38fbf0f3217d6be45d538e3a9760

behatnotneeded: Test to come later

Change-Id: I0c1b2b7ee9cc927a23c498293da0ddc1ec31f31e

behatnotneeded: Test to come later

Change-Id: I2663d376f6bc50d7195d6d26d65206a47385e21c

This module will hold most of the code specifically needed
by the Mahara Mobile app (as opposed to normal webservices
functionality, which is mostly meant to be server-to-server)

behatnotneeded: Test to come later

Change-Id: I8dca163ba9dd4c1777564e305cf49768358be088

Aaron Wells authored Oct 03, 2016 and Robert Lyon committed Oct 08, 2016

- Respect the "optional" and "default" flags for
object and array params (not just scalar params)

- Allow REST server to handle file upload params ($_FILES)

behatnotneeded: Tests to come later

Change-Id: I3a6a6ccf7c9de1711e2fd39aa5f130c245823721

Aaron Wells authored Sep 26, 2016 and Robert Lyon committed Oct 08, 2016

These fields can be used to indicate which client app
registered and/or is using the token

behatnotneeded: Can't be tested in Behat

Change-Id: I939c844cc5474fc799ddfd002a1052bb4ca67d1b

Aaron Wells authored Sep 26, 2016 and Robert Lyon committed Oct 08, 2016

behatnotneeded: Test to come later

Change-Id: I77131ad76a5a9f1c6e0f780fdb9bff07d70a8421

Aaron Wells authored Sep 26, 2016 and Robert Lyon committed Oct 07, 2016

Two of the server classes had their own implementations of this,
with slightly different logic. Moving it up into the parent class
in order to make sure everything works the same, all the time.

behatnotneeded: Can't test in Behat

Change-Id: I91c205822a18213c475bbef7c784247cebdbd649

Currently, a plugin has to list its component as e.g.
"module/mobileapi/webservice". This could just be "module/mobileapi".

Since we're using the component string as part of the automated token
request system, it's better to change this now to something more sensible.

behatnotneeded: Tests to come later

Change-Id: Ia7663065b79598d92c3bf8450c5539efb6aa3e2d

Aaron Wells authored Sep 26, 2016 and Robert Lyon committed Oct 07, 2016

behatnotneeded

Change-Id: Idea08ba7827d939af6f2fc8ec6be30774f2af5cb

To help clients determine which version of a webservice
they might be connecting to.

behatnotneeded: Tests to come later

Change-Id: I90abd0d9470cba4ae42ee3a22a6c0629d325f8d2

- Adding "shortname" field to service groups
- Marking plugin-created service groups, as the ones that have
a "component" field. Make the function list for plugin-created
service groups not editable by users.
- Since users may have already edited the old "sample" service
groups, removing the "component" value from those.
- And, to avoid trouble going forward, preventing the install
of the sample service groups on new installations

behatnotneeded: Tests to be written later

Change-Id: I23c781d6f2bbf689c12de30a67882bf3f1f4aff9

JSON-encodes more information about the error or exception,
and adds an optional error number.

behatnotneeded: Can't test in Behat

Change-Id: I258e7a275d78c91a5f8cd638ab7f6a7590125a6d

In web service configuration, when service provider master switch
and service requester master switch are set to off,
then all protocol switches are set to off and disabled.

behatnotneeded

Change-Id: I2672d93abd14d80f184e08c9796e6fcbee4bfc91

with $smarty->assign()
behatnotneeded

Change-Id: I667463b7732bd3f1dd2619b2836cf4b8c560d264

This patch does a few things:

1. Renames "webservice_enabled" config to "webservice_provider_enabled",
to indicate that this config only controls Mahara's actions as
a webservice provider, *not* a webservice client.

2. Renames all the "webservice_<protocol>_enabled" configs to
"webservice_provider_<protocol>_enabled" to indicate that they only
control whether Mahara will provide webservices via that protocol,
and not whether Mahara will use that protocol as a client.

3. Renames "webservice_connections_enabled" config to
"webservice_requester_enabled", to clarify that this config
controls whether Mahara is allowed to request webservices
from external sources.

4. Updates language strings to make these changes clearer.

5. Rearranges and renames the form methods in
webservice/admin/index.php to make the flow of control more
obvious. Now the main form method is first, followed in order
by the methods that generate its subforms and each of their
submit handlers.

behatnotneeded: Covered by existing tests

Change-Id: I58dadb352d1f1542ca67a104ebfd702b4ca90fc9

Following instructions in readme_moodle.txt

behatnotneeded

Change-Id: I079b683f28a75805b1fb4d85326f9d836130817d

Aaron Wells authored Jul 12, 2016 and Robert Lyon committed Jul 13, 2016

If the site doesn't yet have any plugins installed that define webservice
connections, then the institution connection manager screen can't be used.
In which case, we should hide the link to avoid confusing users.

Change-Id: Ia9351995485331ea5d6fc94fcdf69eafbfa18c01
behatnotneeded: Can't readily test in Behat

Robert Lyon authored Jun 27, 2016 and Aaron Wells committed Jul 08, 2016

Including:
- making add connection form cancel back to connections page
with correct institution selected
- Adding a help icon/page (needs content) for add connections
- Display tick/cross next to connection name to see if it is enabled
- Have the 'enable connection manager' master switch bunched with the
others
- Changing some strings to make thing clearer

behatnotneeded

Change-Id: I875ad6ec745cd136338017e27ef49542157cac7c
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>