GitLab

Because all of our emails need to pass PHPMailer's
validation method before they get sent (due to the way
PHPMailer is written) it makes the most sense to use
that for validation.

Change-Id: I232ab9496ce8fc295a49625c999b48215305216c
behatnotneeded: Covered by phpunit

behatnotneeded

Change-Id: If8c5535d85e78eb53ab855bcc400477c9d795a8c

This patch does a few things:

1. Renames "webservice_enabled" config to "webservice_provider_enabled",
to indicate that this config only controls Mahara's actions as
a webservice provider, *not* a webservice client.

2. Renames all the "webservice_<protocol>_enabled" configs to
"webservice_provider_<protocol>_enabled" to indicate that they only
control whether Mahara will provide webservices via that protocol,
and not whether Mahara will use that protocol as a client.

3. Renames "webservice_connections_enabled" config to
"webservice_requester_enabled", to clarify that this config
controls whether Mahara is allowed to request webservices
from external sources.

4. Updates language strings to make these changes clearer.

5. Rearranges and renames the form methods in
webservice/admin/index.php to make the flow of control more
obvious. Now the main form method is first, followed in order
by the methods that generate its subforms and each of their
submit handlers.

behatnotneeded: Covered by existing tests

Change-Id: I58dadb352d1f1542ca67a104ebfd702b4ca90fc9

behatnotneeded

Change-Id: Iacf30fcf803f73b39dc96635b4f165d5c8da1382

behatnotneeded

Change-Id: Id89d92e2ac6735dbc9d2be126cd535eb832a2572

behatnotneeded

Change-Id: Id66dbde93b1be3c4814a69674258f65be6223b6e

Check the format of the record in the import_queue table when processing
the queue. Ensure it always defaults to a valid format that is installed
and enabled. If it is not valid, throw an error.

Clean up the call PluginImport::create_new_queue() by removing the
non-existant 'plugin' field.

Also, wrap the importer in a try/catch so the core_import_process_queue
cron process can contiue if there is an error.

And, validate that the keypair_PEM exists when checking openssl_open().

behatnotneeded

Change-Id: Icde78f862ca0e120b67393f4a5abf464695f5104

Also adding aria-required="true" to required fields

behatnotneeded - existing test are ok

Change-Id: Iaba02ea6653d28da298a0e410ab3d79773f810db
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded: Can't test in Behat

Change-Id: I3dac42a4e5a08155e131bc45494b78a13c1417cd

And avoiding storing full path to dataroot temp dir in db for imported
entries

behatnotneeded

Change-Id: I18fb3a76accd57517e340ce98a19f7b10bd4814c
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Also swapped round the 'copy page' and 'copy collection' buttons

behatnotneeded

Change-Id: Ic0c32364e51b56ffbcf7108877c6ea2820ebf45c

Bug 1525736: Also doing a general cleanup of this very old
and very messy function.

behatnotneeded: Covered by existing tests

Change-Id: I4b2feba22764fd290a69dc4b6ab1d734abd08a1c

If there are negative block_instance.order values in the database,
then we'll just drop and re-create the unique key on the column.

Change-Id: I3ef1507f82ae3dc24244e6236e173b6649a95d3b
behatnotneeded: Covered by existing tests

behatnotneeded: IOU a behat test for clamav

Change-Id: I43a65b7be7490bbcb13fa8885ca119c130856a98

* changes:
  Bug 1613483: Hide "Open file" button in the toolbar
  Allow the pdf viewer to display menu items in user's lang (Bug 1423435)
  Embed pdf has horiz scrollbar on default 3 column layout (bug 1237137)
  Getting the bottom of the pdf viewer to display (bug 1240776)
  Adding ability to download embed pdf when js turned off (Bug# 1211070)
  Bug 1613483: Update mahara template for pdf block
  Bug 1613483: Update PDF.js to 1.4.20

This patch contains these three related changes:

1. Removes the "THIS IS BAD" message that was printed when 3rd-party
exception or an instance of MaharaException was thrown.

2. Removes the completely unnecessary "MaharaThrowable" interface.

3. Adds an comment explaining why MaharaException is not abstract

4. In the case of a smarty exception while printing an error, prints
the name and content of the smarty exception.

behatnotneeded: Covered by existing tests

Change-Id: I800a868bd187efb76ed37cca872ce262c2abbdb0

Bug 1614805. When a plugin is installed "out of sequence" by a
call to plugin_upgrade in the core lib/db/upgrade.php file, the
AJAX-based web upgrader handles it gracefully, because it does
check_upgrade() before upgrading each plugin, detects the change
in status, and doesn't run the upgrade for that plugin a second
time.

The CLI upgrader, on the other hand, uses the same cached data
from check_upgrades() all the way through, causing it to re-run
upgrades for such plugins.

This patch makes it behave the same as the AJAX plugin, running
check_upgrade() again immediately before each component gets
upgraded. This does cause some redundancy in code execution,
but it shouldn't be enough to cause a noticeable performance hit.

Change-Id: Id5c431fc9e636df2cab05d22e6cc424271ce9f3d
behatnotneeded: Covered by existing tests

behatnotneeded

Change-Id: I3204369ec36bbfa01227f210e8fc79526679f660

* changes:
  Prevent HTTP iframes on an HTTPS site
  Add more legal color formats (Bug 1264098)
  Allow CSS comments in customised skins. Bug 1369830

Change-Id: I0b13222887d66d174f5e12d037dda4594acc0512

Seen as the 3 column layout is the default one the embed pdf view
should fit within it.

Currently if you have a browser windo open fully, a 3 column layout,
and a pdf embedded you get a horizontal scrollbar on the embed pdf.

A slight adjustment of the min-width and it goes away.

The scrollbar will be there for 4 or 5 column widths but that is ok as
they are quite thin columns.

Change-Id: Ib01118d9fffab14440308eaf04b5038fdfeca9c3

- change allows for a bit of the base of the display so it doesn't
look broken

Change-Id: Ie163f986a4c6abcf60cb26fc3b479122c119fc10

Change-Id: I829b996c5ce9bfa9e2b882b2209adc3731bec49a

* Remove sample pdf files
* Use absolute paths in viewer.js
* Open fileurl if defined

Change-Id: I99dc0f84e693c0ea1dc231814379a43297a57411