1. 19 Oct, 2019 1 commit
    • Evonne's avatar
      Bug 1845104 Modern theme changes · 1d1bb649
      Evonne authored
      - removed redundant styles
      - reconvert files to make macros work on windows (has to do with woff)
      - put necessary changes back into raw
      - put in OFL file for font Raleway
      
      behatnotneeded
      
      Change-Id: If1a3eb4bfba86ec18f3f0e38104b79e6642048d0
      1d1bb649
  2. 09 Oct, 2019 1 commit
  3. 08 Oct, 2019 9 commits
    • Rebecca Blundell's avatar
      Bug 1840108: Customisations to select2 4.09 · 3dcc515f
      Rebecca Blundell authored
      Adding in changes made as per the select2 README.Mahara
      and adding commit details to the README where that was helpful in finding
      the changes.
      
      behatnotneeded
      
      Change-Id: I8579ba86d303ecc3b1d5ec50fb9e53972c8c2ff9
      3dcc515f
    • Rebecca Blundell's avatar
      Bug 1840108: upgrade select2 library to 4.09 · 52e5dffc
      Rebecca Blundell authored
      replaced select2 files with 4.09 versions
      
      behatnotneeded
      
      Change-Id: Ia1b4f896db75b55624d3917dbc08fcbdc3a137bd
      52e5dffc
    • Evonne's avatar
      Bug 1835329 Fix upgrade alert message alignment · 5d483d64
      Evonne authored
      - put in containers in header.tpl for alert messages
      
      behatnotneeded
      
      Change-Id: Ie07eb2b466868ee4b81be125f6b88c05d77482cb
      5d483d64
    • Cecilia Vela Gurovic's avatar
      Bug 1813987: resizing block when expandig collapsible inside block · 02c6617d
      Cecilia Vela Gurovic authored
      fixes failed step in resume_page.feature
      fixes in timeline view to expand a block to fit content
      
      behatnotneeded
      
      Change-Id: I1d187f338c0c36795efff40bbe8d9447b2d66124
      02c6617d
    • anupamadharmajan's avatar
      Bug 1834576: Content overview report contains negative number · 2247fd23
      anupamadharmajan authored
      Sponsored by The Australian National University
      
      behatnotneeded
      
      Change-Id: I805ee159f09bdcf5ea902176c1dc43d73617b7bc
      2247fd23
    • Rebecca Blundell's avatar
      Bug 1840112: update tinymce library to 5 · ada3e2cd
      Rebecca Blundell authored
      Replaced tinymce 4 files with tinymce 5
      Moved from unsupported 'light' skin to new 'oxide' skin included with v5.0
      Default theme has been changed from 'modern' to 'silver'
      Changes to tooltoggle plugin to work with new version
      Updated behat steps for change in class names
      Styling changes
      
      behatnotneeded
      
      Change-Id: I731962f8c522358034178528846aa0c35187d74a
      ada3e2cd
    • Evonne's avatar
      Bug 1845104 More small style bugs · 139991ae
      Evonne authored
      - Plan block in editor has chervons hidden under buttons.
      - Removing list-group-item first-child top border only when list
        appears directly below heading and not other cases, this gets
        repeated for in editor.
      - Tagged journal in full block should be flushed.
      - PDF has slight gap under header just like images/media.
      - PDF configure form has alert message with better spacing
      - Brand icons weren't working, like social media.
      
      behatnotneeded
      
      Change-Id: I7d373034de8188be5e8535d488468ef371516a22
      139991ae
    • Evonne's avatar
      Bug 1835329 Alert message icons · cacded84
      Evonne authored
      Taken out spans within alert and put in icons in alert:before,
      added variation for site-messages so it can be shorter and hang
      with page breakpoints. Also added icons for error messages under
      form inputs.
      
      behatnotneeded
      
      Change-Id: Ia31af160808ecc2943bb16ba68f04e8a98c0e055
      cacded84
    • Evonne's avatar
      Bug 1845104 Various small style bugs · cfc151e0
      Evonne authored
      - Chervons missing in inbox block, conflicting with text-small.
      - People list h4 wrapping portfolio list, moving it out.
      - dashboard editbuttons placement dependent on h1/h2 above, put in
        better conditions so it doesn't need it at all.
      - Plans chervon too far in, moved it out as no longer has details.
      
      behatnotneeded
      
      Change-Id: I50e60e2fb2c8be2370856823497a1b9099d1c28f
      cfc151e0
  4. 07 Oct, 2019 6 commits
    • Evonne's avatar
      Bug 1847009 Plan checkbox not clickable · 47b8964e
      Evonne authored
      When the outer-link was put in so that the entire thing can be
      clicked to expand, the checkbox was lost under the z-index. Fix
      now put the checkbox over the outer-link, making it clickable again.
      
      behatnotneeded
      
      Change-Id: Ie559560d5f43b8f841ee83538b5823d350f9387f
      47b8964e
    • Evonne's avatar
      Bug 1845104 Page and collection horizontal scroll · 178bb243
      Evonne authored
      Took out overflow-x: auto; in .view-container, can't see it
      breaking anything else so might be redundant legency css. Pages
      and Collections should no longer have an orange horizontal scroll
      under it.
      
      behatnotneeded
      
      Change-Id: I52f0a77a403cdc72163b4d7a60f19f99b28c0486
      178bb243
    • Robert Lyon's avatar
      Bug 1838915: Fixing problem with brands icons · 90df4cc6
      Robert Lyon authored
      
      
      Problem only exists on older browsers
      
      behatnotneeded
      
      Change-Id: Ie87ef3d3ae8f6bd81ec051afe69dbe0c7d228ea9
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      90df4cc6
    • Doris Tam's avatar
      Bug 920246: Adding category filter to admin/groups/groups.php · c541934b
      Doris Tam authored
      - Like the group/index.php page with the filter, this page also
        has a problem with the button when the width of screen is too small
      - Added a parameter to an existing helper function for groupcategory
        (build_group_list_html
      - Helper function group_get_extended_data(..) to htdocs/lib/group.php
      - Fix previous bug failure due to button class change for submit
      - Styling for table changed to to "break-word" to stop truncating words
      - overflow of buttons controlled + responsive results heading+footer
      - button moved to first level of form to stop button cutting button on
        small screen
      behatnotneeded
      
      Change-Id: I646135f6963f944b6d253d800882a77cac995e1a
      c541934b
    • Rebecca Blundell's avatar
      Bug 1840111: Update popper library to 1.15.0 · 2d85c2bc
      Rebecca Blundell authored
      also moved it to js since it's js
      
      behatnotneeded
      
      Change-Id: Ifdaa9cb44f188ec61f83f4e97ad99d4e2dab4434
      2d85c2bc
    • Robert Lyon's avatar
      Bug 1844838: Show more versioning info on site info block · 22a6111e
      Robert Lyon authored
      
      
      On the admin overview page
      
      Now lets you know:
      - if your branch version is not the latest
      - if your branch is a supported branch
      - if you are on the development branch (eg master)
      
      behatnotneeded
      
      Change-Id: I42ed605b7a298f7a006ea6f9eba9b3d551dc41ad
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      22a6111e
  5. 06 Oct, 2019 11 commits
    • Evonne's avatar
      Bug 1845104 Various theme fixes part 5 · e8475a33
      Evonne authored
      Changing attached files to not a heading and getting unified
      markup and styling of attachments and downloads across journals,
      resumes and files.
      
      behatnotneeded
      
      Change-Id: I66ae6a41068273af3780577bad5acf6f812d08d2
      e8475a33
    • Doris Tam's avatar
      Bug 1835869: Add skin background image to page header area · ad7250b7
      Doris Tam authored
      - Created an option in Skin customizing where users may select an image
        as their page header
      - Reorganised tabs and their titles
      - Skin thumbnails display colour/image of header
      - drop the old viewbgimg column and add the headingbgimg column
      
      behatnotneeded: to be added later
      
      Change-Id: Ib5bb4714de479e9c10237d24aa653a5ea227a5f7
      ad7250b7
    • Evonne's avatar
      Bug 1845104 Various theme fixes part 4 · c0cc88de
      Evonne authored
      Fixing plans blocktype markup, inbox blocktype redundant classes,
      alignment of add blocks button, modal thumbnail not floating right,
      resume attachment inconsistencies (to be continued)
      
      behatnotneeded
      
      Change-Id: Ic7c0cc5498dbd3f95f140581cc71b175e944a0d9
      c0cc88de
    • Evonne's avatar
      Bug 1845104 Various theme fixes part 3 · b084c205
      Evonne authored
      Fixing buttons and styleguide
      
      behatnotneeded
      
      Change-Id: I661e6350bb14ac4c77e4bf63777b346810ce5c65
      b084c205
    • Evonne's avatar
      Bug 1845104 Various theme fixes part 2 · 5c5db761
      Evonne authored
      Fixing metadata inheriting title fonts, plans alignment, comments.
      
      behatnotneeded
      
      Change-Id: Ice9dc3e5b090ad89340bcc6debfd0286d3609395
      5c5db761
    • Evonne's avatar
      Bug 1845104 Various theme fixes part 1 · 65103626
      Evonne authored
      Fixing some inconsistencies with user-icon sizes, on profile page,
      and recent forum posts, and taking out some redundant styles.
      
      behatnotneeded
      
      Change-Id: Ifef04d165a2257b6c89f007f82b33ef0b37edc3b
      65103626
    • Evonne's avatar
      Bug 1843823: Fixing up styling for resume blocks · fb0adb74
      Evonne authored
      Flushing parent list-group-items, giving headings more visual
      definition, spacing around elements so there's better grouping
      of elements visually.
      
      behatnotneeded
      
      Change-Id: I0031e7a27849de3dd16a150a9899ca775e1f75ba
      fb0adb74
    • Evonne's avatar
      Bug 1845273 Rejig CSS for wall posts · 4b545041
      Evonne authored
      Removed double <h1>. Changed the markup to reflect a list-group
      so it aligns with comments. Clean up styles.
      
      behatnotneeded
      
      Change-Id: I4920fa2c99ea057401128b4c126004345f6cc56a
      4b545041
    • Evonne's avatar
      Bug 1845061 Logo size in institution settings page · 7378486a
      Evonne authored
      Restricting the size of the logo displayed within the form after
      a image is uploaded, the logo has max height according to navbar
      height variable, the logoxs has a set height of 48px, values based
      on raw theme.
      
      behatnotneeded
      
      Change-Id: I92813a5c7c689675e55397cd26d870919d9bc33a
      7378486a
    • Robert Lyon's avatar
      Bug 1844953: Make the font specimens appear in modal · c0889d62
      Robert Lyon authored
      
      
      Rather than a new page
      
      behatnotneeded
      
      Change-Id: If81c1b343b1d32e291ca90e036082009c2d33a4f
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      c0889d62
    • Robert Lyon's avatar
      Bug 1843202: Allow theme fonts to be included in skin_fonts table · d61b9487
      Robert Lyon authored
      
      
      So that they can be
      - used in skins
      - viewed on the Admin -> Config -> Fonts page
      
      behatnotneeded
      
      Change-Id: I49aff91a7f56a003adbc9f3513aa9a094a3069e4
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      d61b9487
  6. 05 Oct, 2019 1 commit
    • Cecilia Vela Gurovic's avatar
      Bug 1813987: Tidying up some lastminute problems · fa4085d5
      Cecilia Vela Gurovic authored
      like
      - allow add block button to drop only inside the grid
      - navigation block in collection to copy to other pages
      - Smart evidence annotation feedback forms init tinymce
      - showing the peer can see content message again
      - allow copying of page with old layout
      
      behatnotneeded
      
      Change-Id: I3f552ce8f89125e9fd233513c855879aa7678048
      fa4085d5
  7. 04 Oct, 2019 11 commits
    • Robert Lyon's avatar
      Bug 1846813: Placing plan html export template in correct folder · 455e6182
      Robert Lyon authored
      
      
      Also removing the duplicate plan leap export template
      
      Change-Id: If9ca389df8f04d719f218c3ce378205a02607174
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      455e6182
    • Chanil Park's avatar
      Avoid progress bar overlapping border · 37637197
      Chanil Park authored
      - Remove export progress bar's scrollbar
      - Remove progress_meter overlap and have bar same height as export
      progress bar
      
      Change-Id: Ife0d77e0388d86c010838af49577622d6f6a30ca
      37637197
    • Aaron Wells's avatar
      Bug 1560778: Modal window for institution auth config · 3c396f54
      Aaron Wells authored
      Have rebased this and got it working by removing old mochikit stuff
      
      behatnotneeded
      
      Change-Id: Id4bbd0d08d6b743fdec426f27e41a2fbb9857651
      3c396f54
    • Cecilia Vela Gurovic's avatar
      Bug 1813987: Blocks display fixes · ccc2446d
      Cecilia Vela Gurovic authored
      - assessment block: tinymce and the asseesment js
      need to be initialized after the block is loaded
      - signoff block: sing-off modal is showing now
      - embedded media init functions need to be loaded after
      the blocks are added to the grid
      - wall post block initializes the tinyMCE after it's loaded
      and refreshes the content of the block after a new post is made
      - comment block: update block size when adding a comment
      - scrolling to the block when a new one is added
      - modified the text for button to add a new block to the page
        'Drag to add a new block' for normal mode
        'Click to add a new block' for accessibility mode
      - add a block to the bottom of the page by default so it won't
      break the layout
      - add SE annotation to the bottom of the page
      - added 'Add block' button event handlers after trnaslating a view
      - annotation feedback loads the tinyMCE
      
      behatnotneeded
      
      Change-Id: I7642cacde729a2a85b497e077452de792ec72eb7
      ccc2446d
    • Cecilia Vela Gurovic's avatar
      Bug 1813987: Accessibility settings and layout · 25082988
      Cecilia Vela Gurovic authored
      - Added an option to set the profile to accessible.
      This can be set in account preferences and
      enables one extra field in the settings
      of a view, in the basic settings section, to make
      the layout accessible.
      
      - by default, if the user account is accessible then
      the pages will be crated as accessible.
      To have a non accessible page, the option un view settings
      needs to be set as 'No'
      
      - Accessible layout only allows to add blocks with width=12
      that is the same with of the grid.
      This makes the blocks show as a sequence one on top of the other
      like a list. The user can only reorder the position
      they have in the list.
      
      - When a page is accessible, the adding a block
      by drag & drop is disabled
      
      - Reordering of blocks is accessible by keyborad
      
      - The 'add block' button is reachable by keyboard
      
      - add an intro to the page for the screen reader
      to explain how the page works
      
      - add identification to each block for screen reader,
      blocktype and title (if it’s set)
      
      TODO
      * When adding a block to the bottom or the top of the page,
      the page should be scrolled to that block
      
      * Floating menu: should have a way to be recognized as a menu
      by the screen reader. Check the access keys for the menu.
      
      behatnotneeded
      
      Change-Id: I08417f0f11d747a67900c88c2f675ef5f85b7499
      25082988
    • Cecilia Vela Gurovic's avatar
      Bug 1813987: User should confirm before the view is translated · 69916a3d
      Cecilia Vela Gurovic authored
      there is an account preference we can set for showing
      a warning message before translating the layout of an old view.
      
      By default it's true. It can be set to false in the account preferences
      or by selecting the option when the message is displayed.
      if this preference is set to
      true: if we want to edit a view with old layout,
      a message will be displayed to confirm we want to translate the layout.
      false: The view gets translated on edit without asking the user.
      
      The message has the options to accept, cancel  or don't ask again.
      
      cancel: redirects to the displayed view
      don't ask again: sets account preference to false but can be reverted
      in account preferences.
      accept: will redirect to the view edit page with a parameter
      saying the user accepted the translation
      
      behatnotneeded
      
      Change-Id: I84e1a86d3bb494a1955da9cbfbde996b555bb132
      69916a3d
    • Cecilia Vela Gurovic's avatar
      Bug 1813987: Exporting views with grid layout · b6cd876f
      Cecilia Vela Gurovic authored
      In exporting section:
      /export/index.php
      
      - Show preview of page both for old layout pages and
      new grid layout
      - Export views and collections with new grid layout
      in html
      - Export views and collections with new grid layout
      in leap2A
      - views with old layout are exported as before
      
      NOTE
      borrow some code from https://reviews.mahara.org/#/c/10157/
      as an early rebase (the patch is not on master yet)
      
      behatnotneeded
      
      Change-Id: I0c36c110c6b9ef7ae3edc4d0662a0dbab302684a
      b6cd876f
    • Cecilia Vela Gurovic's avatar
      Bug 1813987: Make view versioning work with gridstack · 7b17b833
      Cecilia Vela Gurovic authored
      - Only allow to create a new version if the view
      is using new gridstack layout.
      
      In timeline version section:
      - For view versions that were created with old layout,
      show them as they are
      (we dont translate old view versions to new layout)
      - For view versions that are created with new grid layout,
      they are also displayed in the timeline view with the new grid
      layout
      
      behatnotneeded
      
      Change-Id: I1abdae9e5e547dcc9bce97cac127085786dcac8a
      7b17b833
    • Cecilia Vela Gurovic's avatar
      Bug 1813987: Copying a page (in old or new layout) creates a page with new layout · f342e41b
      Cecilia Vela Gurovic authored
      - Copy a page when original view is using
      grid layout
      - Copy a page when original view is using
      old layout: Translates the original page layout
      without modifying it,
      and creates a new page with new grid layout
      The blocks in the new page will not have height
      assigned. The height of the blocks is updated
      on first load of the page in the browser.
      This can happen when editing the page or displaying it.
      - Copy a collection with old layout: creates the new collection
      with new grid layout pages. Each page needs to be loaded on the
      browser to update the block heights
      
      behatnotneeded
      
      Change-Id: I43b5f9050be192c057cb1803dcd69575c137a9cc
      f342e41b
    • Cecilia Vela Gurovic's avatar
      Bug 1813987: Translate old views to new gridstack layout on edit · 32de0b18
      Cecilia Vela Gurovic authored
      Old layout pages will be displayed as they were
      with the old layout.
      
      New pages are created with the new grid layout.
      
      If we try to edit a page with an old layout,
      the page will be translated into the new grid layout.
      
      To translate from an old layout to a new grid layout,
      we respect the row, column and order of blocks inside each cell.
      
      All blocks in the same row in old layout will be together
      in the new layout, and the first block of each column
      of the same row are displayed at the same level to each other
      in the new layout.
      
      The blocks will respect the column order
      they had in the old layout.
      
      A column of the old layout can have many blocks. In the
      new grid layout they respect the same order they had.
      
      As we have 12 columns in the new grid layout,
      the blocks that where included in a 5 column row,
      will be displayed in smaller columns in the new layout.
      
      TODO:
      confirmation before trnaslating a page to the new grid layout
      
      behatnotneeded
      
      Change-Id: I46f5cdbacb026519631503437c10d33f1b2800e5
      32de0b18
    • Cecilia Vela Gurovic's avatar
      Bug 1813987: block resizing to fit content · 565776fb
      Cecilia Vela Gurovic authored
      should not resize blocks in view mode
      
      in view mode, if the content of the block is static,
      then the block dimensions should not change but the
      content of the block should be made smaller
      
      expand the height of a block only if the content is dynamic,
      like the 'Journal' block
      
      behatnotneeded
      
      Change-Id: Ie8183736580e7e592b24e36f4a16618b96a5bf4e
      565776fb