Skip to content
GitLab
Switch branch/tag
  1. 16 Nov, 2017 1 commit
    • Cecilia Vela Gurovic's avatar
      Bug 1572825: added Voki html filter for embed code · 207889a5
      Cecilia Vela Gurovic authored and Robert Lyon's avatar Robert Lyon committed 
      Added new html custom filter to allow
voki embed code with javascript tags.

issue with the creation/edition of blocks:

Voki embed code its a javascript code that loads
js functions from a remote file and makes a call to a
AC_Voki_Embed() function

parameters:

function AC_Voki_Embed (width, height, chsm, sc,
transparent, bgcolor, returnFlag, playerType)

The number of parameter makes the difference between
old and new voki code. The old one will have only 7,
the new one will have one more.

The new embed code will have playerType = 1
The function uses an XMLHttpRequest to obtain the
new embed code. When we are loading the page,
there is no problem. But when we are editing or
creating the block, the the connection with the object
gets lost and the embed code is never loaded.
Solution found: reload the page after editing or adding
a block with new voki code.

The old voki code can have
returnFlag = 1 will return a string with the code
returnFlag = 0 will load the embed code in the page (by default)
In this last case, after the function creates the embed code,
it will call document.write('embed code')
if we are loading a page with the embed code, we have no problem
but if we have the page already loaded and we are editing the block
or creating it, the document.write will replace all the html
with the embed code.
Solution found: change parameter of the function so it returns
the code instead, then manually add it in the correct place
of the html.

behatnotneeded

Change-Id: Ieed00b6c6887715b707b8123082a1312f3db1d9c
      207889a5
  3. 07 Nov, 2017 1 commit
  5. 31 Oct, 2017 1 commit
  7. 30 Oct, 2017 1 commit
    • Cecilia Vela Gurovic's avatar
      Bug 1660237: removed old mobile api · d7018426
      Cecilia Vela Gurovic authored and Robert Lyon's avatar Robert Lyon committed 
      removed code from htdocs/api/module/ files and replace it with a json reply error message.
removed the 'allowmobileuploads' config variable since it is only used by the old mobile api.
removed the 'mobileuploadtoken' values in usr_account_preferences since they are only used by old mobile api. The new mahara mobile uses external_tokens table to store its access tokens.

behatnotneeded

Change-Id: I02e94079fc83aa6a81534b70446f7e8ab2ebd7a4
      d7018426
  9. 29 Oct, 2017 3 commits
  11. 27 Oct, 2017 2 commits
    • Cecilia Vela Gurovic's avatar
      Security Bug 1701978: fix session cookie issues · d02855fc
      Cecilia Vela Gurovic authored 
      1. when a user logs in it clears any obsolete
   usr_session cookies for the user
2. recording the user-agent of the session
   and if it changes to prompt the user to
   login again
3. when self adding / editing email address(es)
   send 2 emails
	- one to the new email address asking user to confirm address
	- and one to the primary email address to alert user
	that a new email is being added to their account and
	if this is bad how to contact their admin about the problem.

behatnotneeded
Change-Id: Ia44b66cf831abd553b72aa8b1d58d2a2634863b8
      d02855fc
    • Robert Lyon's avatar
      Bug 1724113: Fixing sort order for Reports -> Groups · a8f8a82d
      Robert Lyon authored 
      

For the 3 columns that use elasticsearch
- group page comments
- shared pages
- shared page comments

behatnotneeded

Change-Id: Ib7ee64f958a0d9ddd7382e067f23fe2e62c7d207
Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      a8f8a82d
  13. 25 Oct, 2017 2 commits
  15. 24 Oct, 2017 2 commits
  17. 19 Oct, 2017 3 commits
  19. 18 Oct, 2017 1 commit
    • Robert Lyon's avatar
      Bug 1724113: Changes for reports · a5c930d8
      Robert Lyon authored 
      

This patch includes
- Allow the overview report to be the default report
- Fixed sorting of modified/visited columns for page activity report
- Fixed sorting for username in useractivity report
- Fixed total rows count for user activity
- Fixed collaboration report for institutions
- Fixed issues with the new columns in the groups report

Change-Id: I2269bb5610d238bc9786d04d4c2a9122c0a4ccfc
Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      a5c930d8
  21. 15 Oct, 2017 1 commit
  23. 12 Oct, 2017 2 commits
  25. 11 Oct, 2017 3 commits
  27. 10 Oct, 2017 1 commit
  29. 08 Oct, 2017 1 commit
  31. 29 Sep, 2017 3 commits
  33. 28 Sep, 2017 1 commit
  35. 26 Sep, 2017 2 commits
  37. 25 Sep, 2017 5 commits
  39. 24 Sep, 2017 1 commit
  41. 22 Sep, 2017 3 commits