1. 26 Jan, 2017 1 commit
  2. 31 Aug, 2016 1 commit
    • Aaron Wells's avatar
      Bug 1615280: More robust email validation · 1192c05d
      Aaron Wells authored
      Because all of our emails need to pass PHPMailer's
      validation method before they get sent (due to the way
      PHPMailer is written) it makes the most sense to use
      that for validation.
      
      Change-Id: I232ab9496ce8fc295a49625c999b48215305216c
      behatnotneeded: Covered by phpunit
      1192c05d
  3. 21 Mar, 2016 1 commit
    • Robert Lyon's avatar
      Bug 1539262: Removing unnecessary $smarty PAGEHEADING lines · e82c0fcb
      Robert Lyon authored
      
      
      As they are set to TITLE we can just assign TITLE to PAGEHEADING in
      the smarty function call.
      
      We can later override the PAGEHRADING with
      $smarty->assign('PAGEHEADING', string); if we need to.
      
      Have also updated a few files where TITLE was not defined.
      
      behatnotneeded - everything should work as before
      
      Change-Id: I3ea592cd37344e68c6e90a3c64947cf99db59471
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      e82c0fcb
  4. 09 Dec, 2015 1 commit
  5. 19 Oct, 2015 1 commit
  6. 16 Oct, 2015 1 commit
  7. 30 Sep, 2015 1 commit
  8. 20 Sep, 2015 1 commit
  9. 08 Sep, 2015 1 commit
  10. 08 Aug, 2015 1 commit
  11. 30 Jul, 2015 1 commit
  12. 07 Jul, 2015 1 commit
  13. 15 Jun, 2015 2 commits
  14. 23 Apr, 2015 1 commit
    • Nigel Cunningham's avatar
      (Bug785472) Remove unneeded raise_memory_limit calls · 039564a5
      Nigel Cunningham authored
      
      
      On the basis of my profiling and testing over the last week,
      all of the scripts affected by this patch don't need their
      raise_memory_limit calls. Ensure_sanity currently sets the
      memory limit to 128MB, which has been seen to be more than
      sufficient for each of these use cases.
      
      Tests have involved at least 1000 records being imported in
      each case, and sometimes as many as 20,000. I would have
      liked to have tested with some really full profiles (eg
      lots of pictures and content), but am satisfied that there's
      enough margin to cover those cases. In any case, such files
      are often handled using external apps and therefore won't
      be counted toward PHP's memory use anyway. Finally, the
      limit can easily be increased by the user if necessary for
      a particular case.
      
      Change-Id: Ifecc83fd47da51268bae6cbd6960735eb91f9403
      Signed-off-by: default avatarNigel Cunningham <nigelc@catalyst-au.net>
      039564a5
  15. 03 Mar, 2015 1 commit
    • Nigel Cunningham's avatar
      (Bug1352028) Add a JSON progress bar for bulk operations. · 55a8deb8
      Nigel Cunningham authored
      
      
      This patch adds a JSON progress meter (I'll call it that to avoid confusion
      with progress bars) to the bulk uploading of users, groups and group
      memberships and the bulk export and import of users (LEAP), so the user can see
      the progress of the operation and not just the submit button changed to
      'Processing..' and whatever indication their browser gives while waiting for
      content.
      
      The bulk export and import are minor rewrites, replacing the old iframe based
      progress bar and the associated multiple pages and additional template file in
      the case of the bulk export, and the recursive redirect-to-self of the bulk
      import.
      
      To accomplish the display of the progress bar during the operation, we make the
      PHP session be closed (read only) except when changes need to be made. This is
      for the most part a straightforward change in session.php as it's the only
      direct accessor. In other places, we replace direct accessing of the session
      variable ($_SESSION) with use of the session class ($SESSION) so that it can
      reopen the session, make the change and close the session again.
      
      There is one more aspect to all of this: with previous behaviour, multiple
      requests for the same session would queue, taking the session lock in turn.
      After this patch is applied, they can proceed in parallel, allowing greater
      throughput. There is no additional locking requirement because the issues are
      the same as those already dealt with in allowing multiple PHP threads to
      process requests from different sessions at the same time.
      
      I have sought to make the progress meter nice and generic, so it can be used in
      the other bulk imports and exports too.
      
      Paradoxically, these changes don't just make the import seem to be faster, it
      actually is.. at least in the case of users and groups.
      
      Times for importing 1000 users, groups and memberships, averaged over 3 runs
      each (Wall time, not CPU time - but the relationship is the same).
      
                      Without Progress     With Progress
      Users                166s               155s
      Groups                85s                78s
      Memberships           20s                19s
      
      Change-Id: Iec15c57db32c77994edb80c71d65591de51a95e4
      Signed-off-by: default avatarNigel Cunningham <nigelc@catalyst-au.net>
      55a8deb8
  16. 09 Feb, 2015 1 commit
  17. 04 Dec, 2014 1 commit
  18. 24 Sep, 2014 2 commits
  19. 22 Sep, 2014 1 commit
  20. 22 Aug, 2014 1 commit
    • Robert Lyon's avatar
      Removed maildisabled and authinstnace options from list (Bug #1352027) · 6b4e9f6a
      Robert Lyon authored
      
      
      The way that bulk user csv upload works the authinstance is set for
      all users on the csv via institution field in the upload form so we
      don't need that column in the csv file.
      
      Same with mail disabled - there is a checkbox on the form that we can
      tick/untick to deal with that.
      
      So I've got the system to not display those options on the choices list.
      
      Change-Id: Ib2b3e2f19ee0f8aeed03c7dc04af076721ce8b41
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      6b4e9f6a
  21. 04 Jun, 2014 1 commit
  22. 25 May, 2014 1 commit
  23. 19 Nov, 2013 1 commit
  24. 14 Oct, 2013 1 commit
  25. 17 Apr, 2013 1 commit
  26. 16 Nov, 2012 1 commit
  27. 05 Apr, 2012 1 commit
  28. 03 Apr, 2012 1 commit
  29. 29 Mar, 2012 1 commit
    • Richard Mansfield's avatar
      Fix get_string calls for duplicate remote username message (bug #968697) · 938fa7db
      Richard Mansfield authored
      
      
      When uploading users from a csv file, the remote usernames given in
      the file are checked for duplicates.  When a duplicate is found,
      get_string is called to generate the error message using the string
      key 'uploadcsverrorremoteusertaken', but in two of three instances, it
      is called with too few arguments to sprintf.  Sometimes this results
      in no error being reported to the user at all.
      
      The error is fixed here by creating a new string without the second
      argument for the first call, and by passing the additional argument in
      the second call.
      
      Change-Id: Iff93385dee206394c74b1d6b1ad9484e90026dd4
      Signed-off-by: default avatarRichard Mansfield <richard.mansfield@catalyst.net.nz>
      938fa7db
  30. 19 Feb, 2012 1 commit
  31. 17 Feb, 2012 1 commit
  32. 13 Feb, 2012 1 commit
    • Richard Mansfield's avatar
      Add a maximum number of users for csv files (bug #823048) · 7f231697
      Richard Mansfield authored
      
      
      This allows $cfg->maxusercsvlines to be specified in config.php to
      stop admins and institutional admins from uploading large csv files.
      This is potentially useful on large multi-user sites.
      
      And until such time as we can reduce the amount of memory used by the
      create_user function, setting this option will provide the user with
      some feedback on csv upload failure (because we can't easily trap the
      php out-of-memory error).
      
      See also bug #548042.
      
      This commit also adds a call to set_time_limit() after processing each
      user, so that the script doesn't fail due to php's max. execution
      time.
      
      Change-Id: I662231288c7d0c6e70602c548123f12c63427a97
      Signed-off-by: default avatarRichard Mansfield <richard.mansfield@catalyst.net.nz>
      7f231697
  33. 30 Sep, 2011 1 commit
  34. 09 Aug, 2011 1 commit
  35. 20 Jul, 2011 1 commit
    • Piers Harding's avatar
      Enable multiple auth_remote_user connections · 34ebbfe4
      Piers Harding authored
      
      
      Bug #810302
      
      Enable links to multiple auth instances to be maintained so that
      users can have dual login eg: internal + auth/saml etc.
      
      Improve validation around switching auth_instance and
      changing the remoteuser at the same time.
      
      Add checks to ensure remoteuser does not get clobbered by update
      for another user.  Allow override for the CVS upload case (file == unit
      of update).
      
      Change-Id: I5321c0270aeaa93bd193e8e759b08ab7f8b50ded
      Signed-off-by: default avatarPiers Harding <piers@catalyst.net.nz>
      34ebbfe4
  36. 12 Jul, 2011 1 commit
  37. 30 Jun, 2011 1 commit
  38. 27 Jun, 2011 1 commit