GitLab

Bug 1399464: $values param must be an array

Change-Id: Ia865e42641830400fffeb3950f6cbe4fbed7ccbb
Signed-off-by: Son Nguyen <son.nguyen@catalyst.net.nz>

For some zip files for some users the mimetype is being interpreted as
"application/x-zip" (note the quotes are part of the string) so this
fails to map to the valid zip types and so the zip file is not
extracted.

So have trimmed the quote off the string

Change-Id: Ia58e3c3aa9a734172543b8c71ecab10a8f313b82
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

1) When adding a user via admin/users/edit.php page
2) When self-registering

Also got places where we check institution isFull() to send out an
email to the institution admins to alert them of this problem.

Change-Id: I70a1025651a6e093c51e99bbcbce781c72d7f890
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

To allow for systems where the installation takes longer than their
phpini max_execution_time setting.

Made the changing of the limit pass thru a function for sanity checking

Change-Id: I0d27d68a377c338c634f2f845829682af149d79f
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

- have updated copyright for the pages that had existing copyright
notices (except for the lib/pieforms/ section as i'm not too sure if
that needs changing as it is a different Catalyst IT product)

Change-Id: I11c65ad26cb9cd856cf16b1dccbd4223ba086645
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
Signed-off-by: Aaron Wells <aaronw@catalyst.net.nz>

- when the importing of a too big leap2a file the form error message
was wrong

- have got it to give the 'file too big' message

Change-Id: Ied2770b057a4fd7c51cc71db98e43808139b5985
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

The auth_remote_user db table was not being updated correctly when
users were being moved from one auth method to another in bulk.
Fix adds in the correct lines to that table. Code similar to what
is used in admin/users/edit.php for single user update.

Moved some things around to improve performance and fixed a mistake
Used a better way to check authname

Change-Id: Ieb2d453bc06646444aadaff92ea5b42af4246411
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

The password should not be displayed in
plaintext. I changed the type of the input
field to "password" to account for that.

Change-Id: I5d64470291e1c81b31bc0aaeb8cd65d809412ae7
Signed-off-by: Kristina D.C. Hoeppner <kristina@catalyst.net.nz>

"File quota" should not have MB added to it because
usually we have a dropdown which can show the quota in
B, KB, MB, GB.

Change-Id: Ia34e2795373c55881856204d2b61d54bc97150fb
Signed-off-by: Kristina D.C. Hoeppner <kristina@catalyst.net.nz>

This will standardize the way that Mahara sanitizes these personal
details.

PHPMailer is no longer necessary since in PHP 5.2, it's just a
call to filter_var().

Change-Id: I151fe4f91c9731cfa24b5a6e9d0cebeabfcd1a77
Signed-off-by: Francois Marier <francois@catalyst.net.nz>

Moving password encryption into create_user() (bug #799594) broke
new account emails for new Leap2a imported users, because Leap2a
users are reloaded from the database before the email is sent.

Change-Id: I9b9e65b0cd92261b1b81179a3828ee644fb82785
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

Bug #806777

General account options/settings added to functionality for manually adding a
single user, as well as adding users via CSV.

These are exactly the same settings as found in the 'General account options'
section on the Settings page.

Change-Id: I4fa5b50a588abc4747098f6dce186f600f73097f
Signed-off-by: Eugene Venter <eugene@catalyst.net.nz>

When institutional admins try to add/edit users,
the default quota value passed in the form was a string
ie. 50MB

This fix changes it so that if institutionaloverride is disabled
and the user is not a site admin, then don't set the quota

Change-Id: Idc1607dac992fe3a0bde8996659f90441d1c4753
Signed-off-by: Hugh Davenport <hugh@catalyst.net.nz>

Change-Id: I9783aab92858cf1827609497d026aebd30cad36e
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

Change-Id: I83c4ba70d69724bca120bbd757732fb34a23192e
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

Also add in default quota for each institution

Change-Id: Ibfdd5a10990e9c6a936b9ad5921f734df1f5c805
Signed-off-by: Hugh Davenport <hugh@catalyst.net.nz>

Bug #783695

Change-Id: I233e4e15e14f5673bd183c4602f1380219628ab8
Signed-off-by: Hugh Davenport <hugh@catalyst.net.nz>

These closing tags are unnecessary and against our coding
guidelines. Let's get rid of them all in one go.

Change-Id: Ia94f103e525185597ee3780a3839d7577cdd0c29
Signed-off-by: Francois Marier <francois@catalyst.net.nz>

The admin page did not verify the username before submitting the form
This change adds in the verification of the form.

Bug #776887

Change-Id: I22b221b951eec5a0b697c9a0c38f153b1b8721b7
Signed-off-by: Hugh Davenport <hugh@catalyst.net.nz>

* encrypt passwords on user add, edit and imports
* upgrade to encrypt and add salt to all existing cleartext passwords
* update validate_password to prevent successful validation of cleartext passwords with no salt
Signed-off-by: Eugene Venter <eugene@catalyst.net.nz>

defaultvalue = 1 in institution select only works for site admin.
Signed-off-by: Ruslan Kabalin <ruslan.kabalin@luns.net.uk>

Signed-off-by: Richard Mansfield <richardm@catalyst.net.nz>

Signed-off-by: Richard Mansfield <richardm@catalyst.net.nz>

The Leap2A specification has rebranded and thus we should reflect that
change in the next Mahara release.

I also updated a few URLs.
Signed-off-by: Francois Marier <francois@catalyst.net.nz>

File import plugin vs Leap import plugin
Local file upload import vs Imports over mnet
Signed-off-by: Penny Leach <penny@mjollnir.org>

- Breaking up of the validation into two stages:
    - Performed by the importtransport object, before moving files
      around
    - Performed by the import class, after the files are transported

To this end I changed the importtransport objects to take the
importqueue record (or a fake one) in their constructor, so they have
the same data available as the importer would.
Signed-off-by: Penny Leach <penny@mjollnir.org>

This commit includes:

- Moved a lot of logic out of admin/users/add.php to the various plugins
- Moved around unzipping and detecting files into the transport layers
- Refactored a lot of transport code into the base class

I tested:

- Adding a user from a leap2a xml file
- Adding a user from a leap2a zip file
- Importing non leap (straight files) data over mnet
Signed-off-by: Penny Leach <penny@mjollnir.org>

Signed-off-by: Richard Mansfield <richardm@catalyst.net.nz>

Accept application/x-zip-compressed mime type (and others) for user imports (bug #514069). Thanks to Mitsuhiro Yoshida.
Signed-off-by: Richard Mansfield <richardm@catalyst.net.nz>

Signed-off-by: Andrew Robert Nicols <andrew.nicols@luns.net.uk>

Still some minor things to clean up, but it works reasonably well.

I experimented with a horizontal UI.. I think it would be better if a
graphic designer could make it more obvious that it's a 1-2-3 process.
But everyone I've tried it on has managed to create a user account.

Still todo:
 - progress indication for when a leap2a file is uploaded
 - some minor tweaks to the way some data is imported
 - needs documentation on the wiki and a help icon or two
Signed-off-by: Nigel McNie <nigel@catalyst.net.nz>

Side effect of the performance work done previously.