1. 09 Sep, 2018 2 commits
  2. 31 Aug, 2018 1 commit
  3. 25 Mar, 2018 2 commits
  4. 14 Nov, 2017 1 commit
  5. 09 Jan, 2017 1 commit
  6. 19 Sep, 2016 1 commit
  7. 07 Jul, 2016 1 commit
    • Robert Lyon's avatar
      Bug 1234615: Check that resized image files are viewable by user · aa31ba59
      Robert Lyon authored
      
      
      When exporting via Html export process - if not then ignore the file
      
      To test:
      
      1) Add an image block/file to a page and set a width value
      
      2) Go into db block_instance table and change the artefactid to an
      image that is owned by another user
      
      3) Reload the page - you should see the image block but not the
      attached image
      
      4) Export the page as HTML, either as full or standalone
      
      Before patch - you will end up with image file in the files/extra/
      directory
      
      After patch - you should not get the image in the files/extra/
      directory and you should get an info warning 'Unable to copy artefact
      file ***' on export page.
      
      behatnotneeded
      
      Change-Id: Iaeb9404b3329c4eb3eac59354801b598f7cd5ba8
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      aa31ba59
  8. 26 May, 2016 1 commit
  9. 31 Mar, 2016 1 commit
  10. 21 Mar, 2016 1 commit
    • Robert Lyon's avatar
      Bug 1539262: Removing unnecessary $smarty PAGEHEADING lines · e82c0fcb
      Robert Lyon authored
      
      
      As they are set to TITLE we can just assign TITLE to PAGEHEADING in
      the smarty function call.
      
      We can later override the PAGEHRADING with
      $smarty->assign('PAGEHEADING', string); if we need to.
      
      Have also updated a few files where TITLE was not defined.
      
      behatnotneeded - everything should work as before
      
      Change-Id: I3ea592cd37344e68c6e90a3c64947cf99db59471
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      e82c0fcb
  11. 09 Dec, 2015 1 commit
    • Aaron Wells's avatar
      Updating outdated links in the Mahara source code · 4c046f3d
      Aaron Wells authored
      Bug 1523499: Old wiki.mahara.org links without the "/wiki",
      and HTTP links that should be HTTPS.
      
      Also updated the installer release notes link to point to
      the base "Release_Notes" page in the wiki, because we no
      longer maintain separate wiki pages for each release.
      
      behatnotneeded: Covered by existing tests
      
      Change-Id: I02e80eb4d8df5adddee88e77156e8e103ca24c51
      4c046f3d
  12. 25 Nov, 2015 2 commits
  13. 23 Nov, 2015 1 commit
  14. 02 Nov, 2015 1 commit
  15. 07 Oct, 2015 1 commit
  16. 20 Sep, 2015 1 commit
  17. 24 Aug, 2015 1 commit
  18. 10 Aug, 2015 1 commit
  19. 08 Aug, 2015 1 commit
  20. 06 Aug, 2015 1 commit
  21. 30 Jul, 2015 1 commit
  22. 16 Jul, 2015 1 commit
  23. 15 Jul, 2015 1 commit
  24. 23 Jun, 2015 1 commit
  25. 16 Jun, 2015 1 commit
  26. 15 Jun, 2015 3 commits
  27. 29 May, 2015 1 commit
  28. 24 May, 2015 1 commit
  29. 15 Apr, 2015 1 commit
  30. 31 Mar, 2015 1 commit
  31. 10 Mar, 2015 1 commit
  32. 03 Mar, 2015 1 commit
    • Nigel Cunningham's avatar
      (Bug1352028) Add a JSON progress bar for bulk operations. · 55a8deb8
      Nigel Cunningham authored
      
      
      This patch adds a JSON progress meter (I'll call it that to avoid confusion
      with progress bars) to the bulk uploading of users, groups and group
      memberships and the bulk export and import of users (LEAP), so the user can see
      the progress of the operation and not just the submit button changed to
      'Processing..' and whatever indication their browser gives while waiting for
      content.
      
      The bulk export and import are minor rewrites, replacing the old iframe based
      progress bar and the associated multiple pages and additional template file in
      the case of the bulk export, and the recursive redirect-to-self of the bulk
      import.
      
      To accomplish the display of the progress bar during the operation, we make the
      PHP session be closed (read only) except when changes need to be made. This is
      for the most part a straightforward change in session.php as it's the only
      direct accessor. In other places, we replace direct accessing of the session
      variable ($_SESSION) with use of the session class ($SESSION) so that it can
      reopen the session, make the change and close the session again.
      
      There is one more aspect to all of this: with previous behaviour, multiple
      requests for the same session would queue, taking the session lock in turn.
      After this patch is applied, they can proceed in parallel, allowing greater
      throughput. There is no additional locking requirement because the issues are
      the same as those already dealt with in allowing multiple PHP threads to
      process requests from different sessions at the same time.
      
      I have sought to make the progress meter nice and generic, so it can be used in
      the other bulk imports and exports too.
      
      Paradoxically, these changes don't just make the import seem to be faster, it
      actually is.. at least in the case of users and groups.
      
      Times for importing 1000 users, groups and memberships, averaged over 3 runs
      each (Wall time, not CPU time - but the relationship is the same).
      
                      Without Progress     With Progress
      Users                166s               155s
      Groups                85s                78s
      Memberships           20s                19s
      
      Change-Id: Iec15c57db32c77994edb80c71d65591de51a95e4
      Signed-off-by: default avatarNigel Cunningham <nigelc@catalyst-au.net>
      55a8deb8
  33. 25 Feb, 2015 1 commit
  34. 24 Feb, 2015 1 commit
  35. 12 Feb, 2015 1 commit
    • Nigel Cunningham's avatar
      (Bug1364691) Add artefact_instances_from_ids function. · ccd5e53d
      Nigel Cunningham authored
      
      
      Add support for getting multiple artefacts from an array
      of IDs, all at once. The main saving is that we then do
      one SQL query for the whole array instead of one for each
      element in the array.
      
      In testing admin/users/bulkexport.php, this reduced
      execution time for an export of 1000 users by 12 seconds
      (approx 10 percent).
      
      Change-Id: I51867cd4693a7572dd609b98b6503251e473078a
      Signed-off-by: default avatarNigel Cunningham <nigelc@catalyst-au.net>
      ccd5e53d