- Add new method PluginBlocktype::rewrite_blockinstance_extra_config()
which enables blocktype to rewrite extra configuration when copying
block

- Implement rewrite_blockinstance_extra_config() for
PluginBlocktypeText to rewrite embedded image urls in the text block

- Rename the method rewrite_artefact_ids() to
rewrite_blockinstance_config() and add new code to allow blocktype
plugins rewrite extra config when import

- Add new method
PluginBlocktype::import_rewrite_blockinstance_extra_config_leap()

- Implement
PluginBlocktypeText::import_rewrite_blockinstance_extra_config_leap() to
rewrite embedded image urls in configdata['text']

Change-Id: Id5163817c676fb118edea02d152b7797111cb99f

Bug 1415711

Change-Id: Ia8ec1085df32cf7453ac0f669dca1a926f8f5efc

The wall post form fails to work when block loaded via ajax

Change-Id: Ic0414ab7b69ee821815162b749217cb377950d20
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

I've taken what aceMa provided in bug report and made it a replacement
for the square thumbs option rather than a new option as we don't need
two square thumb options.

I've tweaked it a bit more and hopefully have got the padding/ratio
stuff more consistent and not using hardcoded numbers so much

And getting it to show descriptions/captions below frame

Change-Id: Iafc0ec8a8132d1bef5401b3ebd49e3df013fddc3
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Using the path column to avoid recursive queries

Change-Id: I51eab6ce248c5f0d199487d85d9a56f8ffa3e001

This will update
 - the block content which have links to these embedded images
 - the tables 'artefact_file_embedded' and 'view_artefact' in database

Change-Id: I7b97e0828fd89609f9bd43e786c5ff5ad3e53156
Signed-off-by: Son Nguyen <son.nguyen@catalyst.net.nz>

Change-Id: I9c615da0e7efad927a42874676e1e6cde777c61f

Change-Id: I4536536d254d9dc85c9eb8405bd6ab61c0ae26e9
Signed-off-by: Yuliya Bozhko <yuliya.bozhko@totaralms.com>

As we add the date/time of the archive to the file name there is no
need to put it in a subdir named by date/time.

Change-Id: I8446c5f410e8502e4ab97802da0438ff428e0c32
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Bug 1422498

Change-Id: I3eec78722856eaac9d492cf93eaff7f39520ce94

Change-Id: Ia8fd368cec87709f14609c5aeb8259d88feeefab
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Change-Id: Id3082b1fc0a4e792342763fdb8e7c82708e00f74

Bug 1390833

This will update all attachments to the artefact

Change-Id: Idc06d5ce35b2427575b44d53f4aa56dfc7b01cf8
Signed-off-by: Son Nguyen <son.nguyen@catalyst.net.nz>

Bug 1424817

Change-Id: I83aa04d6a5f63a7b1dbc102eb6d2060afc5cf447
Signed-off-by: Son Nguyen <son.nguyen@catalyst.net.nz>

Change-Id: I573e6f354a2077afbaed5a501d2d99106b736e1a
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Allowing each of the 'classname' classes listed in external_functions
to be it's own function file to make it easier for developers.

Change-Id: I9c4e3dfc198abdf2c274c8a7d569fce5bf431471
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

To manage this I've created the ability for a fieldset to render a
multicolumntable structure for that fieldset only.

Change-Id: I0c72cbbbe612e5808e0d37e0dfdbe12e6681c8d2
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Bug 1410638. Currently, a theme that specifies no $theme->parent
in its themeconfig.php is forced to use "raw" as its parent.
With this patch, there are three options:

1. $theme->parent = false; : No parent theme.
2. $theme->parent = "sometheme"; : Sometheme is the parent
3. $theme->parent not defined at all: "raw" is the parent

Change-Id: Ibfeeae246b0f505b5759ee77eeed32467c464cab

Comment code for checking system load on Windows OS
This function returns false if server is running Windows

Change-Id: Ic3883a25f6a79d824a128f076c550f1b06bda195
Signed-off-by: Son Nguyen <son.nguyen@catalyst.net.nz>

Change-Id: Iae93bea337403bc71994ae0505985ebdddc9a44e
Signed-off-by: Yuliya Bozhko <yuliya.bozhko@totaralms.com>

This reverts commit 63896cc8.

It's no longer necessary to update these URLs, because
commit 0de9fa76 makes the old-style URLs redirect to the
new-style URLs. And since this rewrite will be a lengthy
operation on large sites, and could potentially cause
problems with URLs for other domain names that happen to
contain "view/artefact.php", we should just remove this
upgrade section.

Change-Id: Ic981f739d6ac5e76efe8116531fc365947ebf286

Daniel Parejo authored Feb 17, 2015 and Robert Lyon committed Feb 17, 2015

Patch originally submitted by Daniel Parejo in bug report

Change-Id: I33d3d9c6ff12c69ef871de47fe15524659ceba36
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

(Bug #1408473)

Change-Id: Ic290e4b9a17ff192334cbd6bef3b9f3b433ec702

Bug 1413547

Change-Id: I8651c35de876ff4c5ddd686792d0a0ccf5195bcf

Brian King authored Feb 13, 2015 and Aaron Wells committed Feb 13, 2015

Bug 1414628: The "tm_yday" (day of the year) param is not supplied by
strptime by default on BSD systems such as Mac OS X.
It works just as well to use "tm_mday" (day of the month) param instead,
and it also makes more sense!

Change-Id: I1484dcde4dbd8199f578a4eb5a58a9f78de45635

Bug 1421444

Change-Id: I9bfc571d55a2916f89bdef980b5db316715530e1

Needed to use a temp table as update and select are from same table

Change-Id: Idddf6048b2f6cf6cff2fadad87b8703a56a7a8d5
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Bug 1236102: In commit 5b7b2927, a bad rebase resulted in
additional changes to lib/db/upgrade.php being committed, beyond
those actually needed for the patch.

Change-Id: I3d22ea01f17ded7a4304b2fa8eb74cc48e317002

This is on the page edit screen

Change-Id: I1e96837c2292cbf9fb6c44bcb291bf722b079329
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Time of indexing reduces from 2 hours to 23m on my dev machine after
applying this patch

Change-Id: Ia827a0c3945509e388da516109397a3db6e29eca
Signed-off-by: Son Nguyen <son.nguyen@catalyst.net.nz>

The configure dialog for blocks is currently set to a fixed width via
Javascript, but there is no handler for browser resizing and it results in the
dialogue being very wide for the sake of just one line when a license agreement
is enabled.

Fix this issue by making all dimensions percentages, and using a combination of
max-width: 90% and width: max-content. In addition, make the dialog fixed
position with its own scrollbars as needed (the body's scrollbar is disabled
when the dialog is shown).

Contextual help's width code and CSS is also adjusted so that it wraps within
dialog boxes rather than pushing the width out.

Change-Id: If2a40739f1510cedcf9a6133ccfb8f0a18257356

Now that we've added so many options to this block, it's starting
to get hard to read. Changing the radio buttons into menus makes
it a little bit easier.

Bug 1417357

Change-Id: I0e3a08f6f29e2c4b20d378a5b0118771197824f8

Aaron Wells authored Feb 03, 2015 and Robert Lyon committed Feb 11, 2015

Bug 1417362: Since it tends to be unwieldy to update block configdata
en masse, I've only merged the control, and I keep the retractonload
and rectrable settings separate in block_instance.configdata.

Change-Id: I56eaef5a161b0319b686ab222578538ab62e7873

Change-Id: Iba8140a1a5a642bf1821be7e74219642f25fa881

Nigel Cunningham authored Sep 24, 2014 and Robert Lyon committed Feb 10, 2015

Fix the handling of disabling a plugin when we find that the files
for a module are missing.

Change-Id: I706a9c4fd3c86fb1a0e330bb77c40d5e6d888a52
Signed-off-by: Nigel Cunningham <nigelc@catalyst-au.net>

Nigel Cunningham authored Aug 06, 2014 and Robert Lyon committed Feb 09, 2015

Avoid the query for an existing artefact record when we know it doesn't
exist (because we're being called from create_user). This shaves
approximately 40% off the time for creating a user.

Change-Id: I81697dfd0916e4a2933dfe5d1389bdc649e6e856
Signed-off-by: Nigel Cunningham <nigelc@catalyst-au.net>

Nigel Cunningham authored Jul 28, 2014 and Robert Lyon committed Feb 09, 2015

This patch optimises the validation function by getting a list
of known email addresses and usernames prior to entering the
validation loop.

Test runs with 2000 preexisting users using XHProf showed a
reduction in execution time from 6.5 seconds to 3.8 seconds,
with an increase in memory use of approximately 1.3MB.

Change-Id: I099f1e3b7d459538b79b78afce271f582ec4a24c
Signed-off-by: Nigel Cunningham <nigelc@catalyst-au.net>

After installation or upgrade, if the user clicks on a warning
about the no-reply email address and they also need to set up
required fields, the URL for the no-reply email address is
initially overridden by the required fields form. This patch
causes us to cleanly drop back out of the required fields form
code after the required fields form is successfully submitted,
letting the user then see the no-reply email address form.

This method of handling things will also work for any other
time the required fields form hijacks a URL - after the required
fields are set, the user will get the page they asked for.

Change-Id: I32aecaf898d02a572a5ab7b5c18bfaefc5607e41
Signed-off-by: Nigel Cunningham <nigelc@catalyst-au.net>

Bug 1419547

Change-Id: I2419b6443ad66992ca40d47263690c62ad5d9576