1. 27 Mar, 2019 1 commit
  2. 26 Feb, 2019 5 commits
  3. 13 Feb, 2019 1 commit
  4. 27 Oct, 2016 1 commit
  5. 20 Mar, 2016 1 commit
    • Robert Lyon's avatar
      Bug 1544381: Need to move get_homepage_url() out of template · 3df10959
      Robert Lyon authored
      
      
      Because if we have a latest pages block but no group pages listed then
      the template will not initially compile as there has been no call to
      require lib/group.php
      
      Actually we should avoid having non basic function calls in the template
      so I'll move all instances of group_homepage_url() in templates out
      to the php that generates the data.
      
      behatnotneeded
      
      Change-Id: Ia804fee854418e7b3b3620c998f2219a0b0d6f25
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      3df10959
  6. 08 Feb, 2016 1 commit
  7. 16 Dec, 2015 2 commits
  8. 27 Oct, 2015 1 commit
  9. 22 Oct, 2015 1 commit
  10. 19 Oct, 2015 2 commits
  11. 15 Jun, 2015 9 commits
  12. 12 Sep, 2014 1 commit
  13. 24 Jun, 2014 1 commit
  14. 27 May, 2014 1 commit
  15. 19 Feb, 2014 1 commit
  16. 30 Dec, 2013 1 commit
  17. 24 Jul, 2013 1 commit
  18. 19 Jul, 2013 1 commit
  19. 18 Jun, 2013 1 commit
    • Aaron Wells's avatar
      Making links to directory index.php files more explicit · 1c56a922
      Aaron Wells authored
      Bug #1150831: Some links to directory index.php files left off the
      trailing slash,
      i.e. "{$WWWROOT}/view". This caused unnecessary redirects and greater
      potential for
      errors in users' web server setups. While I was at it, for all links to
      directories
      other than $WWWROOT itself, I changed them to be explicitly links to
      "index.php".
      
      Also fixed the Windows-style line endings in homeinfo.tpl
      
      Fix all implicit links
      
      Change-Id: I87b285713e5cb1cfe785ceedd2702e5c2578058b
      1c56a922
  20. 29 Aug, 2012 1 commit
  21. 08 Jun, 2012 3 commits
    • Richard Mansfield's avatar
      Use clean urls in profile sideblock · 6c6c24e7
      Richard Mansfield authored
      
      
      Bug #1006634, part 3
      
      Only affects views that the owner has tagged 'profile'.
      
      Change-Id: Id4a6b641ab46e6cf105d9dbf295fb16f8d343987
      Signed-off-by: default avatarRichard Mansfield <richard.mansfield@catalyst.net.nz>
      6c6c24e7
    • Richard Mansfield's avatar
      Use profile_url when data is easy or inexpensive to fetch · 0d28fabc
      Richard Mansfield authored
      
      
      Bug #1006634, part 3
      
      In many places user urlids are not currently available when the
      profile url is generated, but it is trivial to get it, and then change
      the user/view.php url to a profile_url call:
      
      - Admin page access report
      - Profile links in feedback lists
      - My friends block
      - Wall posts
      - Group members block
      - Group members tab
      - Recent forum posts block
      - Group admin lists on forums page
      - Group admin lists on my groups, find groups
      - Group admin lists in group info block
      - Profile sideblock
      - My friends & find friends pages
      - Institution landing page
      - Online users page
      
      Change-Id: I33e122896982037a887aad8e3362db450e123e3f
      Signed-off-by: default avatarRichard Mansfield <richard.mansfield@catalyst.net.nz>
      0d28fabc
    • Richard Mansfield's avatar
      Use group_homepage_url when data is easy/inexpensive to fetch · ffb144ad
      Richard Mansfield authored
      
      
      Bug #1006634, part 3
      
      Replaces existing group/view.php urls with calls to
      group_homepage_url, in a bunch of places where only a minor change is
      required to fetch the urlid property, and where it is clear it will
      have little impact on performance:
      
      - My groups block
      - Cancel button on group delete
      - Redirects after joining a group or inviting a user
      - Group tab of the admin stats area
      - My groups section of the profile sideblock
      - Redirect after submitting a view
      
      Change-Id: I0ab970bdc4aaefe9fb912f9e530ebe1684aed011
      Signed-off-by: default avatarRichard Mansfield <richard.mansfield@catalyst.net.nz>
      ffb144ad
  22. 02 Feb, 2012 1 commit
    • Richard Mansfield's avatar
      Fix remote avatars broken by 'profileiconbyid' commit (bug #924777) · ab3b5a19
      Richard Mansfield authored
      Commit 011c5039 changed lot of thumb.php urls to use the
      type=profileiconbyid parameter (which takes an artefact id) rather
      than type=profileicon (which takes a user id, and which cannot be
      cached).
      
      Unfortunately, when a user has no locally stored profile icon, use of
      type=profileiconbyid stops their remote gravatar image from being
      displayed.
      
      This commit updates the thumb.php urls that were changed in commit
      011c5039 to use the profile_icon_url() function, which respects
      remote avatars when no local profileicon is available.
      
      In some cases this requires a new size of the no_userphoto.png image,
      so three new sizes are added in the raw theme.  The four no_userphoto
      images in the custom theme were duplicates of those in raw, and are
      removed.
      
      Finally, the type=profileiconbyid change from commit 011c5039
      
       in the
      viewacl.tpl template has been reverted back to type=profileicon.
      Because this url is constructed in javascript, it is not worth the
      trouble to use a profile_icon_url call here until the number of
      requests to thumb.php really becomes a problem.
      
      Change-Id: I7dce7090842999fe090dc2d8c481cb4aca7720d5
      Signed-off-by: default avatarRichard Mansfield <richard.mansfield@catalyst.net.nz>
      ab3b5a19
  23. 16 Jan, 2012 1 commit
    • Richard Mansfield's avatar
      Use type=profileiconbyid in more requests for thumb.php · 011c5039
      Richard Mansfield authored
      
      
      This can help to reduce the overall number of requests for thumb.php
      because the 'profileiconbyid' urls are cached for longer by the
      browser.
      
      (Where the profile_icon_url function can be used, we also avoid the
      need to generate additional requests for users without profileicons,
      when remote avatars are disabled.  But because profile_icon_url relies
      on the nouserphoto icon being available in the requested size, we
      can't use it everywhere until we either generate the nouserphoto icon
      in more sizes, or change all those pages to use standard sizes.)
      
      Change-Id: I81c5c5f4b7f9136bf9b6a6f711e55a4bceb6fa14
      Signed-off-by: default avatarRichard Mansfield <richard.mansfield@catalyst.net.nz>
      011c5039
  24. 17 Nov, 2011 1 commit