Checking for the datatypes returned, and catching exception caused
by a previous exception object getting passed to the database,
which adodb doesn't know what to do with, surprisingly enough.
Making use of try to better handle failing record updates.

Change-Id: I884021aca8d3cb416acab575151ed97d7d64d3ed
Signed-off-by: Melissa Draper <melissa@catalyst.net.nz>

http://www.sophos.com/en-us/rss/sophos-security-news.xml

 for example
is rather poorly constructed and just has closing title tags rather
than an actual title. This patch adds some fallback so that links
are actually clickable and not lost to the UI.

Change-Id: Ida3b61f3cf60ddaa5f4b96795cd43ee443c111e4
Signed-off-by: Melissa Draper <melissa@catalyst.net.nz>

It is currently possible for URLs in the rss parser to be
exploited with XSS. sanitize_url has been added to sanitize
RSS URL values before they are published.

Change-Id: Idacecbce0c3fc33dd2921df9b580acd1251929e6
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

Change-Id: Iab7aac11915b19d0c3e306949513dfc90e6a82c6
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

This is needed to avoid mixed secure and insecure content on the
views that use this block.

Bug #853647

Change-Id: I45b851b393ae4b3f9a44c2abc10019c673cd12cd
Signed-off-by: Francois Marier <francois@catalyst.net.nz>

Allow users to override certificate errors when adding an external
feed to a view.

This new option is turned OFF by default.

Bug #849831

Change-Id: I0e7baab0994bf5f27a6ad7fc5089dfc1b583d87c
Signed-off-by: Francois Marier <francois@catalyst.net.nz>

These new per-block options allow the use of authenticated (through
HTTP basic auth) feeds in Mahara.

Thanks to Darren James Harkness for the initial patch.

Change-Id: I8c916c31698ae3b32dd826d14fd475cbbad61b02
Signed-off-by: Francois Marier <francois@catalyst.net.nz>

Change-Id: I935c40be12aeab914f64a60b18b579dd2140ca23
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

There seems to be some kind of weird caching problems when using
feedburner feeds which I suspect might be related to how Feedburner
looks at the user agent of the client and returns different data
depending on the user agent.

Sending an empty user agent seems to work around these problems.

Change-Id: Iaa513d33bdae31f816b5c5046ed59deaf3b40b01
Signed-off-by: Francois Marier <francois@catalyst.net.nz>

The "External feeds" tab looked a bit empty with just the External
Feeds block. We now have enough blocks to make it worthwhile to
have a tab for them: externalvideo, externalfeed and googleapps.

Change-Id: I193240f6a16c0081625d2180599047ea5fcee00a
Signed-off-by: Francois Marier <francois@catalyst.net.nz>

These closing tags are unnecessary and against our coding
guidelines. Let's get rid of them all in one go.

Change-Id: Ia94f103e525185597ee3780a3839d7577cdd0c29
Signed-off-by: Francois Marier <francois@catalyst.net.nz>

Change-Id: I6c90e97b9a6cbb15f17fc10ee552f7a665d31913
Signed-off-by: Richard Mansfield <richard.mansfield@catalyst.net.nz>

To prefent form processing for long time, so user may think it got frozen
Signed-off-by: Ruslan Kabalin <ruslan.kabalin@luns.net.uk>

In order to be able to catch XML_Feed_Parser_Exception from methods that call
parse_feed method, corresponding library has to be included earlier.
Signed-off-by: Ruslan Kabalin <ruslan.kabalin@luns.net.uk>

Signed-off-by: Richard Mansfield <richardm@catalyst.net.nz>

Signed-off-by: Richard Mansfield <richardm@catalyst.net.nz>

Signed-off-by: Richard Mansfield <richardm@catalyst.net.nz>

Signed-off-by: Richard Mansfield <richardm@catalyst.net.nz>

Signed-off-by: Francois Marier <francois@catalyst.net.nz>

Signed-off-by: Richard Mansfield <richardm@catalyst.net.nz>

Signed-off-by: Evan Goldenberg <evang@catalyst.net.nz>

Signed-off-by: Richard Mansfield <richardm@catalyst.net.nz>

Signed-off-by: Richard Mansfield <richardm@catalyst.net.nz>

Signed-off-by: Richard Mansfield <richardm@catalyst.net.nz>

Prevents a horrible crash at import time.
Signed-off-by: Nigel McNie <nigel@catalyst.net.nz>

Signed-off-by: Nigel McNie <nigel@catalyst.net.nz>

Signed-off-by: Nigel McNie <nigel@catalyst.net.nz>

Signed-off-by: Nigel McNie <nigel@catalyst.net.nz>

Signed-off-by: Nigel McNie <nigel@catalyst.net.nz>

Now RSS blocks are being properly exported and imported. Only 19 more to
go!
Signed-off-by: Nigel McNie <nigel@catalyst.net.nz>

MySQL installs will fail if 2 RSS feeds with the first same 255 chars
are added but that's tough.
Postgres will be fine.

beginning of wall and another backwards compatibility break for blocktypes now we must pass $editing parameter to render_instance (default false)

This is kinda important if we want icons for rss feeds to work! :)

Conflicts:

	htdocs/blocktype/externalfeed/version.php