behatnotneeded

Change-Id: I0037ead6646e002c5cf96b43343f9aefc1a71754

behatnotneeded

Change-Id: Ic35bbc464ab2c9fa812d66e8e7adc5b71a6da7ba
Signed-off-by: Yuliya Bozhko <yuliya.bozhko@totaralearning.com>

As it causes problems on upgrade

behatnotneeded

Change-Id: Id330f8c31c763dffce6f559557c9c78ac27ac58f
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

for the case where user's firstname and lastname are empty
and can't be used to generate a username.

behatnotneeded

Change-Id: I71aeffbf4c9bbf7f46c09c54ea16d9ef8642ca5c

Cecilia Vela Gurovic authored Oct 03, 2017 and Robert Lyon committed Oct 31, 2017

removed code from htdocs/api/module/ files and replace it with a json reply error message.
removed the 'allowmobileuploads' config variable since it is only used by the old mobile api.
removed the 'mobileuploadtoken' values in usr_account_preferences since they are only used by old mobile api. The new mahara mobile uses external_tokens table to store its access tokens.

behatnotneeded

Change-Id: I02e94079fc83aa6a81534b70446f7e8ab2ebd7a4

behatnotneeded

Change-Id: I7963cd4e454722991683d69b76fb5d6487769bfc
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Dimitri authored Oct 19, 2017 and Cecilia Vela Gurovic committed Oct 24, 2017

behatnotneeded

Change-Id: Id1a1d1e99d58b9b2c3567ee36eebaeb70c9944e6

Due to missing column 'logoxs' as this column has not been added yet

behatnotneeded

Change-Id: Ie744485923c1566f10081ab98f16a1e2b08baf5a
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

This patch will contain the fixes for:

- Navigation placement
- Collaboration report
- CSV's of reports
- Overview page for the graphs
- Making Institution selector a select2 field
- Moving all configs for reports into the modal and combine 3rd level
menu with submenu choices in select2 field
- Ignore non logged in users from user activity report
- Move more variables for reports into sticky (session) vars
- Allow results to be fetched from elasticsearch

Change-Id: I725b7615ac3cd6b1d9b6352bae9f6be0d5161e1b
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Add 5 new new columns to event_log table make searching over the
data easier and also record the id of any parent/related info as well

Eg, if one deletes an image block from a page we now record:
id - the event id
resourceid - the block id
resourcetype - the blocktype, eg image
parentresourceid - the id of the parent, eg view id
parentresourcetype - the type of parent, eg 'view'

Because we would not be able to find related view info from just the
block id anymore.

Also added the ability to index and search over event information in
elasticsearch search type event_log

Change-Id: I280c1c75c35a6c58f42d8acb36cf5c24c70b902d
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded

Change-Id: I035644f81d46ade96bc9bcf7b37d176cb235405d

Cecilia Vela Gurovic authored May 24, 2017 and Robert Lyon committed Jun 29, 2017

behatnotneeded

Change-Id: Ic74144a55e7e3f8e82380b6d5394e258787e0471

	- user can search in tags, in title+decription
	  or in title+description+tags
	- the last type of search user chooses will be remembered
	- fixed search for the other options
	- fixed bug when there are same number of collections
	  and pages to display.

behatnotneeded

Change-Id: Ibd206d5ac211893b52b26b7be9582785cbad606e

Checks if the framework plugin is installed
before deleting trying to delete a record in
a framework table.

behatnotneeded

Change-Id: I1c4844066682e327c71bc22288d3b831521f6e25

Add in the new search by and order options

Change-Id: If0ab8397793a3aad3df4d7fa4e4a69ccd4b908b9

To allow us to easily turn of a 'bad' auth when it is trying to
connect to a third party server but that server is not reachable.

Currently it makes logging in slow as it needs to timeout on that auth
instance before trying the next one.

behatnotneeded

Change-Id: Ieeaeeaeb1bc0aa61ed3faad8f3bf751edd9c1023
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded

Change-Id: Id1c51f16e1d9503348600033b2804411ad03ec78
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

When we do an annotation feedback either by page or matrix

behatnotneeded

Change-Id: I6b874641cd260523cffd541c828dbec8a939c47b
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Created a new function get_raw_user_urlid() to fetch the correct string to
pass to generate_urlid()

behatnotneeded

Change-Id: I1901045ef8e89d224e1ab9556587224ff1d7e6a0
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

This fix deals with a better checking of the supplied url and making
sure it is validated on both the addbook form and editcomposite form

Also fixing the help message issues when on editcomposite.php page

behatnotneeded - existing tests should be ok

Change-Id: I8d9e26dcf71f6bc2b3953a5548c3426efb2d459b
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

It turns out a lot of existing code checks the boolean
value of usr.suspendedcusr to determine if a user should
be treated as suspended or not. The LDAP sync cron (and,
indeed, any code suspending users via a cron task) was
setting usr.suspendedcusr to 0, which is boolean false,
so these users would be treated as not suspended.

We are going to update all usr.suspendedcusr = 0
to a valid site admin ID.

Change-Id: Iecfbfd8a4cdd98d5d07149bb40c64308262ea234
behatnotneeded: Test to come later

Currently all the artefacts that save html/tinymce data do so in the
description field - except the internal profile introduction field.

Seen as we are already doing special handling of this plugin we might
as well save the html/tinymce data into the 'description' column of
the db for consistency sake.

behatnotneeded - existing tests should suffice

Change-Id: I68da79f1c9423e19218162d8315008134251c31f
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Evan Giles authored Jun 01, 2016 and Robert Lyon committed Jun 02, 2016

When a user chooses the 'name_display_format' of studentid
- we get an error.

This change just populates the studentid field of the user

behatnotneeded

Change-Id: I1e6a84723863e49dd94b83cb115f26262e6d9750

To speed up the system by avoiding too many curl_exec() calls

behatnotneeded

Change-Id: I8ac650cffbd70fb0756a6b0a426fe2f6e0ba97cf
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Made a centeralised function so that we can use 'viewsperpage' only
for the different pages lists. And have 'itemsperpage' for certain
admin lists.

behatnotneeded

Change-Id: Ie8b49bdc0d86ef49f66e9a1bf09799e6bc21484b
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Son Nguyen authored Dec 08, 2014 and Robert Lyon committed Apr 27, 2016

- Change ownership of default system templates
 from user 0 to institution 'mahara'
 and set template to 2
- Enable to add site files into site templates

behatnotneeded - existing tests for system templates are ok

Change-Id: Idfd5fca423e6f6a5f66d6cf944f7c5f88112584c
Signed-off-by: Son Nguyen <son.nguyen@catalyst.net.nz>

When deleting users

Change-Id: Ie94c0e2d045b84dd5e7f227e2d571fdedc5eae5e
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Robert Lyon authored Jan 27, 2016 and Aaron Wells committed Mar 16, 2016

As this is confusing debugging issues with view layout as the
view.numcolumns column is not actually used anymore for working
out the layout, but it's still being populated when a page is made.

behatnotneeded - existing tests will do

Change-Id: If90dff066201e7356601b08c9b7150cab8a77f45
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Change-Id: Ib0de08d1ed51baa1f5e58ec1b805eacf034bb541

To stop the text flowing out on smaller screens

behatnotneeded - design only change

Change-Id: I8b0a24ce339aa17f503ca9c84b68591bef05dae9
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Liam Sharpe authored Oct 28, 2015 and Robert Lyon committed Dec 16, 2015

behatnotneeded

Change-Id: I536f7d4ab8bd96d653e0ae3bba635437f0d2c17c

This is 2 of 6 patches to standardize pagination

behatnotneeded

Change-Id: I7741ae0d436d7e11fe248307936757d3d8027cc1
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded

Change-Id: I1aa52a076843ff0dc4dcaf86a01e76b9673885b5
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Suppress this for user if institution hasn't got around to updating
their theme.

Occurs when $cfg->sitethemeprefs is true and user is in an institution
with an old theme like 'ultima' and they go to their settings page.

Change-Id: I6289da0777b1964cabc8f933478f90ae22569af8
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Pat Kira authored Oct 08, 2015 and Robert Lyon committed Oct 19, 2015

behatnotneeded: styling only

Change-Id: Ie47b903e93816c7bac53437bdbb3842020a0effe

In user account settings page

behatnotneeded

Change-Id: I9eb8f345054ece362635cf93f6455a0dc55dbe63
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

- Remove radio separator

behatnotneeded: styling only

Change-Id: I5d45e80b91edecafca21a91ca606cd6ea06f259f

Jen Zajac authored Sep 16, 2015 and Robert Lyon committed Sep 21, 2015

  behatnotneeded

  Bug #1465107

Change-Id: I27492cbc38416fd4790e1e62ec8090c19602d171

Kevin Rickis authored Aug 24, 2015 and Robert Lyon committed Sep 03, 2015

Ends up with username in auth_remote_user being different to the
username in usr table.

behatnotneeded

Change-Id: If6a5a18360ef82da2e3a709899e7d4d1624e8fab
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Added a tab 'Logins' to site statistics page that contains
how many total logins for an institution and also how many unique
users have logged in during a certain time period - defaults to
previous calendar month

One can get different results by adjusting the url like so
admin/statistics.php?type=logins&start=2014-01-01&end=2015-01-01
if needing to get a different time period

On upgrade it populates the usr_login_data table with the current
lastlogin time for non-deleted users

Currently usr_login_data only records user id and ctime (for login
time) but one could also add more columns tothe table if needing to
record something that happens once per successful login.

Change-Id: If59b207356894eaced7b9977b80d539a28cb7e56
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>