behatnotneeded

Change-Id: I9c0c82dd9c788bcab1ec1efb6cd1a2cba688e887

Aaron Wells authored Nov 13, 2015 and Robert Lyon committed Mar 22, 2016

... so that we don't bother doing setup just to get
to testRun() and realize we're skipping this test

behatnotneeded: phpunit, not behat

Change-Id: I0c96e364129435f9eca3f0cb3bb44beaf9db4701

Aaron Wells authored Nov 13, 2015 and Robert Lyon committed Mar 22, 2016

behatnotneeded: This is phpunit, not behat. ;)

Change-Id: I906089c82c6e5ca521007359006b49381c537f2b

This version simplifies how we deal with cookie consent
All a user has to do is acknowledge that they understand that the site
uses cookies and if they want to know more they can follow the link to
the cookie policy of the site.

Change-Id: I8a757cb09487167b0bc655d75c3625a0e1d7d0d7
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Aaron Wells authored Mar 15, 2016 and Robert Lyon committed Mar 22, 2016

Change-Id: I71c3afc2b3a4e07f4bbba1bb356d86911ab4b332

Aaron Wells authored Mar 21, 2016 and Robert Lyon committed Mar 22, 2016

Bug 1559796: Because the block config modal's "X" closer button is
outside of the <form> tags of the new block, the standard form change
checker code wasn't binding the "reset" event to it.

Also, because the form change checker was written with the assumption
that each form submitted to it would have a unique ID, you wind up with
tons of forms in the formcheckers list, all with the same "instconf" id,
one for each time you open the modal.

Change-Id: I26c06c322d5c876e406a203647676cd73cda511d

As they are set to TITLE we can just assign TITLE to PAGEHEADING in
the smarty function call.

We can later override the PAGEHRADING with
$smarty->assign('PAGEHEADING', string); if we need to.

Have also updated a few files where TITLE was not defined.

behatnotneeded - everything should work as before

Change-Id: I3ea592cd37344e68c6e90a3c64947cf99db59471
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Son Nguyen authored Mar 07, 2016 and Robert Lyon committed Mar 21, 2016

Add behat tests

Change-Id: I905af729d2cda76d5c6ff31b29b9d21c3dc67505

To make this similar to PAGEHEADING / TITLE for consistency

This allows the for it to display when an AccessDeniedException is
thrown.

Also fixing up where the PAGEHEADING / SUBSECTIONHEADING were set in
the wrong order.

behatnotneeded - existing tests should be fine

Change-Id: Ife016639aa8f444e6d3f3183e3753cd9f8e9aae4
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Now that 'mahara' can have blog/blogpost artefacts we want to ignore
them from site menus options for logged in links

Change-Id: I8d1be32678ae97d93187181eb4aedcb331e543eb
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Because if we have a latest pages block but no group pages listed then
the template will not initially compile as there has been no call to
require lib/group.php

Actually we should avoid having non basic function calls in the template
so I'll move all instances of group_homepage_url() in templates out
to the php that generates the data.

behatnotneeded

Change-Id: Ia804fee854418e7b3b3620c998f2219a0b0d6f25
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

When deleting users

Change-Id: Ie94c0e2d045b84dd5e7f227e2d571fdedc5eae5e
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Aaron Wells authored Mar 16, 2016 and Robert Lyon committed Mar 19, 2016

Bug 1557896: When you first click in Select2, it fires off an
aqax request with no "q" value (because there's no query string
yet). We return a "required parameter missing" error message in
a JSON object, which causes a Javascript warning in the browser.

Better to just treat it like an empty q, instead of a missing q.

behatnotneeded - unable to test for issues in console

Change-Id: I81c4cfe77c51fce735cfd2628aaed1e40cc35940

behatnotneeded

Change-Id: I6c59b9bb13384f0a4cdf71d1ab82fb219a9137ee

This is an interim fix only until the functionality
can be corrected to not allow people to pick access
dates outside of the overriding start / end dates.

behatnotneeded: Just a lang string that doesn't
exist in a test yet.

Change-Id: Iff7841084a798e5e184a9842465ac947c62b000d

Liam Sharpe authored Mar 17, 2016 and Kristina Hoeppner committed Mar 18, 2016

behatnotneeded

Change-Id: Idcb92dda82a8f1eaafa20f258639b5e2d2b78113

When we upgrade from earlier versions views need to be saved that
expect the numcolumns field to exist before we get round to dropping
it. So the View class needs to be able to define a default value for
it.

behatnotneeded - unable to test upgrades

Change-Id: Ic70add18e814975289a7145e8e91454e3699a234
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

There was a setting to stop the login link (top right) from showing if
there were sidebars on logged out homepage. This became a problem if
the login box was turned off (not counted as a sidebar block for some
reason) via $cfg->showloginsideblock = false;

But the top right login link should always show when logged out
whether a sidebar is in play or not.

behatnotneeded

Change-Id: I8d6c1916f165285afb1f0210a0ae9b364f3a7a4f
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>